| Message ID | 20200316142928.153431-6-its@irrelevant.dk |
|---|---|
| State | New |
| Headers | show |
| Series | nvme: support NVMe v1.3d, SGLs and multiple namespaces | expand |
On Mon, 2020-03-16 at 07:28 -0700, Klaus Jensen wrote: > From: Klaus Jensen <k.jensen@samsung.com> > > Signed-off-by: Klaus Jensen <k.jensen@samsung.com> > --- > hw/block/nvme.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/block/nvme.c b/hw/block/nvme.c > index 40cb176dea3c..f716f690a594 100644 > --- a/hw/block/nvme.c > +++ b/hw/block/nvme.c > @@ -679,7 +679,7 @@ static uint16_t nvme_identify_ns(NvmeCtrl *n, NvmeIdentify *c) > > static uint16_t nvme_identify_nslist(NvmeCtrl *n, NvmeIdentify *c) > { > - static const int data_len = 4 * KiB; > + static const int data_len = NVME_IDENTIFY_DATA_SIZE; > uint32_t min_nsid = le32_to_cpu(c->nsid); > uint64_t prp1 = le64_to_cpu(c->prp1); > uint64_t prp2 = le64_to_cpu(c->prp2); I'll probably squash this with some other refactoring patch, but I absolutely don't mind leaving this as is. Fine grained patches never cause any harm. Reviewed-by: Maxim Levitsky <mlevitsk@redhat.com> Best regards, Maxim Levitsky
On Mar 25 12:37, Maxim Levitsky wrote: > On Mon, 2020-03-16 at 07:28 -0700, Klaus Jensen wrote: > > From: Klaus Jensen <k.jensen@samsung.com> > > > > Signed-off-by: Klaus Jensen <k.jensen@samsung.com> > > --- > > hw/block/nvme.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/hw/block/nvme.c b/hw/block/nvme.c > > index 40cb176dea3c..f716f690a594 100644 > > --- a/hw/block/nvme.c > > +++ b/hw/block/nvme.c > > @@ -679,7 +679,7 @@ static uint16_t nvme_identify_ns(NvmeCtrl *n, NvmeIdentify *c) > > > > static uint16_t nvme_identify_nslist(NvmeCtrl *n, NvmeIdentify *c) > > { > > - static const int data_len = 4 * KiB; > > + static const int data_len = NVME_IDENTIFY_DATA_SIZE; > > uint32_t min_nsid = le32_to_cpu(c->nsid); > > uint64_t prp1 = le64_to_cpu(c->prp1); > > uint64_t prp2 = le64_to_cpu(c->prp2); > > I'll probably squash this with some other refactoring patch, > but I absolutely don't mind leaving this as is. > Fine grained patches never cause any harm. > Squashed into 06/42. > Reviewed-by: Maxim Levitsky <mlevitsk@redhat.com> > > Best regards, > Maxim Levitsky > > > >
diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 40cb176dea3c..f716f690a594 100644 --- a/hw/block/nvme.c +++ b/hw/block/nvme.c @@ -679,7 +679,7 @@ static uint16_t nvme_identify_ns(NvmeCtrl *n, NvmeIdentify *c) static uint16_t nvme_identify_nslist(NvmeCtrl *n, NvmeIdentify *c) { - static const int data_len = 4 * KiB; + static const int data_len = NVME_IDENTIFY_DATA_SIZE; uint32_t min_nsid = le32_to_cpu(c->nsid); uint64_t prp1 = le64_to_cpu(c->prp1); uint64_t prp2 = le64_to_cpu(c->prp2);