Patchwork [testsuite/darwin] fix PR testsuite/51059

login
register
mail settings
Submitter IainS
Date Nov. 14, 2011, 11:55 a.m.
Message ID <9D73743C-8B88-4445-9690-4E8D99CC1DA7@sandoe-acoustics.co.uk>
Download mbox | patch
Permalink /patch/125517/
State New
Headers show

Comments

IainS - Nov. 14, 2011, 11:55 a.m.
Hi Rainer,

On 14 Nov 2011, at 09:50, Rainer Orth wrote:
>> +/* { dg-options "-O2 -fprofile-arcs -ftest-coverage  - 
>> flat_namespace -
>> undefined suppress" { target *-*-darwin* }  } */
>> /* { dg-require-weak "" } */
>
> I'd prefer if you'd use the new dg-additional-options instead of
> duplicating the complete set of default options.

I confess, I'd missed the arrival of that option .. very useful!

I applied the following as an obvious adjustment of the approved patch  
(after a re-check).

gcc/testsuite:

	PR testsuite/51059
	* gcc.misc-tests/gcov-14.c (dg-options): Adjust to use
	dg-additional-options.

  	* gcc.target/sh/pr21255-2-ml.c: Skip if -mb or -m5* is
  /* { dg-require-weak "" } */
  /* { dg-do run { target native } } */

Patch

Index: gcc/testsuite/gcc.misc-tests/gcov-14.c
===================================================================
--- gcc/testsuite/gcc.misc-tests/gcov-14.c	(revision 181349)
+++ gcc/testsuite/gcc.misc-tests/gcov-14.c	(working copy)
@@ -2,7 +2,7 @@ 

  /* { dg-options "-O2 -fprofile-arcs -ftest-coverage" } */
  /* The following line arranges that Darwin has behavior like elf  
weak import.  */
-/* { dg-options "-O2 -fprofile-arcs -ftest-coverage  -flat_namespace - 
undefined suppress" { target *-*-darwin* }  } */
+/* { dg-additional-options "-flat_namespace -undefined  
suppress" { target *-*-darwin* }  } */