Patchwork arm: tegra: export tegra_chip_uid

login
register
mail settings
Submitter Varun Wadekar
Date Nov. 14, 2011, 5:30 a.m.
Message ID <1321248620-5147-1-git-send-email-vwadekar@nvidia.com>
Download mbox | patch
Permalink /patch/125472/
State New, archived
Headers show

Comments

Varun Wadekar - Nov. 14, 2011, 5:30 a.m.
the crypto driver will need this api to use
it in the rng calculations. in order to build
the crypto driver as a module, tegra_chip_uid
has to be exported.

Original author: Henning Heinold <heinold@inf.fu-berlin.de>
Signed-off-by: Varun Wadekar <vwadekar@nvidia.com>
---
 arch/arm/mach-tegra/fuse.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Olof Johansson - Nov. 14, 2011, 6:37 p.m.
On Sun, Nov 13, 2011 at 9:30 PM, Varun Wadekar <vwadekar@nvidia.com> wrote:
> the crypto driver will need this api to use
> it in the rng calculations. in order to build
> the crypto driver as a module, tegra_chip_uid
> has to be exported.

Please use proper capitalization.

> Original author: Henning Heinold <heinold@inf.fu-berlin.de>

See instructions from Stephen on the other patch. Also, if Henning
wrote it, why doesn't it have his signed-off-by?

> Signed-off-by: Varun Wadekar <vwadekar@nvidia.com>
> ---
>  arch/arm/mach-tegra/fuse.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-tegra/fuse.c b/arch/arm/mach-tegra/fuse.c
> index 1fa26d9..ea49bd9 100644
> --- a/arch/arm/mach-tegra/fuse.c
> +++ b/arch/arm/mach-tegra/fuse.c
> @@ -19,6 +19,7 @@
>
>  #include <linux/kernel.h>
>  #include <linux/io.h>
> +#include <linux/module.h>
>
>  #include <mach/iomap.h>
>
> @@ -58,6 +59,7 @@ unsigned long long tegra_chip_uid(void)
>        hi = fuse_readl(FUSE_UID_HIGH);
>        return (hi << 32ull) | lo;
>  }
> +EXPORT_SYMBOL(tegra_chip_uid);
>
>  int tegra_sku_id(void)
>  {
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Henning Heinold - Nov. 14, 2011, 9:09 p.m.
On Mon, Nov 14, 2011 at 10:37:17AM -0800, Olof Johansson wrote:
> On Sun, Nov 13, 2011 at 9:30 PM, Varun Wadekar <vwadekar@nvidia.com> wrote:
> > the crypto driver will need this api to use
> > it in the rng calculations. in order to build
> > the crypto driver as a module, tegra_chip_uid
> > has to be exported.
> 
> Please use proper capitalization.
> 
> > Original author: Henning Heinold <heinold@inf.fu-berlin.de>
> 
> See instructions from Stephen on the other patch. Also, if Henning
> wrote it, why doesn't it have his signed-off-by?

Hi Varun,

feel free to add Signed-off-by from me.

Bye Henning
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/arch/arm/mach-tegra/fuse.c b/arch/arm/mach-tegra/fuse.c
index 1fa26d9..ea49bd9 100644
--- a/arch/arm/mach-tegra/fuse.c
+++ b/arch/arm/mach-tegra/fuse.c
@@ -19,6 +19,7 @@ 
 
 #include <linux/kernel.h>
 #include <linux/io.h>
+#include <linux/module.h>
 
 #include <mach/iomap.h>
 
@@ -58,6 +59,7 @@  unsigned long long tegra_chip_uid(void)
 	hi = fuse_readl(FUSE_UID_HIGH);
 	return (hi << 32ull) | lo;
 }
+EXPORT_SYMBOL(tegra_chip_uid);
 
 int tegra_sku_id(void)
 {