From patchwork Mon Nov 14 04:21:28 2011
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: ARM: pxa168/gplugd: add the correct SSP device
From: Eric Miao <eric.y.miao@gmail.com>
X-Patchwork-Id: 125467
Message-Id: <CAMPhdO_X0n9L6HF1TSChzWt34=atJrr4=FR8h7PJ0hh0beJ6Pw@mail.gmail.com>
To: Tanmay Upadhyay <tanmay.upadhyay@einfochips.com>
Cc: linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Date: Mon, 14 Nov 2011 12:21:28 +0800

On Sat, Nov 12, 2011 at 12:02 AM, Tanmay Upadhyay
<tanmay.upadhyay@einfochips.com> wrote:
>
>
> On Friday 11 November 2011 05:49 PM, Eric Miao wrote:
>>
>> There is no SSP0, but SSP2 is used on gplugd.
>>
>> Cc: Tanmay Upadhyay<tanmay.upadhyay@einfochips.com>
>> Signed-off-by: Eric Miao<eric.y.miao@gmail.com>
>> ---
>>  arch/arm/mach-mmp/gplugd.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/mach-mmp/gplugd.c b/arch/arm/mach-mmp/gplugd.c
>> index 6915656..0469c74 100644
>> --- a/arch/arm/mach-mmp/gplugd.c
>> +++ b/arch/arm/mach-mmp/gplugd.c
>> @@ -182,7 +182,7 @@ static void __init gplugd_init(void)
>>
>>        /* on-chip devices */
>>        pxa168_add_uart(3);
>> -       pxa168_add_ssp(0);
>> +       pxa168_add_ssp(2);
>>        pxa168_add_twsi(0, NULL, ARRAY_AND_SIZE(gplugd_i2c_board_info));
>>
>>        pxa168_add_eth(&gplugd_eth_platform_data);
>
> Hi Eric,
>
> HDMI chip (TDA9981A) on gplugD gets audio data from SSP0 - used as I2S. Page
> # 7 of [1] & page # 1 & 3 of [2] indicates this.

Shouldn't this be SSP1 instead, if following the public PXA168 software
manual (there is no SSP0, and the existing code doesn't suppport it)

> SSP2 is also used on gplugD
> as SPI to talk to the NOR flash.

If ignoring this port at this moment, how about the patch below?

    ARM: pxa168/gplugd: add the correct SSP device

    There is no SSP0, but SSP1 is used on gplugd as an I2S port.

    Cc: Tanmay Upadhyay <tanmay.upadhyay@einfochips.com>
    Signed-off-by: Eric Miao <eric.y.miao@gmail.com>


diff --git a/arch/arm/mach-mmp/gplugd.c b/arch/arm/mach-mmp/gplugd.c
index 6915656..4665767 100644
--- a/arch/arm/mach-mmp/gplugd.c
+++ b/arch/arm/mach-mmp/gplugd.c
@@ -182,7 +182,7 @@ static void __init gplugd_init(void)

        /* on-chip devices */
        pxa168_add_uart(3);
-       pxa168_add_ssp(0);
+       pxa168_add_ssp(1);
        pxa168_add_twsi(0, NULL, ARRAY_AND_SIZE(gplugd_i2c_board_info));

        pxa168_add_eth(&gplugd_eth_platform_data);