diff mbox

[1.0] x86: fix pcmpestrm and pcmpistrm

Message ID CAAu8pHvB8ZVPm8mBwh6FAfy0e5-TR-56yxiK=evo-cdUhqtocA@mail.gmail.com
State New
Headers show

Commit Message

Blue Swirl Nov. 13, 2011, 11:32 a.m. UTC 
Fix obvious typos (decrement and off-by-one error) in pcmpestrm and pcmpistrm
which resulted in infinite loop. Reported by Frank Mehnert,
spotted also by Coverity (bug 84752853).

Reported-by: Frank Mehnert <frank.mehnert@oracle.com>
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
---
 target-i386/ops_sse.h |   12 ++++++++----
 1 files changed, 8 insertions(+), 4 deletions(-)

         d->Q(0) = res;
@@ -2028,11 +2030,13 @@ void glue(helper_pcmpistrm, SUFFIX) (Reg *d,
Reg *s, uint32_t ctrl)

     if ((ctrl >> 6) & 1) {
         if (ctrl & 1)
-            for (i = 0; i <= 8; i--, res >>= 1)
+            for (i = 0; i < 8; i++, res >>= 1) {
                 d->W(i) = (res & 1) ? ~0 : 0;
+            }
         else
-            for (i = 0; i <= 16; i--, res >>= 1)
+            for (i = 0; i < 16; i++, res >>= 1) {
                 d->B(i) = (res & 1) ? ~0 : 0;
+            }
     } else {
         d->Q(1) = 0;
         d->Q(0) = res;
diff mbox

Patch

diff --git a/target-i386/ops_sse.h b/target-i386/ops_sse.h
index aa41d25..47dde78 100644
--- a/target-i386/ops_sse.h
+++ b/target-i386/ops_sse.h
@@ -1996,11 +1996,13 @@  void glue(helper_pcmpestrm, SUFFIX) (Reg *d,
Reg *s, uint32_t ctrl)

     if ((ctrl >> 6) & 1) {
         if (ctrl & 1)
-            for (i = 0; i <= 8; i--, res >>= 1)
+            for (i = 0; i < 8; i++, res >>= 1) {
                 d->W(i) = (res & 1) ? ~0 : 0;
+            }
         else
-            for (i = 0; i <= 16; i--, res >>= 1)
+            for (i = 0; i < 16; i++, res >>= 1) {
                 d->B(i) = (res & 1) ? ~0 : 0;
+            }
     } else {
         d->Q(1) = 0;