| Message ID | 20200312101029.313634-1-i.maximets@ovn.org |
|---|---|
| State | Accepted |
| Delegated to: | Ilya Maximets |
| Headers | show |
| Series | [ovs-dev] travis: Disable sindex build in sparse. | expand |
On Thu, Mar 12, 2020 at 3:40 PM Ilya Maximets <i.maximets@ovn.org> wrote: > > Sparse introduced a new utility 'sindex' for semantic search, > but unfortunately it fails to build in Travis environment. > Disabling it explicitely as we don't need it anyway. > > Signed-off-by: Ilya Maximets <i.maximets@ovn.org> > --- > > Needs to be backported down to 2.12. > Same patch needed for OVN repo. Could send separately. That'd be great. Numan > > .travis/linux-prepare.sh | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/.travis/linux-prepare.sh b/.travis/linux-prepare.sh > index fda13e7d2..8cbbd5623 100755 > --- a/.travis/linux-prepare.sh > +++ b/.travis/linux-prepare.sh > @@ -7,9 +7,11 @@ set -ev > # Explicitly disable sparse support for llvm because some travis > # environments claim to have LLVM (llvm-config exists and works) but > # linking against it fails. > +# Disabling sqlite support because sindex build fails and we don't > +# really need this utility being installed. > git clone git://git.kernel.org/pub/scm/devel/sparse/sparse.git > cd sparse > -make -j4 HAVE_LLVM= install > +make -j4 HAVE_LLVM= HAVE_SQLITE= install > cd .. > > pip3 install --disable-pip-version-check --user flake8 hacking > -- > 2.24.1 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
On 3/12/20 11:13 AM, Numan Siddique wrote: > On Thu, Mar 12, 2020 at 3:40 PM Ilya Maximets <i.maximets@ovn.org> wrote: >> >> Sparse introduced a new utility 'sindex' for semantic search, >> but unfortunately it fails to build in Travis environment. >> Disabling it explicitely as we don't need it anyway. >> >> Signed-off-by: Ilya Maximets <i.maximets@ovn.org> >> --- >> >> Needs to be backported down to 2.12. >> Same patch needed for OVN repo. Could send separately. > > That'd be great. Done. > > Numan > >> >> .travis/linux-prepare.sh | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/.travis/linux-prepare.sh b/.travis/linux-prepare.sh >> index fda13e7d2..8cbbd5623 100755 >> --- a/.travis/linux-prepare.sh >> +++ b/.travis/linux-prepare.sh >> @@ -7,9 +7,11 @@ set -ev >> # Explicitly disable sparse support for llvm because some travis >> # environments claim to have LLVM (llvm-config exists and works) but >> # linking against it fails. >> +# Disabling sqlite support because sindex build fails and we don't >> +# really need this utility being installed. >> git clone git://git.kernel.org/pub/scm/devel/sparse/sparse.git >> cd sparse >> -make -j4 HAVE_LLVM= install >> +make -j4 HAVE_LLVM= HAVE_SQLITE= install >> cd .. >> >> pip3 install --disable-pip-version-check --user flake8 hacking >> -- >> 2.24.1 >> >> _______________________________________________ >> dev mailing list >> dev@openvswitch.org >> https://mail.openvswitch.org/mailman/listinfo/ovs-dev >>
On Thu, Mar 12, 2020 at 4:10 PM Ilya Maximets <i.maximets@ovn.org> wrote: > > On 3/12/20 11:13 AM, Numan Siddique wrote: > > On Thu, Mar 12, 2020 at 3:40 PM Ilya Maximets <i.maximets@ovn.org> wrote: > >> > >> Sparse introduced a new utility 'sindex' for semantic search, > >> but unfortunately it fails to build in Travis environment. > >> Disabling it explicitely as we don't need it anyway. > >> > >> Signed-off-by: Ilya Maximets <i.maximets@ovn.org> Acked-by: Numan Siddique <numans@ovn.org> Numan > >> --- > >> > >> Needs to be backported down to 2.12. > >> Same patch needed for OVN repo. Could send separately. > > > > That'd be great. > > Done. > > > > > Numan > > > >> > >> .travis/linux-prepare.sh | 4 +++- > >> 1 file changed, 3 insertions(+), 1 deletion(-) > >> > >> diff --git a/.travis/linux-prepare.sh b/.travis/linux-prepare.sh > >> index fda13e7d2..8cbbd5623 100755 > >> --- a/.travis/linux-prepare.sh > >> +++ b/.travis/linux-prepare.sh > >> @@ -7,9 +7,11 @@ set -ev > >> # Explicitly disable sparse support for llvm because some travis > >> # environments claim to have LLVM (llvm-config exists and works) but > >> # linking against it fails. > >> +# Disabling sqlite support because sindex build fails and we don't > >> +# really need this utility being installed. > >> git clone git://git.kernel.org/pub/scm/devel/sparse/sparse.git > >> cd sparse > >> -make -j4 HAVE_LLVM= install > >> +make -j4 HAVE_LLVM= HAVE_SQLITE= install > >> cd .. > >> > >> pip3 install --disable-pip-version-check --user flake8 hacking > >> -- > >> 2.24.1 > >> > >> _______________________________________________ > >> dev mailing list > >> dev@openvswitch.org > >> https://mail.openvswitch.org/mailman/listinfo/ovs-dev > >> > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
On 3/12/20 11:45 AM, Numan Siddique wrote: > On Thu, Mar 12, 2020 at 4:10 PM Ilya Maximets <i.maximets@ovn.org> wrote: >> >> On 3/12/20 11:13 AM, Numan Siddique wrote: >>> On Thu, Mar 12, 2020 at 3:40 PM Ilya Maximets <i.maximets@ovn.org> wrote: >>>> >>>> Sparse introduced a new utility 'sindex' for semantic search, >>>> but unfortunately it fails to build in Travis environment. >>>> Disabling it explicitely as we don't need it anyway. >>>> >>>> Signed-off-by: Ilya Maximets <i.maximets@ovn.org> > > Acked-by: Numan Siddique <numans@ovn.org> Thanks! Applied to master and backported. Best regards, Ilya Maximets.
diff --git a/.travis/linux-prepare.sh b/.travis/linux-prepare.sh index fda13e7d2..8cbbd5623 100755 --- a/.travis/linux-prepare.sh +++ b/.travis/linux-prepare.sh @@ -7,9 +7,11 @@ set -ev # Explicitly disable sparse support for llvm because some travis # environments claim to have LLVM (llvm-config exists and works) but # linking against it fails. +# Disabling sqlite support because sindex build fails and we don't +# really need this utility being installed. git clone git://git.kernel.org/pub/scm/devel/sparse/sparse.git cd sparse -make -j4 HAVE_LLVM= install +make -j4 HAVE_LLVM= HAVE_SQLITE= install cd .. pip3 install --disable-pip-version-check --user flake8 hacking
Sparse introduced a new utility 'sindex' for semantic search, but unfortunately it fails to build in Travis environment. Disabling it explicitely as we don't need it anyway. Signed-off-by: Ilya Maximets <i.maximets@ovn.org> --- Needs to be backported down to 2.12. Same patch needed for OVN repo. Could send separately. .travis/linux-prepare.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)