diff mbox series

[ovs-dev,ovn] travis: Avoid skipping of interconnection tests.

Message ID 20200311162635.309077-1-i.maximets@ovn.org
State Accepted
Headers show
Series [ovs-dev,ovn] travis: Avoid skipping of interconnection tests. | expand

Commit Message

Ilya Maximets March 11, 2020, 4:26 p.m. UTC
Following tests has no 'ovn' keyword and always skipped by TravisCI:

 204: ovn-ic-nbctl.at:25 ovn-ic-nbctl
 205: ovn-ic-sbctl.at:25 ovn-ic-sbctl
 217: ovn-ic.at:2        ovn-ic -- AZ register
 218: ovn-ic.at:30       ovn-ic -- transit switch handling
 219: ovn-ic.at:70       ovn-ic -- gateway sync
 220: ovn-ic.at:126      ovn-ic -- port sync
 221: ovn-ic.at:190      ovn-ic -- route sync
 222: checkpatch.at:37   checkpatch - sign-offs
 223: checkpatch.at:177  checkpatch - parenthesized constructs
 224: checkpatch.at:238  checkpatch - parenthesized constructs - for
 225: checkpatch.at:293  checkpatch - comments
 226: checkpatch.at:315  checkpatch - whitespace around operator

Even though checkpatch ones are not very important, interconnection
tests might be valuable and should be tested.

Fixes: a6f5e39c17d7 ("travis CI: Trim down the linux-build.sh")
Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
---
 .travis/linux-build.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Numan Siddique March 12, 2020, 10:10 a.m. UTC | #1
On Wed, Mar 11, 2020 at 9:56 PM Ilya Maximets <i.maximets@ovn.org> wrote:
>
> Following tests has no 'ovn' keyword and always skipped by TravisCI:
>
>  204: ovn-ic-nbctl.at:25 ovn-ic-nbctl
>  205: ovn-ic-sbctl.at:25 ovn-ic-sbctl
>  217: ovn-ic.at:2        ovn-ic -- AZ register
>  218: ovn-ic.at:30       ovn-ic -- transit switch handling
>  219: ovn-ic.at:70       ovn-ic -- gateway sync
>  220: ovn-ic.at:126      ovn-ic -- port sync
>  221: ovn-ic.at:190      ovn-ic -- route sync
>  222: checkpatch.at:37   checkpatch - sign-offs
>  223: checkpatch.at:177  checkpatch - parenthesized constructs
>  224: checkpatch.at:238  checkpatch - parenthesized constructs - for
>  225: checkpatch.at:293  checkpatch - comments
>  226: checkpatch.at:315  checkpatch - whitespace around operator
>
> Even though checkpatch ones are not very important, interconnection
> tests might be valuable and should be tested.
>
> Fixes: a6f5e39c17d7 ("travis CI: Trim down the linux-build.sh")
> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>

Thanks Ilya. I applied this patch to master.

Numan

> ---
>  .travis/linux-build.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.travis/linux-build.sh b/.travis/linux-build.sh
> index 1d08eb35c..134b4cbca 100755
> --- a/.travis/linux-build.sh
> +++ b/.travis/linux-build.sh
> @@ -42,7 +42,7 @@ if [ "$TESTSUITE" ]; then
>      configure_ovn
>
>      export DISTCHECK_CONFIGURE_FLAGS="$OPTS --with-ovs-source=$PWD/ovs_src"
> -    if ! make distcheck -j4 TESTSUITEFLAGS="-j4 -k ovn" RECHECK=yes; then
> +    if ! make distcheck -j4 TESTSUITEFLAGS="-j4" RECHECK=yes; then
>          # testsuite.log is necessary for debugging.
>          cat */_build/sub/tests/testsuite.log
>          exit 1
> --
> 2.24.1
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
diff mbox series

Patch

diff --git a/.travis/linux-build.sh b/.travis/linux-build.sh
index 1d08eb35c..134b4cbca 100755
--- a/.travis/linux-build.sh
+++ b/.travis/linux-build.sh
@@ -42,7 +42,7 @@  if [ "$TESTSUITE" ]; then
     configure_ovn
 
     export DISTCHECK_CONFIGURE_FLAGS="$OPTS --with-ovs-source=$PWD/ovs_src"
-    if ! make distcheck -j4 TESTSUITEFLAGS="-j4 -k ovn" RECHECK=yes; then
+    if ! make distcheck -j4 TESTSUITEFLAGS="-j4" RECHECK=yes; then
         # testsuite.log is necessary for debugging.
         cat */_build/sub/tests/testsuite.log
         exit 1