From patchwork Fri Nov 11 20:26:09 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chuck Lever X-Patchwork-Id: 125281 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "acsinet15.oracle.com", Issuer "VeriSign Class 3 International Server CA - G3" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 827751007D8 for ; Sat, 12 Nov 2011 07:26:23 +1100 (EST) Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by acsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id pABKQJZa029518 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 11 Nov 2011 20:26:20 GMT Received: from oss.oracle.com (oss.oracle.com [141.146.12.120]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id pABKQJDe018103 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 11 Nov 2011 20:26:19 GMT Received: from localhost ([127.0.0.1] helo=oss.oracle.com) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1ROxfy-00075z-AW; Fri, 11 Nov 2011 12:26:14 -0800 Received: from acsinet13.oracle.com ([141.146.126.235]) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1ROxfx-00075s-Kf for fedfs-utils-devel@oss.oracle.com; Fri, 11 Nov 2011 12:26:13 -0800 Received: from mail-yw0-f43.google.com (mail-yw0-f43.google.com [209.85.213.43]) by acsinet13.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id pABKQBAn003554 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=FAIL) for ; Fri, 11 Nov 2011 20:26:13 GMT Received: by ywn1 with SMTP id 1so2687307ywn.2 for ; Fri, 11 Nov 2011 12:26:11 -0800 (PST) Received: by 10.50.213.40 with SMTP id np8mr14301976igc.10.1321043170951; Fri, 11 Nov 2011 12:26:10 -0800 (PST) Received: from degas.1015granger.net ([99.26.161.222]) by mx.google.com with ESMTPS id a6sm9542113igc.3.2011.11.11.12.26.10 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 11 Nov 2011 12:26:10 -0800 (PST) From: Chuck Lever To: fedfs-utils-devel@oss.oracle.com Date: Fri, 11 Nov 2011 15:26:09 -0500 Message-ID: <20111111202609.10717.29750.stgit@degas.1015granger.net> In-Reply-To: <20111111202105.10717.28436.stgit@degas.1015granger.net> References: <20111111202105.10717.28436.stgit@degas.1015granger.net> User-Agent: StGIT/0.14.3 MIME-Version: 1.0 X-Flow-Control-Info: class=ISPs ip=209.85.213.43 ct-class=G1 ct-vol1=0 ct-vol2=0 ct-vol3=0 ct-risk=0 ct-spam1=0 ct-spam2=0 ct-bulk=0 rcpts=1 size=2097 Subject: [fedfs-utils] [PATCH 01/12] build: Make new warnings easier to see X-BeenThere: fedfs-utils-devel@oss.oracle.com X-Mailman-Version: 2.1.9 Precedence: list Reply-To: fedfs-utils Developers List-Id: fedfs-utils Developers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: fedfs-utils-devel-bounces@oss.oracle.com Errors-To: fedfs-utils-devel-bounces@oss.oracle.com X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-CT-RefId: str=0001.0A090203.4EBD84EC.006A:SCFSTAT1119972, ss=1, re=-4.000, fgs=0 X-Auth-Type: Internal IP We want to see any newly introduced automake problems immediately, so enable automake warnings with "-Wall -Werror". Use "git clean" as a check-in test to help expose problems with missing or untracked files. Also, enable quiet building to make new compiler and linker warnings easier to see. With "make -s" we now get: ... Making all in nsdbparams CC main.o CCLD nsdbparams Making all in resolve-junction CC main.o CC privilege.o CCLD resolve-junction ... making warnings stand out clearly. Unfortunately I don't see a way to make silent builds the default behavior, though: you still have to request it explicitly via: ./configure --enable-silent-rules Signed-off-by: Chuck Lever --- configure.ac | 2 +- doc/CheckInTests | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index b26a4a7..3a4316e 100644 --- a/configure.ac +++ b/configure.ac @@ -34,7 +34,7 @@ AC_CONFIG_MACRO_DIR([m4]) # Automake and libtools initialization LT_INIT -AM_INIT_AUTOMAKE +AM_INIT_AUTOMAKE([-Wall -Werror silent-rules]) # configure command line options AC_ARG_WITH([fedfsuser], diff --git a/doc/CheckInTests b/doc/CheckInTests index fc67da3..550e6d5 100644 --- a/doc/CheckInTests +++ b/doc/CheckInTests @@ -82,11 +82,13 @@ This is basic stuff that's easy to run, and should be working for bisecting to be useful. 1. "autogen.sh" and "configure" must run without error - 2. "make" must complete without error; No new compiler warnings + 2. "./configure --enable-silent-rules; make -s" must complete without + error, and without new compiler warnings 3. "make doxy" must complete with no errors or warnings 4. "make distcheck" must complete without error 5. "git status" must produce no output on a clean tree 6. "git log -p" shows no new white space damage + 7. "git clean -d -f -x" does not break anything Note that to preserve bisectability, the tree MUST build after each commit.