From patchwork Fri Nov 11 16:37:26 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [1/3] pseries: Fix initialization of sPAPREnvironment structure Date: Fri, 11 Nov 2011 06:37:26 -0000 From: Alexander Graf X-Patchwork-Id: 125214 Message-Id: <1321029448-11010-2-git-send-email-agraf@suse.de> To: qemu-devel Developers Cc: blauwirbel@gmail.com, David Gibson From: David Gibson Since we added PCI support to the pseries machine, we include a qlist of PCI host bridges in the sPAPREnvironment structure. However this list was never properly initialized it. Somehow we got away with this until some other recent change broke it, and we now segfault immediately on startup. This patch adds the required QLIST_INIT(), and while we're at it makes sure we initialize the rest of the sPAPREnvironment structure to 0, to avoid future nasty surprises. Signed-off-by: David Gibson Signed-off-by: Alexander Graf --- hw/spapr.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/spapr.c b/hw/spapr.c index bdaa938..40cfc9b 100644 --- a/hw/spapr.c +++ b/hw/spapr.c @@ -407,7 +407,9 @@ static void ppc_spapr_init(ram_addr_t ram_size, long pteg_shift = 17; char *filename; - spapr = g_malloc(sizeof(*spapr)); + spapr = g_malloc0(sizeof(*spapr)); + QLIST_INIT(&spapr->phbs); + cpu_ppc_hypercall = emulate_spapr_hypercall; /* Allocate RMA if necessary */