diff mbox series

package/python-markdown: fix Python version dependency

Message ID 20200310114101.6726-1-yegorslists@googlemail.com
State Accepted
Headers show
Series package/python-markdown: fix Python version dependency | expand

Commit Message

Yegor Yefremov March 10, 2020, 11:41 a.m. UTC 
From: Yegor Yefremov <yegorslists@googlemail.com>

The latest version has dropped Python 2 support.

Fixes:
http://autobuild.buildroot.net/results/6d1e796f6658accb3eafef265935db5e464638fe

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
 package/python-markdown/Config.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Asaf Kahlon March 10, 2020, 6:53 p.m. UTC | #1 
On Tue, Mar 10, 2020 at 1:41 PM <yegorslists@googlemail.com> wrote:
>
> From: Yegor Yefremov <yegorslists@googlemail.com>
>
> The latest version has dropped Python 2 support.
>
> Fixes:
> http://autobuild.buildroot.net/results/6d1e796f6658accb3eafef265935db5e464638fe
>
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
>  package/python-markdown/Config.in | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/python-markdown/Config.in b/package/python-markdown/Config.in
> index 6706684142..454c2729bd 100644
> --- a/package/python-markdown/Config.in
> +++ b/package/python-markdown/Config.in
> @@ -1,8 +1,8 @@
>  config BR2_PACKAGE_PYTHON_MARKDOWN
>         bool "python-markdown"
> +       depends on BR2_PACKAGE_PYTHON3
>         # runtime dependency on Python's xml module
> -       select BR2_PACKAGE_PYTHON_PYEXPAT if BR2_PACKAGE_PYTHON
> -       select BR2_PACKAGE_PYTHON3_PYEXPAT if BR2_PACKAGE_PYTHON3
> +       select BR2_PACKAGE_PYTHON3_PYEXPAT
>         help
>           This is a Python implementation of John Gruber's Markdown
>
> --
> 2.17.0
>

Reviewed-by: Asaf Kahlon <asafka7@gmail.com>

Regards,
Asaf.
Yegor Yefremov March 11, 2020, 9:13 a.m. UTC | #2 
Hi all,

On Tue, Mar 10, 2020 at 7:53 PM Asaf Kahlon <asafka7@gmail.com> wrote:
>
> On Tue, Mar 10, 2020 at 1:41 PM <yegorslists@googlemail.com> wrote:
> >
> > From: Yegor Yefremov <yegorslists@googlemail.com>
> >
> > The latest version has dropped Python 2 support.
> >
> > Fixes:
> > http://autobuild.buildroot.net/results/6d1e796f6658accb3eafef265935db5e464638fe
> >
> > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> > ---
> >  package/python-markdown/Config.in | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/package/python-markdown/Config.in b/package/python-markdown/Config.in
> > index 6706684142..454c2729bd 100644
> > --- a/package/python-markdown/Config.in
> > +++ b/package/python-markdown/Config.in
> > @@ -1,8 +1,8 @@
> >  config BR2_PACKAGE_PYTHON_MARKDOWN
> >         bool "python-markdown"
> > +       depends on BR2_PACKAGE_PYTHON3
> >         # runtime dependency on Python's xml module
> > -       select BR2_PACKAGE_PYTHON_PYEXPAT if BR2_PACKAGE_PYTHON
> > -       select BR2_PACKAGE_PYTHON3_PYEXPAT if BR2_PACKAGE_PYTHON3
> > +       select BR2_PACKAGE_PYTHON3_PYEXPAT
> >         help
> >           This is a Python implementation of John Gruber's Markdown
> >
> > --
> > 2.17.0
> >
>
> Reviewed-by: Asaf Kahlon <asafka7@gmail.com>

The issue is more complicated than I thought at the beginning.

First of all, python-cheetah package that depends on python-markdown
was abandoned. The new fork is Cheetah3 [1]. What should we do? Just
replace the download location? Though the project is Py2/Py3
compatible because of python-markdown we would restrict it to Py3
only?

mongodb and gr-osmosdr both depend on python-cheetah. So they must be
touched as well. Fabrice and Gwenhael could you take care of this?

Because of this dependencies hell, a CI test for at least mongodb
would be very welcome.

[1] https://pypi.org/project/Cheetah3/

Thanks.

Yegor
Fabrice Fontaine March 11, 2020, 9:28 a.m. UTC | #3 
Hi Yegor,

Le mer. 11 mars 2020 à 10:14, Yegor Yefremov
<yegorslists@googlemail.com> a écrit :
>
> Hi all,
>
> On Tue, Mar 10, 2020 at 7:53 PM Asaf Kahlon <asafka7@gmail.com> wrote:
> >
> > On Tue, Mar 10, 2020 at 1:41 PM <yegorslists@googlemail.com> wrote:
> > >
> > > From: Yegor Yefremov <yegorslists@googlemail.com>
> > >
> > > The latest version has dropped Python 2 support.
> > >
> > > Fixes:
> > > http://autobuild.buildroot.net/results/6d1e796f6658accb3eafef265935db5e464638fe
> > >
> > > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> > > ---
> > >  package/python-markdown/Config.in | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/package/python-markdown/Config.in b/package/python-markdown/Config.in
> > > index 6706684142..454c2729bd 100644
> > > --- a/package/python-markdown/Config.in
> > > +++ b/package/python-markdown/Config.in
> > > @@ -1,8 +1,8 @@
> > >  config BR2_PACKAGE_PYTHON_MARKDOWN
> > >         bool "python-markdown"
> > > +       depends on BR2_PACKAGE_PYTHON3
> > >         # runtime dependency on Python's xml module
> > > -       select BR2_PACKAGE_PYTHON_PYEXPAT if BR2_PACKAGE_PYTHON
> > > -       select BR2_PACKAGE_PYTHON3_PYEXPAT if BR2_PACKAGE_PYTHON3
> > > +       select BR2_PACKAGE_PYTHON3_PYEXPAT
> > >         help
> > >           This is a Python implementation of John Gruber's Markdown
> > >
> > > --
> > > 2.17.0
> > >
> >
> > Reviewed-by: Asaf Kahlon <asafka7@gmail.com>
>
> The issue is more complicated than I thought at the beginning.
>
> First of all, python-cheetah package that depends on python-markdown
> was abandoned. The new fork is Cheetah3 [1]. What should we do? Just
> replace the download location? Though the project is Py2/Py3
> compatible because of python-markdown we would restrict it to Py3
> only?
I sent a python-cheetah3 package nearly one year ago and Titouan sent
a v2 6 months ago: https://patchwork.ozlabs.org/patch/1184747.
>
> mongodb and gr-osmosdr both depend on python-cheetah. So they must be
> touched as well. Fabrice and Gwenhael could you take care of this?
Again, a patch to bump mongodb and switch dependency to cheetah3 is
waiting in patchwork:
https://patchwork.ozlabs.org/project/buildroot/list/?series=138894
Thomas wanted your feedback on the third patch of this serie about
making python3-pyyaml and python3-psutil packages.
>
> Because of this dependencies hell, a CI test for at least mongodb
> would be very welcome.
>
> [1] https://pypi.org/project/Cheetah3/
>
> Thanks.
>
> Yegor
Best Regards,

Fabrice
Yegor Yefremov March 11, 2020, 10:14 a.m. UTC | #4 
On Wed, Mar 11, 2020 at 10:29 AM Fabrice Fontaine
<fontaine.fabrice@gmail.com> wrote:
>
> Hi Yegor,
>
> Le mer. 11 mars 2020 à 10:14, Yegor Yefremov
> <yegorslists@googlemail.com> a écrit :
> >
> > Hi all,
> >
> > On Tue, Mar 10, 2020 at 7:53 PM Asaf Kahlon <asafka7@gmail.com> wrote:
> > >
> > > On Tue, Mar 10, 2020 at 1:41 PM <yegorslists@googlemail.com> wrote:
> > > >
> > > > From: Yegor Yefremov <yegorslists@googlemail.com>
> > > >
> > > > The latest version has dropped Python 2 support.
> > > >
> > > > Fixes:
> > > > http://autobuild.buildroot.net/results/6d1e796f6658accb3eafef265935db5e464638fe
> > > >
> > > > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> > > > ---
> > > >  package/python-markdown/Config.in | 4 ++--
> > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/package/python-markdown/Config.in b/package/python-markdown/Config.in
> > > > index 6706684142..454c2729bd 100644
> > > > --- a/package/python-markdown/Config.in
> > > > +++ b/package/python-markdown/Config.in
> > > > @@ -1,8 +1,8 @@
> > > >  config BR2_PACKAGE_PYTHON_MARKDOWN
> > > >         bool "python-markdown"
> > > > +       depends on BR2_PACKAGE_PYTHON3
> > > >         # runtime dependency on Python's xml module
> > > > -       select BR2_PACKAGE_PYTHON_PYEXPAT if BR2_PACKAGE_PYTHON
> > > > -       select BR2_PACKAGE_PYTHON3_PYEXPAT if BR2_PACKAGE_PYTHON3
> > > > +       select BR2_PACKAGE_PYTHON3_PYEXPAT
> > > >         help
> > > >           This is a Python implementation of John Gruber's Markdown
> > > >
> > > > --
> > > > 2.17.0
> > > >
> > >
> > > Reviewed-by: Asaf Kahlon <asafka7@gmail.com>
> >
> > The issue is more complicated than I thought at the beginning.
> >
> > First of all, python-cheetah package that depends on python-markdown
> > was abandoned. The new fork is Cheetah3 [1]. What should we do? Just
> > replace the download location? Though the project is Py2/Py3
> > compatible because of python-markdown we would restrict it to Py3
> > only?
> I sent a python-cheetah3 package nearly one year ago and Titouan sent
> a v2 6 months ago: https://patchwork.ozlabs.org/patch/1184747.
> >
> > mongodb and gr-osmosdr both depend on python-cheetah. So they must be
> > touched as well. Fabrice and Gwenhael could you take care of this?
> Again, a patch to bump mongodb and switch dependency to cheetah3 is
> waiting in patchwork:
> https://patchwork.ozlabs.org/project/buildroot/list/?series=138894
> Thomas wanted your feedback on the third patch of this serie about
> making python3-pyyaml and python3-psutil packages.

I have responded to those e-mails.

Oops! Sorry for delay.

Yegor

> >
> > Because of this dependencies hell, a CI test for at least mongodb
> > would be very welcome.
> >
> > [1] https://pypi.org/project/Cheetah3/
> >
> > Thanks.
> >
> > Yegor
> Best Regards,
>
> Fabrice
Thomas Petazzoni March 15, 2020, 3:33 p.m. UTC | #5 
On Tue, 10 Mar 2020 12:41:01 +0100
yegorslists@googlemail.com wrote:

> From: Yegor Yefremov <yegorslists@googlemail.com>
> 
> The latest version has dropped Python 2 support.
> 
> Fixes:
> http://autobuild.buildroot.net/results/6d1e796f6658accb3eafef265935db5e464638fe
> 
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>

So, should this patch be marked as Rejected ?

Thanks,

Thomas
Yegor Yefremov March 15, 2020, 4:23 p.m. UTC | #6 
Hi Thomas,

On Sun, Mar 15, 2020 at 4:33 PM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> On Tue, 10 Mar 2020 12:41:01 +0100
> yegorslists@googlemail.com wrote:
>
> > From: Yegor Yefremov <yegorslists@googlemail.com>
> >
> > The latest version has dropped Python 2 support.
> >
> > Fixes:
> > http://autobuild.buildroot.net/results/6d1e796f6658accb3eafef265935db5e464638fe
> >
> > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
>
> So, should this patch be marked as Rejected ?

Basically, the patch is eligible as is. But it depends on the above
mentioned patch series that also touches python-cheetah. As soon as it
is reworked and merged, python-markdown is only an optional dependency
of the python-cheetah package and can be applied.

Yegor
Gwenhael Goavec-Merou March 25, 2020, 3:53 p.m. UTC | #7 
Hi,
On Tue, 10 Mar 2020 12:41:01 +0100
yegorslists@googlemail.com wrote:

> From: Yegor Yefremov <yegorslists@googlemail.com>
> 
> The latest version has dropped Python 2 support.
> 
> Fixes:
> http://autobuild.buildroot.net/results/6d1e796f6658accb3eafef265935db5e464638fe
> 
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
>  package/python-markdown/Config.in | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/python-markdown/Config.in
> b/package/python-markdown/Config.in index 6706684142..454c2729bd 100644
> --- a/package/python-markdown/Config.in
> +++ b/package/python-markdown/Config.in
> @@ -1,8 +1,8 @@
>  config BR2_PACKAGE_PYTHON_MARKDOWN
>  	bool "python-markdown"
> +	depends on BR2_PACKAGE_PYTHON3
>  	# runtime dependency on Python's xml module
> -	select BR2_PACKAGE_PYTHON_PYEXPAT if BR2_PACKAGE_PYTHON
> -	select BR2_PACKAGE_PYTHON3_PYEXPAT if BR2_PACKAGE_PYTHON3
> +	select BR2_PACKAGE_PYTHON3_PYEXPAT
>  	help
>  	  This is a Python implementation of John Gruber's Markdown
>  
> -- 
> 2.17.0
> 

Tested-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>

Gwen
Yegor Yefremov March 28, 2020, 6:10 a.m. UTC | #8 
Hi Thomas,

On Wed, Mar 25, 2020 at 4:54 PM Gwenhael Goavec-Merou
<gwenj@trabucayre.com> wrote:
>
> Hi,
> On Tue, 10 Mar 2020 12:41:01 +0100
> yegorslists@googlemail.com wrote:
>
> > From: Yegor Yefremov <yegorslists@googlemail.com>
> >
> > The latest version has dropped Python 2 support.
> >
> > Fixes:
> > http://autobuild.buildroot.net/results/6d1e796f6658accb3eafef265935db5e464638fe
> >
> > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> > ---
> >  package/python-markdown/Config.in | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/package/python-markdown/Config.in
> > b/package/python-markdown/Config.in index 6706684142..454c2729bd 100644
> > --- a/package/python-markdown/Config.in
> > +++ b/package/python-markdown/Config.in
> > @@ -1,8 +1,8 @@
> >  config BR2_PACKAGE_PYTHON_MARKDOWN
> >       bool "python-markdown"
> > +     depends on BR2_PACKAGE_PYTHON3
> >       # runtime dependency on Python's xml module
> > -     select BR2_PACKAGE_PYTHON_PYEXPAT if BR2_PACKAGE_PYTHON
> > -     select BR2_PACKAGE_PYTHON3_PYEXPAT if BR2_PACKAGE_PYTHON3
> > +     select BR2_PACKAGE_PYTHON3_PYEXPAT
> >       help
> >         This is a Python implementation of John Gruber's Markdown
> >
> > --
> > 2.17.0
> >
>
> Tested-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>

It is now safe to merge this patch as python-cheetah doesn't depend on
it anymore and also supports both Py2 and Py3.

Yegor
Thomas Petazzoni April 21, 2020, 9:17 p.m. UTC | #9 
On Tue, 10 Mar 2020 12:41:01 +0100
yegorslists@googlemail.com wrote:

> From: Yegor Yefremov <yegorslists@googlemail.com>
> 
> The latest version has dropped Python 2 support.

"The latest version" is very vague. Read this statement in 6 months,
and it no longer makes sense. I've extended the commit log quite a bit:

  https://git.buildroot.org/buildroot/commit/?id=1e5723ee589e8d205883c15ca863c01f94b8854f

and applied to master. Thanks!

Thomas
diff mbox series

Patch

diff --git a/package/python-markdown/Config.in b/package/python-markdown/Config.in
index 6706684142..454c2729bd 100644
--- a/package/python-markdown/Config.in
+++ b/package/python-markdown/Config.in
@@ -1,8 +1,8 @@ 
 config BR2_PACKAGE_PYTHON_MARKDOWN
 	bool "python-markdown"
+	depends on BR2_PACKAGE_PYTHON3
 	# runtime dependency on Python's xml module
-	select BR2_PACKAGE_PYTHON_PYEXPAT if BR2_PACKAGE_PYTHON
-	select BR2_PACKAGE_PYTHON3_PYEXPAT if BR2_PACKAGE_PYTHON3
+	select BR2_PACKAGE_PYTHON3_PYEXPAT
 	help
 	  This is a Python implementation of John Gruber's Markdown