[1/1] package/connman: add missing libmnl dependency for nftables
diff mbox series

Message ID 20200308205301.62180-1-james.hilliard1@gmail.com
State Accepted
Headers show
Series
  • [1/1] package/connman: add missing libmnl dependency for nftables
Related show

Commit Message

James Hilliard March 8, 2020, 8:53 p.m. UTC
Building with nftables support requires libmnl.

Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
 package/connman/Config.in  | 1 +
 package/connman/connman.mk | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

Comments

Petr Vorel March 8, 2020, 9:44 p.m. UTC | #1
Hi James,

> Building with nftables support requires libmnl.
Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
Thanks for your fix!

Kind regards,
Petr
Yann E. MORIN March 26, 2020, 7:03 p.m. UTC | #2
James, All,

On 2020-03-08 14:53 -0600, James Hilliard spake thusly:
> Building with nftables support requires libmnl.
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

Applied to master, after adding references to a few autobuild failures.
Thanks!

Regards,
Yann E. MORIN.

> ---
>  package/connman/Config.in  | 1 +
>  package/connman/connman.mk | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/connman/Config.in b/package/connman/Config.in
> index ac012dda54..48a2ee421c 100644
> --- a/package/connman/Config.in
> +++ b/package/connman/Config.in
> @@ -33,6 +33,7 @@ config BR2_PACKAGE_CONNMAN_NFTABLES
>  	bool "nftables"
>  	depends on BR2_USE_WCHAR
>  	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_12
> +	select BR2_PACKAGE_LIBMNL
>  	select BR2_PACKAGE_NFTABLES
>  	help
>  	  Use nftables as firewall.
> diff --git a/package/connman/connman.mk b/package/connman/connman.mk
> index 701be8b59d..1ebfe9cf14 100644
> --- a/package/connman/connman.mk
> +++ b/package/connman/connman.mk
> @@ -41,7 +41,7 @@ CONNMAN_CONF_OPTS += --with-firewall=iptables
>  CONNMAN_DEPENDENCIES += iptables
>  else ifeq ($(BR2_PACKAGE_CONNMAN_NFTABLES),y)
>  CONNMAN_CONF_OPTS += --with-firewall=nftables
> -CONNMAN_DEPENDENCIES += nftables
> +CONNMAN_DEPENDENCIES += libmnl nftables
>  endif
>  
>  ifeq ($(BR2_PACKAGE_CONNMAN_LOOPBACK),y)
> -- 
> 2.20.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

Patch
diff mbox series

diff --git a/package/connman/Config.in b/package/connman/Config.in
index ac012dda54..48a2ee421c 100644
--- a/package/connman/Config.in
+++ b/package/connman/Config.in
@@ -33,6 +33,7 @@  config BR2_PACKAGE_CONNMAN_NFTABLES
 	bool "nftables"
 	depends on BR2_USE_WCHAR
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_12
+	select BR2_PACKAGE_LIBMNL
 	select BR2_PACKAGE_NFTABLES
 	help
 	  Use nftables as firewall.
diff --git a/package/connman/connman.mk b/package/connman/connman.mk
index 701be8b59d..1ebfe9cf14 100644
--- a/package/connman/connman.mk
+++ b/package/connman/connman.mk
@@ -41,7 +41,7 @@  CONNMAN_CONF_OPTS += --with-firewall=iptables
 CONNMAN_DEPENDENCIES += iptables
 else ifeq ($(BR2_PACKAGE_CONNMAN_NFTABLES),y)
 CONNMAN_CONF_OPTS += --with-firewall=nftables
-CONNMAN_DEPENDENCIES += nftables
+CONNMAN_DEPENDENCIES += libmnl nftables
 endif
 
 ifeq ($(BR2_PACKAGE_CONNMAN_LOOPBACK),y)