From patchwork Fri Nov 11 01:31:29 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: david decotigny X-Patchwork-Id: 125069 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 6E1E2B6F9D for ; Fri, 11 Nov 2011 12:54:45 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752963Ab1KKByj (ORCPT ); Thu, 10 Nov 2011 20:54:39 -0500 Received: from mail-gy0-f202.google.com ([209.85.160.202]:44915 "EHLO mail-gy0-f202.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752861Ab1KKByj (ORCPT ); Thu, 10 Nov 2011 20:54:39 -0500 X-Greylist: delayed 1035 seconds by postgrey-1.27 at vger.kernel.org; Thu, 10 Nov 2011 20:54:38 EST Received: by gye5 with SMTP id 5so290480gye.1 for ; Thu, 10 Nov 2011 17:54:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=beta; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :in-reply-to:references:organization:x-system-of-record; bh=UlDzDpAd+hb3oXTccCNwsKqfTWrx3lajVjwCmkYn13k=; b=mGOYH54Kvin/MlcMnPdicup2eGA4pAl8AfJK43VRgAWx809bGLq8r9dI7O24atNDTX vMt196pvXH4IVhr+DuNw== Received: by 10.236.185.197 with SMTP id u45mr7662659yhm.6.1320975130474; Thu, 10 Nov 2011 17:32:10 -0800 (PST) Received: by 10.236.185.197 with SMTP id u45mr7662593yhm.6.1320975130313; Thu, 10 Nov 2011 17:32:10 -0800 (PST) Received: from wpzn3.hot.corp.google.com (216-239-44-65.google.com [216.239.44.65]) by gmr-mx.google.com with ESMTPS id n75si3197338yhe.3.2011.11.10.17.32.10 (version=TLSv1/SSLv3 cipher=AES128-SHA); Thu, 10 Nov 2011 17:32:10 -0800 (PST) Received: from wpaz21.hot.corp.google.com (wpaz21.hot.corp.google.com [172.24.198.85]) by wpzn3.hot.corp.google.com (Postfix) with ESMTPS id ECE45100052; Thu, 10 Nov 2011 17:32:09 -0800 (PST) Received: from decotigny.mtv.corp.google.com (decotigny.mtv.corp.google.com [172.18.64.159]) by wpaz21.hot.corp.google.com with ESMTP id pAB1W7kA021934; Thu, 10 Nov 2011 17:32:08 -0800 Received: by decotigny.mtv.corp.google.com (Postfix, from userid 128857) id 941A62511A; Thu, 10 Nov 2011 17:32:07 -0800 (PST) From: David Decotigny To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "David S. Miller" , Ian Campbell , Eric Dumazet , Jeff Kirsher , Ben Hutchings , Jiri Pirko , Joe Perches , Szymon Janc , David Decotigny Subject: [PATCH net-next v2 04/10] forcedeth: expose module parameters in /sys/module Date: Thu, 10 Nov 2011 17:31:29 -0800 Message-Id: X-Mailer: git-send-email 1.7.3.1 In-Reply-To: References: In-Reply-To: References: Organization: Google, Inc. X-System-Of-Record: true Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In particular, debug_tx_timeout can be updated at runtime. Signed-off-by: David Decotigny --- drivers/net/ethernet/nvidia/forcedeth.c | 18 +++++++++--------- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/net/ethernet/nvidia/forcedeth.c b/drivers/net/ethernet/nvidia/forcedeth.c index a6045c5..10d1e37 100644 --- a/drivers/net/ethernet/nvidia/forcedeth.c +++ b/drivers/net/ethernet/nvidia/forcedeth.c @@ -6005,23 +6005,23 @@ static void __exit exit_nic(void) pci_unregister_driver(&driver); } -module_param(max_interrupt_work, int, 0); +module_param(max_interrupt_work, int, S_IRUGO); MODULE_PARM_DESC(max_interrupt_work, "forcedeth maximum events handled per interrupt"); -module_param(optimization_mode, int, 0); +module_param(optimization_mode, int, S_IRUGO); MODULE_PARM_DESC(optimization_mode, "In throughput mode (0), every tx & rx packet will generate an interrupt. In CPU mode (1), interrupts are controlled by a timer. In dynamic mode (2), the mode toggles between throughput and CPU mode based on network load."); -module_param(poll_interval, int, 0); +module_param(poll_interval, int, S_IRUGO); MODULE_PARM_DESC(poll_interval, "Interval determines how frequent timer interrupt is generated by [(time_in_micro_secs * 100) / (2^10)]. Min is 0 and Max is 65535."); -module_param(msi, int, 0); +module_param(msi, int, S_IRUGO); MODULE_PARM_DESC(msi, "MSI interrupts are enabled by setting to 1 and disabled by setting to 0."); -module_param(msix, int, 0); +module_param(msix, int, S_IRUGO); MODULE_PARM_DESC(msix, "MSIX interrupts are enabled by setting to 1 and disabled by setting to 0."); -module_param(dma_64bit, int, 0); +module_param(dma_64bit, int, S_IRUGO); MODULE_PARM_DESC(dma_64bit, "High DMA is enabled by setting to 1 and disabled by setting to 0."); -module_param(phy_cross, int, 0); +module_param(phy_cross, int, S_IRUGO); MODULE_PARM_DESC(phy_cross, "Phy crossover detection for Realtek 8201 phy is enabled by setting to 1 and disabled by setting to 0."); -module_param(phy_power_down, int, 0); +module_param(phy_power_down, int, S_IRUGO); MODULE_PARM_DESC(phy_power_down, "Power down phy and disable link when interface is down (1), or leave phy powered up (0)."); -module_param(debug_tx_timeout, bool, 0); +module_param(debug_tx_timeout, bool, S_IRUGO|S_IWUSR); MODULE_PARM_DESC(debug_tx_timeout, "Dump tx related registers and ring when tx_timeout happens");