From patchwork Thu Nov 10 16:28:59 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: ata: Don't use NO_IRQ in pata_of_platform driver Date: Thu, 10 Nov 2011 06:28:59 -0000 From: Anton Vorontsov X-Patchwork-Id: 124959 Message-Id: <20111110162859.GA7088@oksana.dev.rtsoft.ru> To: Alan Cox Cc: Ingo Molnar , Jeff Garzik , Grant Likely , Randy Dunlap , Stephen Rothwell , linux-next@vger.kernel.org, LKML , linux-ide@vger.kernel.org, Linus Torvalds , Andrew Morton , devicetree-discuss@lists.ozlabs.org Drivers should not use NO_IRQ; moreover, some architectures don't have it nowadays. '0' is the 'no irq' case. Signed-off-by: Anton Vorontsov Acked-by: Alan Cox --- On Thu, Nov 10, 2011 at 03:38:16PM +0000, Alan Cox wrote: > On Thu, 10 Nov 2011 19:26:06 +0400 > Anton Vorontsov wrote: > > > Drivers should not use NO_IRQ; moreover, some architectures don't > > have it nowadays. '0' is the 'no irq' case. > > > > Signed-off-by: Anton Vorontsov > > Acked-by: Alan Cox In case if we don't want a "band-aid fix" for 3.2, here is the patch that just does the proper fix (w/ a risk to break minor architectures). drivers/ata/pata_of_platform.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/ata/pata_of_platform.c b/drivers/ata/pata_of_platform.c index a72ab0d..2a472c5 100644 --- a/drivers/ata/pata_of_platform.c +++ b/drivers/ata/pata_of_platform.c @@ -52,7 +52,7 @@ static int __devinit pata_of_platform_probe(struct platform_device *ofdev) } ret = of_irq_to_resource(dn, 0, &irq_res); - if (ret == NO_IRQ) + if (!ret) irq_res.start = irq_res.end = 0; else irq_res.flags = 0;