diff mbox series

[ovs-dev,V3,1/9] acinclude: Enable Linux kernel 5.5

Message ID 1583363060-13928-2-git-send-email-gvrose8192@gmail.com
State Superseded
Headers show
Series Add Linux kernel datapath support up to 5.5 | expand

Commit Message

Gregory Rose March 4, 2020, 11:04 p.m. UTC
Signed-off-by: Greg Rose <gvrose8192@gmail.com>
---
 acinclude.m4 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Yi-Hung Wei March 6, 2020, 6:26 p.m. UTC | #1
On Wed, Mar 4, 2020 at 3:04 PM Greg Rose <gvrose8192@gmail.com> wrote:
>
> Signed-off-by: Greg Rose <gvrose8192@gmail.com>
> ---
>  acinclude.m4 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/acinclude.m4 b/acinclude.m4
> index 1212a46..db64267 100644
> --- a/acinclude.m4
> +++ b/acinclude.m4
> @@ -151,7 +151,7 @@ AC_DEFUN([OVS_CHECK_LINUX], [
>      AC_MSG_RESULT([$kversion])
>
>      if test "$version" -ge 5; then
> -       if test "$version" = 5 && test "$patchlevel" -le 0; then
> +       if test "$version" = 5 && test "$patchlevel" -le 5; then
>            : # Linux 5.x
>         else
>            AC_ERROR([Linux kernel in $KBUILD is version $kversion, but version newer than 5.0.x is not supported (please refer to the FAQ for advice)])

Opps, I just found that we should update the version number in the
AC_ERROR message as well. Somehow I did not find it in the previous
review.

With the version number update.

Acked-by: Yi-Hung Wei <yihung.wei@gmail.com>


-Yi-Hung
Gregory Rose March 6, 2020, 6:28 p.m. UTC | #2
On 3/6/2020 10:26 AM, Yi-Hung Wei wrote:
> On Wed, Mar 4, 2020 at 3:04 PM Greg Rose <gvrose8192@gmail.com> wrote:
>> Signed-off-by: Greg Rose <gvrose8192@gmail.com>
>> ---
>>   acinclude.m4 | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/acinclude.m4 b/acinclude.m4
>> index 1212a46..db64267 100644
>> --- a/acinclude.m4
>> +++ b/acinclude.m4
>> @@ -151,7 +151,7 @@ AC_DEFUN([OVS_CHECK_LINUX], [
>>       AC_MSG_RESULT([$kversion])
>>
>>       if test "$version" -ge 5; then
>> -       if test "$version" = 5 && test "$patchlevel" -le 0; then
>> +       if test "$version" = 5 && test "$patchlevel" -le 5; then
>>             : # Linux 5.x
>>          else
>>             AC_ERROR([Linux kernel in $KBUILD is version $kversion, but version newer than 5.0.x is not supported (please refer to the FAQ for advice)])
> Opps, I just found that we should update the version number in the
> AC_ERROR message as well. Somehow I did not find it in the previous
> review.

Doh!

I'll send an updated patch.

Thanks,

- Greg

>
> With the version number update.
>
> Acked-by: Yi-Hung Wei <yihung.wei@gmail.com>
>
>
> -Yi-Hung
Gregory Rose March 6, 2020, 9:12 p.m. UTC | #3
On 3/6/2020 10:26 AM, Yi-Hung Wei wrote:
> On Wed, Mar 4, 2020 at 3:04 PM Greg Rose <gvrose8192@gmail.com> wrote:
>> Signed-off-by: Greg Rose <gvrose8192@gmail.com>
>> ---
>>   acinclude.m4 | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/acinclude.m4 b/acinclude.m4
>> index 1212a46..db64267 100644
>> --- a/acinclude.m4
>> +++ b/acinclude.m4
>> @@ -151,7 +151,7 @@ AC_DEFUN([OVS_CHECK_LINUX], [
>>       AC_MSG_RESULT([$kversion])
>>
>>       if test "$version" -ge 5; then
>> -       if test "$version" = 5 && test "$patchlevel" -le 0; then
>> +       if test "$version" = 5 && test "$patchlevel" -le 5; then
>>             : # Linux 5.x
>>          else
>>             AC_ERROR([Linux kernel in $KBUILD is version $kversion, but version newer than 5.0.x is not supported (please refer to the FAQ for advice)])

Maintainers,

if you can fix this up on commit that will be great or if you
prefer I resend the entire patch series I can do that.

Thanks,

- Greg


> Opps, I just found that we should update the version number in the
> AC_ERROR message as well. Somehow I did not find it in the previous
> review.
>
> With the version number update.
>
> Acked-by: Yi-Hung Wei <yihung.wei@gmail.com>
>
>
> -Yi-Hung
diff mbox series

Patch

diff --git a/acinclude.m4 b/acinclude.m4
index 1212a46..db64267 100644
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -151,7 +151,7 @@  AC_DEFUN([OVS_CHECK_LINUX], [
     AC_MSG_RESULT([$kversion])
 
     if test "$version" -ge 5; then
-       if test "$version" = 5 && test "$patchlevel" -le 0; then
+       if test "$version" = 5 && test "$patchlevel" -le 5; then
           : # Linux 5.x
        else
           AC_ERROR([Linux kernel in $KBUILD is version $kversion, but version newer than 5.0.x is not supported (please refer to the FAQ for advice)])