From patchwork Thu Nov 10 15:26:06 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anton Vorontsov X-Patchwork-Id: 124907 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id BA897100882 for ; Fri, 11 Nov 2011 02:26:12 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934960Ab1KJP0L (ORCPT ); Thu, 10 Nov 2011 10:26:11 -0500 Received: from mail-ww0-f44.google.com ([74.125.82.44]:61738 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933924Ab1KJP0J (ORCPT ); Thu, 10 Nov 2011 10:26:09 -0500 Received: by mail-ww0-f44.google.com with SMTP id 12so2524243wwh.1 for ; Thu, 10 Nov 2011 07:26:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=AFoCY3BQr0npfxkwm54EYp36M+nEuofYWXjSl0yrgvU=; b=ju5wOGVt/Z2wZpIAfoFdKCvOaMG+MrltVBtDLshtKOK1k0BG/QOHN8lZtYbWdStqKu qZosxEXIfLmrWEnVEbsKk4BpdL2wb2qxIn0y4M56ZAWD59hiAIh3TU6yK6LuXb5U4GV+ DDtgV/iROfabDyMpixxCmWv6xhrdxIQ8J6NP4= Received: by 10.180.90.19 with SMTP id bs19mr9296652wib.7.1320938768748; Thu, 10 Nov 2011 07:26:08 -0800 (PST) Received: from localhost (mail.dev.rtsoft.ru. [213.79.90.226]) by mx.google.com with ESMTPS id et20sm9909067wbb.15.2011.11.10.07.26.07 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 10 Nov 2011 07:26:08 -0800 (PST) Date: Thu, 10 Nov 2011 19:26:06 +0400 From: Anton Vorontsov To: Ingo Molnar , Jeff Garzik , Grant Likely Cc: Randy Dunlap , Stephen Rothwell , linux-next@vger.kernel.org, LKML , linux-ide@vger.kernel.org, Linus Torvalds , Andrew Morton , devicetree-discuss@lists.ozlabs.org, Alan Cox Subject: [PATCH 2/2] ata: Don't use NO_IRQ in pata_of_platform driver Message-ID: <20111110152606.GB3207@oksana.dev.rtsoft.ru> References: <20111110151852.GA7465@oksana.dev.rtsoft.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20111110151852.GA7465@oksana.dev.rtsoft.ru> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Drivers should not use NO_IRQ; moreover, some architectures don't have it nowadays. '0' is the 'no irq' case. Signed-off-by: Anton Vorontsov Acked-by: Alan Cox --- drivers/ata/pata_of_platform.c | 7 +------ 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/drivers/ata/pata_of_platform.c b/drivers/ata/pata_of_platform.c index f99e17b..2a472c5 100644 --- a/drivers/ata/pata_of_platform.c +++ b/drivers/ata/pata_of_platform.c @@ -16,11 +16,6 @@ #include #include -/* For archs that don't support NO_IRQ (such as x86), provide a dummy value */ -#ifndef NO_IRQ -#define NO_IRQ 0 -#endif - static int __devinit pata_of_platform_probe(struct platform_device *ofdev) { int ret; @@ -57,7 +52,7 @@ static int __devinit pata_of_platform_probe(struct platform_device *ofdev) } ret = of_irq_to_resource(dn, 0, &irq_res); - if (ret == NO_IRQ) + if (!ret) irq_res.start = irq_res.end = 0; else irq_res.flags = 0;