Patchwork [v2] ARM: mx28evk: Simplify GPIO requests for mx28evk_fec_reset

login
register
mail settings
Submitter Fabio Estevam
Date Nov. 9, 2011, 8:36 p.m.
Message ID <1320870998-6200-1-git-send-email-festevam@gmail.com>
Download mbox | patch
Permalink /patch/124696/
State New
Headers show

Comments

Fabio Estevam - Nov. 9, 2011, 8:36 p.m.
From: Fabio Estevam <fabio.estevam@freescale.com>

Simplify GPIO requests inside mx28evk_fec_reset by using gpio_request_array.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Changes since v1:

- Make mx28evk_fec_gpios const
 arch/arm/mach-mxs/mach-mx28evk.c |   29 ++++++++---------------------
 1 files changed, 8 insertions(+), 21 deletions(-)
Wolfram Sang - Nov. 9, 2011, 9:46 p.m.
On Wed, Nov 09, 2011 at 06:36:38PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Simplify GPIO requests inside mx28evk_fec_reset by using gpio_request_array.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Like it: Acked-by: Wolfram Sang <w.sang@pengutronix.de>

Thanks,

   Wolfram
Uwe Kleine-König - Nov. 10, 2011, 6:54 a.m.
On Wed, Nov 09, 2011 at 10:46:03PM +0100, Wolfram Sang wrote:
> On Wed, Nov 09, 2011 at 06:36:38PM -0200, Fabio Estevam wrote:
> > From: Fabio Estevam <fabio.estevam@freescale.com>
> > 
> > Simplify GPIO requests inside mx28evk_fec_reset by using gpio_request_array.
> > 
> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Like it: Acked-by: Wolfram Sang <w.sang@pengutronix.de>
/me to.

Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Uwe
Sascha Hauer - Nov. 10, 2011, 7:54 a.m.
On Wed, Nov 09, 2011 at 10:46:03PM +0100, Wolfram Sang wrote:
> On Wed, Nov 09, 2011 at 06:36:38PM -0200, Fabio Estevam wrote:
> > From: Fabio Estevam <fabio.estevam@freescale.com>
> > 
> > Simplify GPIO requests inside mx28evk_fec_reset by using gpio_request_array.
> > 
> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Like it: Acked-by: Wolfram Sang <w.sang@pengutronix.de>

/me not. See my comments to v1.

Sascha
Fabio Estevam - Nov. 11, 2011, 8:48 p.m.
On Thu, Nov 10, 2011 at 5:54 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> On Wed, Nov 09, 2011 at 10:46:03PM +0100, Wolfram Sang wrote:
>> On Wed, Nov 09, 2011 at 06:36:38PM -0200, Fabio Estevam wrote:
>> > From: Fabio Estevam <fabio.estevam@freescale.com>
>> >
>> > Simplify GPIO requests inside mx28evk_fec_reset by using gpio_request_array.
>> >
>> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> Like it: Acked-by: Wolfram Sang <w.sang@pengutronix.de>
>
> /me not. See my comments to v1.

Ok, I will implement your suggestion in v3.

Will wait Shawn´s patch "arm/mxs: fix mmc device adding for
mach-mx28evk" to reach rc2 first.

Regards,

Fabio Estevam

Patch

diff --git a/arch/arm/mach-mxs/mach-mx28evk.c b/arch/arm/mach-mxs/mach-mx28evk.c
index ac2316d..c565c33 100644
--- a/arch/arm/mach-mxs/mach-mx28evk.c
+++ b/arch/arm/mach-mxs/mach-mx28evk.c
@@ -219,6 +219,11 @@  static const struct gpio_led_platform_data mx28evk_led_data __initconst = {
 	.num_leds = ARRAY_SIZE(mx28evk_leds),
 };
 
+static const struct gpio mx28evk_fec_gpios[] __initconst = {
+	{ MX28EVK_FEC_PHY_POWER, GPIOF_OUT_INIT_LOW, "fec-power" },
+	{ MX28EVK_FEC_PHY_RESET, GPIOF_OUT_INIT_LOW, "fec-enable" },
+};
+
 /* fec */
 static void __init mx28evk_fec_reset(void)
 {
@@ -231,28 +236,10 @@  static void __init mx28evk_fec_reset(void)
 		clk_enable(clk);
 
 	/* Power up fec phy */
-	ret = gpio_request(MX28EVK_FEC_PHY_POWER, "fec-phy-power");
-	if (ret) {
-		pr_err("Failed to request gpio fec-phy-%s: %d\n", "power", ret);
-		return;
-	}
-
-	ret = gpio_direction_output(MX28EVK_FEC_PHY_POWER, 0);
-	if (ret) {
-		pr_err("Failed to drive gpio fec-phy-%s: %d\n", "power", ret);
-		return;
-	}
-
-	/* Reset fec phy */
-	ret = gpio_request(MX28EVK_FEC_PHY_RESET, "fec-phy-reset");
-	if (ret) {
-		pr_err("Failed to request gpio fec-phy-%s: %d\n", "reset", ret);
-		return;
-	}
-
-	gpio_direction_output(MX28EVK_FEC_PHY_RESET, 0);
+	ret = gpio_request_array(mx28evk_fec_gpios,
+				ARRAY_SIZE(mx28evk_fec_gpios));
 	if (ret) {
-		pr_err("Failed to drive gpio fec-phy-%s: %d\n", "reset", ret);
+		pr_err("Failed to request FEC gpios: %d\n", ret);
 		return;
 	}