From patchwork Wed Nov 9 20:04:54 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: hw/pl061: Remove pointless comparison of array to null Date: Wed, 09 Nov 2011 10:04:54 -0000 From: Peter Maydell X-Patchwork-Id: 124693 Message-Id: <1320869094-10215-1-git-send-email-peter.maydell@linaro.org> To: qemu-devel@nongnu.org Cc: patches@linaro.org Remove a pointless comparison of an array to null. (There is no need to check whether s->out[i] is non-null as qemu_set_irq will do that for us.) Spotted by Coverity (see bug 887883). Signed-off-by: Peter Maydell --- hw/pl061.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/pl061.c b/hw/pl061.c index d13746c..cf5adbe 100644 --- a/hw/pl061.c +++ b/hw/pl061.c @@ -103,7 +103,7 @@ static void pl061_update(pl061_state *s) s->old_data = out; for (i = 0; i < 8; i++) { mask = 1 << i; - if ((changed & mask) && s->out) { + if (changed & mask) { DPRINTF("Set output %d = %d\n", i, (out & mask) != 0); qemu_set_irq(s->out[i], (out & mask) != 0); }