Patchwork hw/lan9118.c: Add missing 'break' to fix buffer overrun

login
register
mail settings
Submitter Peter Maydell
Date Nov. 9, 2011, 6:59 p.m.
Message ID <1320865194-9779-1-git-send-email-peter.maydell@linaro.org>
Download mbox | patch
Permalink /patch/124659/
State New
Headers show

Comments

Peter Maydell - Nov. 9, 2011, 6:59 p.m.
Add a missing 'break' statement to fix a buffer overrun when
executing the EEPROM write-all command. Spotted by Coverity
(see bug 887883).

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 hw/lan9118.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Stefan Hajnoczi - Nov. 10, 2011, 11:34 a.m.
On Wed, Nov 09, 2011 at 06:59:54PM +0000, Peter Maydell wrote:
> Add a missing 'break' statement to fix a buffer overrun when
> executing the EEPROM write-all command. Spotted by Coverity
> (see bug 887883).
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  hw/lan9118.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

Thanks, applied to the trivial patches tree:
http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches

Stefan

Patch

diff --git a/hw/lan9118.c b/hw/lan9118.c
index 634b88e..f8149e6 100644
--- a/hw/lan9118.c
+++ b/hw/lan9118.c
@@ -863,6 +863,7 @@  static void lan9118_eeprom_cmd(lan9118_state *s, int cmd, int addr)
         } else {
             DPRINTF("EEPROM Write All (ignored)\n");
         }
+        break;
     case 5: /* ERASE */
         if (s->eeprom_writable) {
             s->eeprom[addr] = 0xff;