diff mbox series

[v1,1/2] dt-bindings: arm: actions: Document Caninos Loucos Labrador

Message ID 20200227201557.368533-2-matheus@castello.eng.br
State Changes Requested, archived
Headers show
Series Add Caninos Loucos Labrador SoM and Base Board Device Tree | expand

Checks

Context Check Description
robh/checkpatch success
robh/dt-meta-schema success

Commit Message

Matheus Castello Feb. 27, 2020, 8:15 p.m. UTC 
Update the documentation to add the Caninos Loucos Labrador
vendor-prefix and items that were included in the device tree files.

Signed-off-by: Matheus Castello <matheus@castello.eng.br>
---
 Documentation/devicetree/bindings/arm/actions.yaml     | 5 +++++
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 2 files changed, 7 insertions(+)

--
2.25.0

Comments

Manivannan Sadhasivam Feb. 29, 2020, 10:43 a.m. UTC | #1 
On Thu, Feb 27, 2020 at 05:15:56PM -0300, Matheus Castello wrote:
> Update the documentation to add the Caninos Loucos Labrador
> vendor-prefix and items that were included in the device tree files.
> 

These two should be splitted into separate patches.

Thanks,
Mani

> Signed-off-by: Matheus Castello <matheus@castello.eng.br>
> ---
>  Documentation/devicetree/bindings/arm/actions.yaml     | 5 +++++
>  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
>  2 files changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/actions.yaml b/Documentation/devicetree/bindings/arm/actions.yaml
> index ace3fdaa8396..1b131ceb884a 100644
> --- a/Documentation/devicetree/bindings/arm/actions.yaml
> +++ b/Documentation/devicetree/bindings/arm/actions.yaml
> @@ -24,6 +24,11 @@ properties:
>                - lemaker,guitar-bb-rev-b # LeMaker Guitar Base Board rev. B
>            - const: lemaker,guitar
>            - const: actions,s500
> +      - items:
> +          - enum:
> +              - caninos,labrador-bb # Caninos Loucos Labrador Base Board
> +          - const: caninos,labrador
> +          - const: actions,s500
> 
>        # The Actions Semi S700 is a quad-core ARM Cortex-A53 SoC.
>        - items:
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index 9e67944bec9c..3e974dd563cf 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -167,6 +167,8 @@ patternProperties:
>      description: Calxeda
>    "^capella,.*":
>      description: Capella Microsystems, Inc
> +  "^caninos,.*":
> +    description: Caninos Loucos LSI-TEC NPO
>    "^cascoda,.*":
>      description: Cascoda, Ltd.
>    "^catalyst,.*":
> --
> 2.25.0
>
Matheus Castello March 7, 2020, 12:24 a.m. UTC | #2 
Thanks Mani for your time reviewing it.

Changes since v1:
(Suggested by Manivannan Sadhasivam)
- Sort the entries alphabetically on Makefile
- Add title comment to the base board dts
- Remove the dt-bindings/leds/common.h (garbage from tests, sorry about that)
- Split the vendor-prefix and documentation in two patches

Caninos Loucos Labrador is a Brazilian project of open System on Modules and
Base Boards based on Lemaker Guitar. Is an initiative of LSI-TEC a non-profit
organization.

The Labrador CoM v2 is based on Actions Semi S500 processor with 16GB eMMC and
2GB RAM.

This series adds the initial work for device tree files and also adds the
vendor-prefix for the Caninos program. The work was based on the Andreas Färber
device trees for Lemaker Guitar, thanks Andreas.

Tested on my Caninos Labrador v2, only earlycon serial output is available for
now, using the fake clock. I have already worked on something here to add the
clocks and pinctrl nodes to owl-s500.dtsi, but I would like to first add the
initial device tree files and then work on the other patches calmly.

BR,
Matheus Castello

Matheus Castello (3):
  dt-bindings: Add vendor prefix for Caninos Loucos
  dt-bindings: arm: actions: Document Caninos Loucos Labrador
  ARM: dts: Add Caninos Loucos Labrador

 .../devicetree/bindings/arm/actions.yaml      |  5 +++
 .../devicetree/bindings/vendor-prefixes.yaml  |  2 ++
 arch/arm/boot/dts/Makefile                    |  1 +
 arch/arm/boot/dts/owl-s500-labrador-bb.dts    | 34 +++++++++++++++++++
 arch/arm/boot/dts/owl-s500-labrador-v2.dtsi   | 21 ++++++++++++
 5 files changed, 63 insertions(+)
 create mode 100644 arch/arm/boot/dts/owl-s500-labrador-bb.dts
 create mode 100644 arch/arm/boot/dts/owl-s500-labrador-v2.dtsi

--
2.25.0
Matheus Castello March 20, 2020, 3:51 a.m. UTC | #3 
Thanks Andreas and Mani for your time reviewing it.

Changes since v2:
(Suggested by Andreas Färber)
- Sort the entries alphabetically on vendor-prefixes.yaml
- Improve commit description
- Add Edgar Bernardi Righi and Igor Ruschi from Caninos team as CC

Changes since v1:
(Suggested by Manivannan Sadhasivam)
- Sort the entries alphabetically on Makefile
- Add title comment to the base board dts
- Remove the dt-bindings/leds/common.h (garbage from tests, sorry about that)
- Split the vendor-prefix and documentation in two patches

Caninos Loucos Labrador is a Brazilian project of open System on Modules and
Base Boards based on Lemaker Guitar. Is an initiative of LSI-TEC a non-profit
organization.

The Labrador CoM v2 is based on Actions Semi S500 processor with 16GB eMMC and
2GB RAM.

This series adds the initial work for device tree files and also adds the
vendor-prefix for the Caninos program. The work was based on the Andreas Färber
device trees for Lemaker Guitar, thanks Andreas.

Tested on my Caninos Labrador v2, only earlycon serial output is available for
now, using the fake clock. I have already worked on something here to add the
clocks and pinctrl nodes to owl-s500.dtsi, but I would like to first add the
initial device tree files and then work on the other patches calmly.

Stay safe,
Matheus Castello

Matheus Castello (3):
  dt-bindings: Add vendor prefix for Caninos Loucos
  dt-bindings: arm: actions: Document Caninos Loucos Labrador
  ARM: dts: Add Caninos Loucos Labrador

 .../devicetree/bindings/arm/actions.yaml      |  5 +++
 .../devicetree/bindings/vendor-prefixes.yaml  |  2 ++
 arch/arm/boot/dts/Makefile                    |  1 +
 arch/arm/boot/dts/owl-s500-labrador-bb.dts    | 34 +++++++++++++++++++
 arch/arm/boot/dts/owl-s500-labrador-v2.dtsi   | 21 ++++++++++++
 5 files changed, 63 insertions(+)
 create mode 100644 arch/arm/boot/dts/owl-s500-labrador-bb.dts
 create mode 100644 arch/arm/boot/dts/owl-s500-labrador-v2.dtsi

--
2.25.0
Manivannan Sadhasivam April 5, 2020, 6:51 a.m. UTC | #4 
On Fri, Mar 20, 2020 at 12:51:04AM -0300, Matheus Castello wrote:
> Add Device Trees for Caninos Loucos Labrador CoM and base board.
> Based on the work of Andreas Färber on Lemaker Guitar device tree.
> 
> Signed-off-by: Matheus Castello <matheus@castello.eng.br>

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Will queue the series for v5.8 once Andreas is happy with it.

Nit: Please keep linux-actions@lists.infradead.org in CC for all future
patches/replies.

Thanks,
Mani

> ---
>  arch/arm/boot/dts/Makefile                  |  1 +
>  arch/arm/boot/dts/owl-s500-labrador-bb.dts  | 34 +++++++++++++++++++++
>  arch/arm/boot/dts/owl-s500-labrador-v2.dtsi | 21 +++++++++++++
>  3 files changed, 56 insertions(+)
>  create mode 100644 arch/arm/boot/dts/owl-s500-labrador-bb.dts
>  create mode 100644 arch/arm/boot/dts/owl-s500-labrador-v2.dtsi
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index d6546d2676b9..99f633460833 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -842,6 +842,7 @@ dtb-$(CONFIG_ARCH_ORION5X) += \
>  dtb-$(CONFIG_ARCH_ACTIONS) += \
>  	owl-s500-cubieboard6.dtb \
>  	owl-s500-guitar-bb-rev-b.dtb \
> +	owl-s500-labrador-bb.dtb \
>  	owl-s500-sparky.dtb
>  dtb-$(CONFIG_ARCH_PRIMA2) += \
>  	prima2-evb.dtb
> diff --git a/arch/arm/boot/dts/owl-s500-labrador-bb.dts b/arch/arm/boot/dts/owl-s500-labrador-bb.dts
> new file mode 100644
> index 000000000000..91012b4a4c30
> --- /dev/null
> +++ b/arch/arm/boot/dts/owl-s500-labrador-bb.dts
> @@ -0,0 +1,34 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Caninos Labrador Base Board
> + *
> + * Copyright (c) 2019-2020 Matheus Castello
> + */
> +
> +/dts-v1/;
> +
> +#include "owl-s500-labrador-v2.dtsi"
> +
> +/ {
> +	compatible = "caninos,labrador-bb", "caninos,labrador", "actions,s500";
> +	model = "Caninos Labrador Base Board M v1.0";
> +
> +	aliases {
> +		serial3 = &uart3;
> +	};
> +
> +	chosen {
> +		stdout-path = "serial3:115200n8";
> +	};
> +
> +	uart3_clk: uart3-clk {
> +		compatible = "fixed-clock";
> +		clock-frequency = <921600>;
> +		#clock-cells = <0>;
> +	};
> +};
> +
> +&uart3 {
> +	status = "okay";
> +	clocks = <&uart3_clk>;
> +};
> diff --git a/arch/arm/boot/dts/owl-s500-labrador-v2.dtsi b/arch/arm/boot/dts/owl-s500-labrador-v2.dtsi
> new file mode 100644
> index 000000000000..0b54f1ef3ec0
> --- /dev/null
> +++ b/arch/arm/boot/dts/owl-s500-labrador-v2.dtsi
> @@ -0,0 +1,21 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Caninos Labrador CoM V2
> + *
> + * Copyright (c) 2019-2020 Matheus Castello
> + */
> +
> +#include "owl-s500.dtsi"
> +
> +/ {
> +	compatible = "caninos,labrador", "actions,s500";
> +
> +	memory@0 {
> +		device_type = "memory";
> +		reg = <0x0 0x80000000>;
> +	};
> +};
> +
> +&timer {
> +	clocks = <&hosc>;
> +};
> --
> 2.25.0
>
Matheus Castello April 23, 2020, 3:20 p.m. UTC | #5 
Hi Andreas,

Em 4/5/20 3:51 AM, Manivannan Sadhasivam escreveu:
> On Fri, Mar 20, 2020 at 12:51:04AM -0300, Matheus Castello wrote:
>> Add Device Trees for Caninos Loucos Labrador CoM and base board.
>> Based on the work of Andreas Färber on Lemaker Guitar device tree.
>>
>> Signed-off-by: Matheus Castello <matheus@castello.eng.br>
> 
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> 
> Will queue the series for v5.8 once Andreas is happy with it.
> 

do you have any more concerns about these patches? Let me know.

BR,
Matheus Castello

> Nit: Please keep linux-actions@lists.infradead.org in CC for all future
> patches/replies.
> 
> Thanks,
> Mani
> 
>> ---
>>   arch/arm/boot/dts/Makefile                  |  1 +
>>   arch/arm/boot/dts/owl-s500-labrador-bb.dts  | 34 +++++++++++++++++++++
>>   arch/arm/boot/dts/owl-s500-labrador-v2.dtsi | 21 +++++++++++++
>>   3 files changed, 56 insertions(+)
>>   create mode 100644 arch/arm/boot/dts/owl-s500-labrador-bb.dts
>>   create mode 100644 arch/arm/boot/dts/owl-s500-labrador-v2.dtsi
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index d6546d2676b9..99f633460833 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -842,6 +842,7 @@ dtb-$(CONFIG_ARCH_ORION5X) += \
>>   dtb-$(CONFIG_ARCH_ACTIONS) += \
>>   	owl-s500-cubieboard6.dtb \
>>   	owl-s500-guitar-bb-rev-b.dtb \
>> +	owl-s500-labrador-bb.dtb \
>>   	owl-s500-sparky.dtb
>>   dtb-$(CONFIG_ARCH_PRIMA2) += \
>>   	prima2-evb.dtb
>> diff --git a/arch/arm/boot/dts/owl-s500-labrador-bb.dts b/arch/arm/boot/dts/owl-s500-labrador-bb.dts
>> new file mode 100644
>> index 000000000000..91012b4a4c30
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/owl-s500-labrador-bb.dts
>> @@ -0,0 +1,34 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> +/*
>> + * Caninos Labrador Base Board
>> + *
>> + * Copyright (c) 2019-2020 Matheus Castello
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include "owl-s500-labrador-v2.dtsi"
>> +
>> +/ {
>> +	compatible = "caninos,labrador-bb", "caninos,labrador", "actions,s500";
>> +	model = "Caninos Labrador Base Board M v1.0";
>> +
>> +	aliases {
>> +		serial3 = &uart3;
>> +	};
>> +
>> +	chosen {
>> +		stdout-path = "serial3:115200n8";
>> +	};
>> +
>> +	uart3_clk: uart3-clk {
>> +		compatible = "fixed-clock";
>> +		clock-frequency = <921600>;
>> +		#clock-cells = <0>;
>> +	};
>> +};
>> +
>> +&uart3 {
>> +	status = "okay";
>> +	clocks = <&uart3_clk>;
>> +};
>> diff --git a/arch/arm/boot/dts/owl-s500-labrador-v2.dtsi b/arch/arm/boot/dts/owl-s500-labrador-v2.dtsi
>> new file mode 100644
>> index 000000000000..0b54f1ef3ec0
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/owl-s500-labrador-v2.dtsi
>> @@ -0,0 +1,21 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> +/*
>> + * Caninos Labrador CoM V2
>> + *
>> + * Copyright (c) 2019-2020 Matheus Castello
>> + */
>> +
>> +#include "owl-s500.dtsi"
>> +
>> +/ {
>> +	compatible = "caninos,labrador", "actions,s500";
>> +
>> +	memory@0 {
>> +		device_type = "memory";
>> +		reg = <0x0 0x80000000>;
>> +	};
>> +};
>> +
>> +&timer {
>> +	clocks = <&hosc>;
>> +};
>> --
>> 2.25.0
>>
Andreas Färber April 26, 2020, 11:58 a.m. UTC | #6 
Hi Matheus,

Am 23.04.20 um 17:20 schrieb Matheus Castello:
> Em 4/5/20 3:51 AM, Manivannan Sadhasivam escreveu:
>> On Fri, Mar 20, 2020 at 12:51:04AM -0300, Matheus Castello wrote:
>>> Add Device Trees for Caninos Loucos Labrador CoM and base board.
>>> Based on the work of Andreas Färber on Lemaker Guitar device tree.
>>>
>>> Signed-off-by: Matheus Castello <matheus@castello.eng.br>
>>
>> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>>
>> Will queue the series for v5.8 once Andreas is happy with it.
> 
> do you have any more concerns about these patches? Let me know.

I've reviewed the preceding two patches. This one here looks okay,

Reviewed-by: Andreas Färber <afaerber@suse.de>

but see 2/3 - model here does contain M and your .dtsi is named -v2 - 
what's the difference to v1? If it's big enough to warrant a separate 
.dtsi, you should consider whether a versioned compatible string may be 
needed, too (likely in addition to, not instead of a generic one). No v1 
info on the website.

Thanks,
Andreas
Matheus Castello April 26, 2020, 4:27 p.m. UTC | #7 
Hi Andreas,

thanks for the review.

Em 4/26/20 8:58 AM, Andreas Färber escreveu:
> Hi Matheus,
> 
> Am 23.04.20 um 17:20 schrieb Matheus Castello:
>> Em 4/5/20 3:51 AM, Manivannan Sadhasivam escreveu:
>>> On Fri, Mar 20, 2020 at 12:51:04AM -0300, Matheus Castello wrote:
>>>> Add Device Trees for Caninos Loucos Labrador CoM and base board.
>>>> Based on the work of Andreas Färber on Lemaker Guitar device tree.
>>>>
>>>> Signed-off-by: Matheus Castello <matheus@castello.eng.br>
>>>
>>> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>>>
>>> Will queue the series for v5.8 once Andreas is happy with it.
>>
>> do you have any more concerns about these patches? Let me know.
> 
> I've reviewed the preceding two patches. This one here looks okay,
> 
> Reviewed-by: Andreas Färber <afaerber@suse.de>
> 
> but see 2/3 - model here does contain M and your .dtsi is named -v2 - 
> what's the difference to v1? If it's big enough to warrant a separate 
> .dtsi, you should consider whether a versioned compatible string may be 
> needed, too (likely in addition to, not instead of a generic one). No v1 
> info on the website.
> 

The difference between v1 and v2 is the model and vendor of the DRAM and 
storage eMMC. But that had no impact on the software.

Checking examples on "/Documentation/devicetree/bindings/arm/" I saw 
that some add enum descriptions for both the base board and system on 
module, keeping in const only the vendor prefix of the SoC. And in the 
device tree both have the model property description. I liked this 
example, I think I will follow it in v4.

About "-bb-" in the file name and description: on PCB is written 
"Labrador Base-M v1.0a", so with that I think it is better to leave only 
base on the name.

I will send the v4, thank you very much for the review.

BR,
Matheus Castello

> Thanks,
> Andreas
>
Matheus Castello April 26, 2020, 4:58 p.m. UTC | #8 
Thanks Andreas, Mani and Rob for your time reviewing it.

Changes since v3:
(Suggested by Andreas Färber)
- Fix sort on actions.yaml
- Change the file owl-s500-labrador-bb.dts to owl-s500-labrador-base-m.dts
- Add description for both the SoM and Base Board
- Add Model description for both the SoM and Base Board

Changes since v2:
(Suggested by Andreas Färber)
- Sort the entries alphabetically on vendor-prefixes.yaml
- Improve commit description
- Add Edgar Bernardi Righi and Igor Ruschi from Caninos team as CC

Caninos Loucos Labrador is a Brazilian project of open System on Modules and
Base Boards based on Lemaker Guitar. Is an initiative of LSI-TEC a non-profit
organization.

The Labrador CoM v2 is based on Actions Semi S500 processor with 16GB eMMC and
2GB RAM.

This series adds the initial work for device tree files and also adds the
vendor-prefix for the Caninos program. The work was based on the Andreas Färber
device trees for Lemaker Guitar, thanks Andreas.

Tested on my Caninos Labrador v2, only earlycon serial output is available for
now, using the fake clock. I have already worked on something here to add the
clocks and pinctrl nodes to owl-s500.dtsi, but I would like to first add the
initial device tree files and then work on the other patches calmly.

Stay safe,
Matheus Castello

Matheus Castello (3):
  dt-bindings: Add vendor prefix for Caninos Loucos
  dt-bindings: arm: actions: Document Caninos Loucos Labrador
  ARM: dts: Add Caninos Loucos Labrador

 .../devicetree/bindings/arm/actions.yaml      | 11 ++++--
 .../devicetree/bindings/vendor-prefixes.yaml  |  2 ++
 arch/arm/boot/dts/Makefile                    |  1 +
 .../arm/boot/dts/owl-s500-labrador-base-m.dts | 34 +++++++++++++++++++
 arch/arm/boot/dts/owl-s500-labrador-v2.dtsi   | 22 ++++++++++++
 5 files changed, 67 insertions(+), 3 deletions(-)
 create mode 100644 arch/arm/boot/dts/owl-s500-labrador-base-m.dts
 create mode 100644 arch/arm/boot/dts/owl-s500-labrador-v2.dtsi

--
2.25.0
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/actions.yaml b/Documentation/devicetree/bindings/arm/actions.yaml
index ace3fdaa8396..1b131ceb884a 100644
--- a/Documentation/devicetree/bindings/arm/actions.yaml
+++ b/Documentation/devicetree/bindings/arm/actions.yaml
@@ -24,6 +24,11 @@  properties:
               - lemaker,guitar-bb-rev-b # LeMaker Guitar Base Board rev. B
           - const: lemaker,guitar
           - const: actions,s500
+      - items:
+          - enum:
+              - caninos,labrador-bb # Caninos Loucos Labrador Base Board
+          - const: caninos,labrador
+          - const: actions,s500

       # The Actions Semi S700 is a quad-core ARM Cortex-A53 SoC.
       - items:
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 9e67944bec9c..3e974dd563cf 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -167,6 +167,8 @@  patternProperties:
     description: Calxeda
   "^capella,.*":
     description: Capella Microsystems, Inc
+  "^caninos,.*":
+    description: Caninos Loucos LSI-TEC NPO
   "^cascoda,.*":
     description: Cascoda, Ltd.
   "^catalyst,.*":