external/mambo: rename env var PMEM_MODES to PMEM_MODE
diff mbox series

Message ID 5ea1ddc9e6f6cad1d249919ca9e8d5ad@linux.vnet.ibm.com
State Accepted
Headers show
Series
  • external/mambo: rename env var PMEM_MODES to PMEM_MODE
Related show

Checks

Context Check Description
snowpatch_ozlabs/apply_patch fail Failed to apply to any branch

Commit Message

acsawdey Feb. 27, 2020, 4:50 p.m. UTC
This patch just renames the env var to be non-plural to match PMEM_DISK.

A related patch going in to mambo will make the actual mode used in
mambo be called "private" instead of "cow" to reflect the fact that
you're getting a private copy of the image file and that any data
written to it will be lost when mambo exits. Unlike the old bogusdisk
driver, there is no separate .cow file where the writes go.

Thanks,
     Aaron

Signed-off-by: Aaron Sawdey <acsawdey at linux.ibm.com>

Comments

Michael Neuling Feb. 28, 2020, 12:03 a.m. UTC | #1
On Thu, 2020-02-27 at 10:50 -0600, acsawdey wrote:
> This patch just renames the env var to be non-plural to match PMEM_DISK.
> 
> A related patch going in to mambo will make the actual mode used in
> mambo be called "private" instead of "cow" to reflect the fact that
> you're getting a private copy of the image file and that any data
> written to it will be lost when mambo exits. Unlike the old bogusdisk
> driver, there is no separate .cow file where the writes go.
> 
> Thanks,
>      Aaron
> 
> Signed-off-by: Aaron Sawdey <acsawdey at linux.ibm.com>

Thanks

Acked-by: Michael Neuling <mikey@neuling.org>

> diff --git a/external/mambo/skiboot.tcl b/external/mambo/skiboot.tcl
> index 07c38ab2..15d00a47 100644
> --- a/external/mambo/skiboot.tcl
> +++ b/external/mambo/skiboot.tcl
> @@ -301,8 +301,8 @@ if { [info exists env(PMEM_VOLATILE)] } {
>       set pmem_sizes [split $env(PMEM_VOLATILE) ","]
>   }
>   set pmem_modes ""
> -if { [info exists env(PMEM_MODES)] } {
> -    set pmem_modes [split $env(PMEM_MODES) ","]
> +if { [info exists env(PMEM_MODE)] } {
> +    set pmem_modes [split $env(PMEM_MODE) ","]
>   }
>   set pmem_root [mysim of addchild $root_node "pmem" ""]
>   mysim of addprop $pmem_root int "#address-cells" 2
>
Oliver O'Halloran March 30, 2020, 6:25 a.m. UTC | #2
On Fri, Feb 28, 2020 at 3:50 AM acsawdey <acsawdey@linux.vnet.ibm.com> wrote:
>
> This patch just renames the env var to be non-plural to match PMEM_DISK.
>
> A related patch going in to mambo will make the actual mode used in
> mambo be called "private" instead of "cow" to reflect the fact that
> you're getting a private copy of the image file and that any data
> written to it will be lost when mambo exits. Unlike the old bogusdisk
> driver, there is no separate .cow file where the writes go.
>
> Thanks,
>      Aaron

Thanks, merged as a08549a9e7a4e3f5eb3dd5525097d472fc363888

Patch
diff mbox series

diff --git a/external/mambo/skiboot.tcl b/external/mambo/skiboot.tcl
index 07c38ab2..15d00a47 100644
--- a/external/mambo/skiboot.tcl
+++ b/external/mambo/skiboot.tcl
@@ -301,8 +301,8 @@  if { [info exists env(PMEM_VOLATILE)] } {
      set pmem_sizes [split $env(PMEM_VOLATILE) ","]
  }
  set pmem_modes ""
-if { [info exists env(PMEM_MODES)] } {
-    set pmem_modes [split $env(PMEM_MODES) ","]
+if { [info exists env(PMEM_MODE)] } {
+    set pmem_modes [split $env(PMEM_MODE) ","]
  }
  set pmem_root [mysim of addchild $root_node "pmem" ""]
  mysim of addprop $pmem_root int "#address-cells" 2