Patchwork [2/2] target-arm: remind to keep arm features in sync with linux-user/elfload.c

login
register
mail settings
Submitter Benoit Canet
Date Nov. 9, 2011, 2:41 p.m.
Message ID <1320849678-5901-3-git-send-email-benoit.canet@gmail.com>
Download mbox | patch
Permalink /patch/124562/
State New
Headers show

Comments

Benoit Canet - Nov. 9, 2011, 2:41 p.m.
Signed-off-by: Benoit Canet <benoit.canet@gmail.com>
---
 target-arm/cpu.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Peter Maydell - Nov. 9, 2011, 2:47 p.m.
2011/11/9 BenoƮt Canet <benoit.canet@gmail.com>:
> +/* remember to update linux-user/elfload.c get_elf_hwcap arm's
> + * version when adding a feature */

/* If adding a feature bit which corresponds to a Linux ELF
 * HWCAP bit, remember to update the feature-bit-to-hwcap
 * mapping in linux-user/elfload.c:get_elf_hwcap().
 */

-- PMM

Patch

diff --git a/target-arm/cpu.h b/target-arm/cpu.h
index c4d742f..e51bc8a 100644
--- a/target-arm/cpu.h
+++ b/target-arm/cpu.h
@@ -353,6 +353,8 @@  enum arm_cpu_mode {
 #define ARM_IWMMXT_wCGR2	10
 #define ARM_IWMMXT_wCGR3	11
 
+/* remember to update linux-user/elfload.c get_elf_hwcap arm's
+ * version when adding a feature */
 enum arm_features {
     ARM_FEATURE_VFP,
     ARM_FEATURE_AUXCR,  /* ARM1026 Auxiliary control register.  */