[v4,1/6] board: tbs2910: disable loadb and loads commands
diff mbox series

Message ID 20200227003702.13936-1-GNUtoo@cyberdimension.org
State Needs Review / ACK
Delegated to: Tom Rini
Headers show
Series
  • [v4,1/6] board: tbs2910: disable loadb and loads commands
Related show

Commit Message

Denis 'GNUtoo' Carikli Feb. 27, 2020, 12:36 a.m. UTC
The loadb and loads commands are not needed for booting.

There are also more reliable and faster alternatives to
loadb and loads that can be used with the current configuration.

As that the resulting image is already very close to the
size limit, removing the loadb and loads commands shouldn't
hurt.

With arm-linux-gnueabi-gcc 9.2.0-1 from the Parabola
GNU/Linux distribution we have the following size
reduction:
- text: 6733 bytes
- data: 116 bytes
- bss: 1172 bytes
- total: 8021 bytes

Acked-by: Soeren Moch <smoch@web.de>
Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
---
 configs/tbs2910_defconfig | 2 ++
 1 file changed, 2 insertions(+)

Comments

Soeren Moch March 1, 2020, 1:57 p.m. UTC | #1
On 27.02.20 01:36, Denis 'GNUtoo' Carikli wrote:
> The loadb and loads commands are not needed for booting.
>
> There are also more reliable and faster alternatives to
> loadb and loads that can be used with the current configuration.
>
> As that the resulting image is already very close to the
> size limit, removing the loadb and loads commands shouldn't
> hurt.
>
> With arm-linux-gnueabi-gcc 9.2.0-1 from the Parabola
> GNU/Linux distribution we have the following size
> reduction:
> - text: 6733 bytes
> - data: 116 bytes
> - bss: 1172 bytes
> - total: 8021 bytes
>
> Acked-by: Soeren Moch <smoch@web.de>
> Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
nit-picking:
Tags that inspired you to write a patch (like Reported-by or
Suggested-by) should be placed before your sign-off, tags you already
received for the patch (like Acked-by, Tested-by, Reviewed-by) should
come after the sign-off.

Soeren

Patch
diff mbox series

diff --git a/configs/tbs2910_defconfig b/configs/tbs2910_defconfig
index 61d4c74324..570ae850e4 100644
--- a/configs/tbs2910_defconfig
+++ b/configs/tbs2910_defconfig
@@ -26,6 +26,8 @@  CONFIG_CMD_BOOTZ=y
 CONFIG_CMD_MEMTEST=y
 CONFIG_CMD_GPIO=y
 CONFIG_CMD_I2C=y
+# CONFIG_CMD_LOADB is not set
+# CONFIG_CMD_LOADS is not set
 CONFIG_CMD_MMC=y
 CONFIG_CMD_PART=y
 CONFIG_CMD_PCI=y