From patchwork Wed Feb 26 23:22:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Romain Naour X-Patchwork-Id: 1245404 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.133; helo=hemlock.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=smile.fr Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=smile-fr.20150623.gappssmtp.com header.i=@smile-fr.20150623.gappssmtp.com header.a=rsa-sha256 header.s=20150623 header.b=AYP02WvF; dkim-atps=neutral Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48SX0B2X0Wz9sNg for ; Thu, 27 Feb 2020 10:22:50 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 3C96387E13; Wed, 26 Feb 2020 23:22:48 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9nWc89bB2IiA; Wed, 26 Feb 2020 23:22:46 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 9292587C14; Wed, 26 Feb 2020 23:22:46 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 648221BF3A3 for ; Wed, 26 Feb 2020 23:22:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 5D94B8781D for ; Wed, 26 Feb 2020 23:22:45 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8G+sILiAEKFr for ; Wed, 26 Feb 2020 23:22:43 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by whitealder.osuosl.org (Postfix) with ESMTPS id 8BAF98642E for ; Wed, 26 Feb 2020 23:22:43 +0000 (UTC) Received: by mail-wr1-f67.google.com with SMTP id p18so940998wre.9 for ; Wed, 26 Feb 2020 15:22:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=smile-fr.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=oXdF0f54n8a28o2IgprGibds5cr3MtV8DOcebOMIwIY=; b=AYP02WvFlrLTRqW5i8t+L+c5SYEhvVnYFhveNaE+CmXHNf9+rk5hCFITFqHvslLuq9 Y79im22c9EPHCphd+4EJgClZ93z4B6MksPKGejMxPfXJgwSP3wLEvdTvmXU6Au55Hd60 aUoZxw1v5T1LZU1I+DI0TfMvyE9nuBVfMNUZ76+ZmG/ytyINAmc+UmrSavNQgdwYd6S9 4CtK+V248aN4gC2wud3r+B+85T5r18FkxdmxoGd70csUKrs3NOsQ5/QK1peuvaf231ni DyYdbVA4SKF1AE7h787Sh8zyku05XX2aKXXQAhNsZhHI3k7SIiJCH1CTw5fn5aZ7ZhN7 qbiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=oXdF0f54n8a28o2IgprGibds5cr3MtV8DOcebOMIwIY=; b=B2tP2w8C2X9kuQXUUENLr7c74qSEtCL7tF5PBo3xvjViWNFViuD5E6Q8YS64zWcukC ojtir2xe4+wHNq/izgObvSjoSoH7asUnvEq11+5oa1v55msQ/sDXGrcLmKdOQN011jzp 6Ih+Pd0UCHlw1aRawLPMSYlwOEPTOQzMQSnT93NXrsn11tZc6Senm9orbK6l3q7MdPpS 9kogf0RpC0S7MGOHcj2tA5k68KdPCdpq5D1R0fegvEHBbP+ZBjK/zBw6iL2TgHj6FonX wK14aUH+SV7W9/o7SouRCUoT21N+pqVrh4LErAbXNTxMKVD0vOb4spINFeP/TLoj7kgT chEA== X-Gm-Message-State: APjAAAU+7QeBfaDbgOLFmiMVYQdblqP8ep0ryhnDHYoH/xDY21yAuI92 HW01qrlIkg/6ujEwcjNlxoS8oOVLJBb7kA== X-Google-Smtp-Source: APXvYqx9NG901JfKL1vFj/sVoPWN09Oixy+PxF4LN2sTyECi7yD0NbbAl/MKzidY6/63tJTLrVRN4w== X-Received: by 2002:adf:e943:: with SMTP id m3mr929540wrn.397.1582759361645; Wed, 26 Feb 2020 15:22:41 -0800 (PST) Received: from localhost.localdomain (2a01cb0589880c0046708304bf1f24fd.ipv6.abo.wanadoo.fr. [2a01:cb05:8988:c00:4670:8304:bf1f:24fd]) by smtp.gmail.com with ESMTPSA id q12sm5607192wrg.71.2020.02.26.15.22.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Feb 2020 15:22:40 -0800 (PST) From: Romain Naour To: buildroot@buildroot.org Date: Thu, 27 Feb 2020 00:22:37 +0100 Message-Id: <20200226232237.292826-1-romain.naour@smile.fr> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Subject: [Buildroot] [PATCH] package/qt5/qt5tools: mark qdoc option as broken X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Seiderer , Romain Naour , "Yann E . MORIN" , Julien Corjon Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" When qdoc option was added by [1] for Qt 5.12, the host-clang dependecy was added as if host-clang would provide a host native compiler. The host-clang package provide host libclang libraries needed by the cross-build process for target packages. The default target arch is set with the target architecture. It would require adding compiler flag to select the architecture to generate binaries (host or target). We can consider adding native build suport by merging the patch [3]. But it was not merged in time for Buildroot 2020.02. So in the current state, host-clang is added to qt5tools dependency without taking into account BR2_PACKAGE_LLVM_ARCH_SUPPORTS. For some architectures supported by Qt5 (i.e riscv), two llvm build options are not correcltly set: -DLLVM_TARGETS_TO_BUILD="" -DLLVM_TARGET_ARCH= So the build is broken. But even with host native support in llvm/clang host packages, the host-clang dependency itself increase a lot the build time. On a laptop with a i7-8565U CPU @ 1.80GHz, host-llvm takes 1100 sec (18,3min) to build and host-clang takes 1200 sec (20min) to build. qt5tools takes 18sec to build. Increasing the build time by 40min just for the sake of building qdoc is not great. Instead we may consider adding a new check in support/dependencies/dependencies.sh for llvm/clang installed on the build machine. This llvm/clang would be used for building qdoc (or mabe other host package). But we need to be careful for the case where host-llvm and host-clang package are already build. Then, the qt5tools package would set LLVM_INSTALL_DIR in the additional environment variables to pass to make in the build step, to provide the patch to llvm/clang headers and libraries. Something like: define QT5TOOLS_BUILD_CMDS $(TARGET_MAKE_ENV) LLVM_INSTALL_DIR="`/usr/bin/llvm-config --prefix`" \ $(MAKE) -C $(@D) sub-src-qmake_all [...] Since all possible solution are too late for 2020.02 release, disable BR2_PACKAGE_QT5TOOLS_QDOC_TOOL option. Fixes: http://autobuild.buildroot.net/results/3c0/3c0f27e953fa41bd973003a4b42b768b1636c91a/build-end.log [1] 57c1d3be4ecadd6802414a0943185c4ab6d82937 [2] https://www.linuxembedded.fr/2018/07/llvmclang-integration-into-buildroot [3] http://patchwork.ozlabs.org/patch/1204740/ Signed-off-by: Romain Naour Cc: Yann E. MORIN Cc: Julien Corjon Cc: Peter Seiderer --- package/qt5/qt5tools/Config.in | 3 +++ 1 file changed, 3 insertions(+) diff --git a/package/qt5/qt5tools/Config.in b/package/qt5/qt5tools/Config.in index 14178abc29..5ef85a88b3 100644 --- a/package/qt5/qt5tools/Config.in +++ b/package/qt5/qt5tools/Config.in @@ -19,6 +19,9 @@ config BR2_PACKAGE_QT5TOOLS_LINGUIST_TOOLS config BR2_PACKAGE_QT5TOOLS_QDOC_TOOL bool "qdoc host tool" + # Needs llvm-config and libclang installed on the build machine. + # host-llvm and host-clang packages doesn't provide a host compiler. + depends on BROKEN help This option enables the qdoc host tool.