From patchwork Wed Feb 26 17:41:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gregory Rose X-Patchwork-Id: 1245231 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.138; helo=whitealder.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=CJfpXfym; dkim-atps=neutral Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48SNQt5C2vz9sNg for ; Thu, 27 Feb 2020 04:41:58 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 2FAED87A47; Wed, 26 Feb 2020 17:41:57 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Nh6xX0unqdlO; Wed, 26 Feb 2020 17:41:51 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id C17EC8788C; Wed, 26 Feb 2020 17:41:35 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id A32CBC08A0; Wed, 26 Feb 2020 17:41:35 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 23C5AC1D87 for ; Wed, 26 Feb 2020 17:41:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 0D19183DD9 for ; Wed, 26 Feb 2020 17:41:32 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id p0J5ehMR4C2W for ; Wed, 26 Feb 2020 17:41:31 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by hemlock.osuosl.org (Postfix) with ESMTPS id AF32184D8E for ; Wed, 26 Feb 2020 17:41:31 +0000 (UTC) Received: by mail-pf1-f196.google.com with SMTP id p14so136954pfn.4 for ; Wed, 26 Feb 2020 09:41:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=TzMe3WcsApGN1GOPojD+W/bUJ1m7xh+Pwolazka1ErM=; b=CJfpXfymC7pghfnUl5JMdWFHra+eHXTK9zPO5JK0FiFYuHd5v0PhzQfv+TD6Ay7I71 ITIX7zhT6elK+5P1IQGREB5OcVzASMg/6CAvYheTJxCpFmRRr6Qri4aWjJ+cs+mNAWfl reO0UtMglOkocz1Egwk/NJRRAKLVph9ocHrFA3fRwyQ+hqxhhZwZ95h7VeEIOINuywc6 ESnF7K24w8MusOqVeCwMdEdizdm/7TdVPSrhU4Cx+FhqWKyPgGDFdxsoq7GPuslU7B7G u33D4IP4maw3AwsE3qtvQxYIwI8018HoSMyypzVwyNxKvRl9A//LId26Q9larOcDC2Nd SHEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=TzMe3WcsApGN1GOPojD+W/bUJ1m7xh+Pwolazka1ErM=; b=UBz44GsJMXTtA7wHEZ3Rge3B3qj0Lu/aWii3TFNLiSlzHG9sjuCP4HLyvS9Okit0Lr SzeV0/7OzCJgqVJnEZuanhAuOq7s9zXSO1N+Pon7h7Du8lNPC9VKKI2uGHwfkSe/ZTZX 6X1UEUwSeqxbwW1PmRmnVCYfgTTYfViFx6KypY2Zar4JTnRcRWi2u4U3N6EEg4CuXuSR WHWWEaowGBRNQ++kSaY1+cmWymwfSX8CYviw/HBu7Gxb5W+Ekzlb5zAeq+Lo2uYtmNth SNF0Y1RAoPfnihMralMhgNTtP0+izZTLXeU6JGVDDP43rrP5zphz4i+nSE/1EYXczO3k 2J0Q== X-Gm-Message-State: APjAAAUxkFiVDIeZjLaEqFMtZlcQJngDaWg/k9Y4djNU1Yrh3XTZF7oy Hj6blJLR+btN7NvgLM64dhzOnRdcDE8= X-Google-Smtp-Source: APXvYqxr0nsSn8UVDintC0P6LULV1q7Yt9tlZsFkUs2+Xwhs/+wTrczW3AidSaaA/ZyYbKXB6Gq+VQ== X-Received: by 2002:a05:6a00:45:: with SMTP id i5mr5393561pfk.252.1582738891063; Wed, 26 Feb 2020 09:41:31 -0800 (PST) Received: from gizo.domain (97-115-113-182.ptld.qwest.net. [97.115.113.182]) by smtp.gmail.com with ESMTPSA id k67sm3463133pga.91.2020.02.26.09.41.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Feb 2020 09:41:30 -0800 (PST) From: Greg Rose To: dev@openvswitch.org Date: Wed, 26 Feb 2020 09:41:16 -0800 Message-Id: <1582738882-15842-6-git-send-email-gvrose8192@gmail.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1582738882-15842-1-git-send-email-gvrose8192@gmail.com> References: <1582738882-15842-1-git-send-email-gvrose8192@gmail.com> Subject: [ovs-dev] [PATCH V2 05/11] datapath: Fix case statement fall through warning X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" Add an explicit "Falls Through" comment to fix the warning. Signed-off-by: Greg Rose --- datapath/conntrack.c | 1 + 1 file changed, 1 insertion(+) diff --git a/datapath/conntrack.c b/datapath/conntrack.c index 25da2a5..ad49daa 100644 --- a/datapath/conntrack.c +++ b/datapath/conntrack.c @@ -846,6 +846,7 @@ static int ovs_ct_nat_execute(struct sk_buff *skb, struct nf_conn *ct, } } /* Non-ICMP, fall thru to initialize if needed. */ + /* Falls through */ case IP_CT_NEW: /* Seen it before? This can happen for loopback, retrans, * or local packets.