From patchwork Wed Feb 26 17:18:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Protsenko X-Patchwork-Id: 1245220 X-Patchwork-Delegate: lokeshvutla@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=OMnGPVm8; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48SMxj4fsyz9sP7 for ; Thu, 27 Feb 2020 04:20:09 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 36A2780A03; Wed, 26 Feb 2020 18:18:29 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="OMnGPVm8"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5DAFD80D3F; Wed, 26 Feb 2020 18:18:27 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 50F2780561 for ; Wed, 26 Feb 2020 18:18:24 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=joe.skb7@gmail.com Received: by mail-lj1-x243.google.com with SMTP id n18so3981926ljo.7 for ; Wed, 26 Feb 2020 09:18:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ETx09EjgO3dFcKonzEU1ncXaYoKTivyq/7mbc1BBM+Y=; b=OMnGPVm85SR1NYnkvphcVF6mr4csvy9SbXTz4VQ9Hne3KyziA0ZX3q2duchLcmUQA3 IZ9miyRmMnAzu5P6sZF8ig5/q1mQVHxdlUy8eRddxyF2NPKyIH+fPuo/uwa4+ofhhixG s++Wt7bvn+XTYaUcpuq3cKajhoBd7iyrYsvmKjUsJyF2Ulk550XVaLQvnDXIQF9Gu3h1 C5mp8Jv8vIFgHNezl9eOnJD5mIKtMa0lP/IffQLJJs5SoUZaTPsl9XnkNJ6bboAl61I0 PrS4G/8Gs6JRVxPCHA7TzNQYY4davs/PRSjSf2M4Q0r/XRYr+2+RSON9fhcdRU3CRwQP /9lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ETx09EjgO3dFcKonzEU1ncXaYoKTivyq/7mbc1BBM+Y=; b=nYfKeMLJnUFU8md9OBXrRRTQCaaAEWsoP+X9kPKLKrRRTJ5aVwKYjKY687pmJ9nQcz tTit6Zki0AGOD3xgoFHlHLAmA6pC4hR5lt91XRkvyXsUVQS/nr5kQcNdUvB2zfUUZIfw ZaIpoKeLcc0xJD0dBWDYZq8W+PAe81YLuQUIN7p5Mxf0ahZNk9K5rz7rPPM7ISqu8HPF 3xvFsCkcwjCo5e6EvDbA//BlQo33BOQ5wszkHhFCIFOOItH/g3RWebzigL7gFVh2F+lt YQe/JKzP3LCi6ryVa5YA7qjXPDzLhD14B6gtCWv210F2TYFFy7xkVAnEYrbGhB8Xk/lx tzXQ== X-Gm-Message-State: APjAAAU/x4UWqe2ALdo85RHQAmNI/n5B3HmJ4Q2dnHl8RIx8Dm5fctNQ sqhkBkQwDdbGgNyo6VN5+F2CXohdUieOTQ== X-Google-Smtp-Source: ADFU+vvJpz/TRcync0+TdKLuFl74G99xFFItLPfq1s3a++9o0YFLTxVByEtp9rbSOIWGcEwnAL+NUw== X-Received: by 2002:a2e:1459:: with SMTP id 25mr3711305lju.189.1582737503207; Wed, 26 Feb 2020 09:18:23 -0800 (PST) Received: from localhost ([2001:67c:2e5c:2011:2e0:4cff:fe68:2882]) by smtp.gmail.com with ESMTPSA id h9sm1524453ljg.3.2020.02.26.09.18.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Feb 2020 09:18:22 -0800 (PST) From: Sam Protsenko To: u-boot@lists.denx.de, Lokesh Vutla Cc: Tom Rini , Faiz Abbas Subject: [PATCH] configs: am335x_evm: Use default log level Date: Wed, 26 Feb 2020 19:18:21 +0200 Message-Id: <20200226171821.13356-1-joe.skb7@gmail.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.2 at phobos.denx.de X-Virus-Status: Clean Commit 920e33411113 ("configs: am335x_evm: Reduce size of SPL") reduces log level from 4 (default) to 3 in order to reduce SPL size. Arguably the disadvantages of such a decision outweigh the benefits: (+) reducing SPL footprint by 1 KiB, but even with loglevel=4 we still have 2 KiB of SRAM left (-) we are missing error messages printed with pr_err() in U-Boot proper One can argue that loglevel can be increased locally for debugging purposes, which is true. But this way users are missing helpful messages when something goes wrong, which is really confusing. E.g. when trying to do "dfu tftp" without "dfu_alt_info" variable set, the only message we can see is: exit not allowed from main input shell. while whith loglevel=4 user can see what is actually missing: "dfu_alt_info" env variable not defined! Bottom line: U-Boot proper shouldn't suffer of shortcomings because of premature optimizations in SPL. Let's use default loglevel, as we are not running out of SRAM yet. When (and if) we run out of SRAM, we'll see the error message during the build, as RAM size value in SPL linker script will be violated. Then we can think about reducing loglevel only in SPL (e.g. by separating CONFIG_SPL_LOGLEVEL option from CONFIG_LOGLEVEL). Fixes: 920e33411113 ("configs: am335x_evm: Reduce size of SPL") Signed-off-by: Sam Protsenko --- configs/am335x_evm_defconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/configs/am335x_evm_defconfig b/configs/am335x_evm_defconfig index 335aa8cfa1..19fec02b5e 100644 --- a/configs/am335x_evm_defconfig +++ b/configs/am335x_evm_defconfig @@ -8,7 +8,6 @@ CONFIG_DISTRO_DEFAULTS=y CONFIG_SPL_LOAD_FIT=y CONFIG_OF_BOARD_SETUP=y CONFIG_BOOTCOMMAND="if test ${boot_fit} -eq 1; then run update_to_fit; fi; run findfdt; run init_console; run envboot; run distro_bootcmd" -CONFIG_LOGLEVEL=3 CONFIG_SYS_CONSOLE_INFO_QUIET=y CONFIG_VERSION_VARIABLE=y CONFIG_ARCH_MISC_INIT=y