diff mbox series

[2/2] tools: swupdate-hawkbitcfg: print returned IPC message

Message ID 20200226114450.42556-2-christian.storm@siemens.com
State Accepted
Headers show
Series None | expand

Commit Message

Storm, Christian Feb. 26, 2020, 11:44 a.m. UTC
In addition to printing the server response {N,}ACK,
print the returned IPC message, if any.

Signed-off-by: Christian Storm <christian.storm@siemens.com>
---
 tools/swupdate-hawkbitcfg.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

Comments

Stefano Babic Feb. 28, 2020, 10:08 a.m. UTC | #1
On 26.02.20 12:44, Christian Storm wrote:
> In addition to printing the server response {N,}ACK,
> print the returned IPC message, if any.
> 
> Signed-off-by: Christian Storm <christian.storm@siemens.com>
> ---
>  tools/swupdate-hawkbitcfg.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/swupdate-hawkbitcfg.c b/tools/swupdate-hawkbitcfg.c
> index b68d61a..d47781a 100644
> --- a/tools/swupdate-hawkbitcfg.c
> +++ b/tools/swupdate-hawkbitcfg.c
> @@ -51,9 +51,14 @@ static void send_msg(ipc_message *msg)
>  	rc = ipc_send_cmd(msg);
>  
>  	fprintf(stdout, " returned %d\n", rc);
> -	if (!rc)
> +	if (rc == 0) {
>  		fprintf(stdout, "Server returns %s\n",
>  				(msg->type == ACK) ? "ACK" : "NACK");
> +		if (msg->data.instmsg.len > 0) {
> +			fprintf(stdout, "Returned message: %s\n",
> +					msg->data.instmsg.buf);
> +		}
> +	}
>  }
>  
>  /*
> 

Applied to -master, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/tools/swupdate-hawkbitcfg.c b/tools/swupdate-hawkbitcfg.c
index b68d61a..d47781a 100644
--- a/tools/swupdate-hawkbitcfg.c
+++ b/tools/swupdate-hawkbitcfg.c
@@ -51,9 +51,14 @@  static void send_msg(ipc_message *msg)
 	rc = ipc_send_cmd(msg);
 
 	fprintf(stdout, " returned %d\n", rc);
-	if (!rc)
+	if (rc == 0) {
 		fprintf(stdout, "Server returns %s\n",
 				(msg->type == ACK) ? "ACK" : "NACK");
+		if (msg->data.instmsg.len > 0) {
+			fprintf(stdout, "Returned message: %s\n",
+					msg->data.instmsg.buf);
+		}
+	}
 }
 
 /*