| Message ID | 20200226044636.49286-1-Yanqin.Wei@arm.com |
|---|---|
| State | Accepted |
| Delegated to: | Ilya Maximets |
| Headers | show |
| Series | [ovs-dev,v2] netdev: fix partial offloading test cases failure | expand |
On 2/26/20 5:46 AM, Yanqin Wei wrote: > Some partial offloading test cases are failing inconsistently. The root > cause is that dummy netdev is assigned with "linux_tc" offloading API. > dpif-netdev - partial hw offload - dummy > dpif-netdev - partial hw offload - dummy-pmd > dpif-netdev - partial hw offload with packet modifications - dummy > dpif-netdev - partial hw offload with packet modifications - dummy-pmd > > This patch fixes this issue by changing 'options:ifindex=1' to some big > value. It is a workaround to make "linux_tc" init flow api failure. All > above cases can pass consistently after applying this patch. > > Suggested-by: Ilya Maximets <i.maximets@ovn.org> > Reviewed-by: Gavin Hu <Gavin.Hu@arm.com> > Reviewed-by: Lijian Zhang <Lijian.Zhang@arm.com> > Signed-off-by: Yanqin Wei <Yanqin.Wei@arm.com> > --- > tests/dpif-netdev.at | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Thanks! Applied to master and backported. Best regards, Ilya Maximets.
diff --git a/tests/dpif-netdev.at b/tests/dpif-netdev.at index 0aeb4e788..12e468744 100644 --- a/tests/dpif-netdev.at +++ b/tests/dpif-netdev.at @@ -371,7 +371,7 @@ m4_define([DPIF_NETDEV_FLOW_HW_OFFLOAD], [AT_SETUP([dpif-netdev - partial hw offload - $1]) OVS_VSWITCHD_START( [add-port br0 p1 -- \ - set interface p1 type=$1 ofport_request=1 options:pstream=punix:$OVS_RUNDIR/p1.sock options:ifindex=1 -- \ + set interface p1 type=$1 ofport_request=1 options:pstream=punix:$OVS_RUNDIR/p1.sock options:ifindex=1100 -- \ set bridge br0 datapath-type=dummy \ other-config:datapath-id=1234 fail-mode=secure], [], [], [m4_if([$1], [dummy-pmd], [--dummy-numa="0,0,0,0,1,1,1,1"], [])]) @@ -434,7 +434,7 @@ m4_define([DPIF_NETDEV_FLOW_HW_OFFLOAD_OFFSETS], [AT_SETUP([dpif-netdev - partial hw offload with packet modifications - $1]) OVS_VSWITCHD_START( [add-port br0 p1 -- \ - set interface p1 type=$1 ofport_request=1 options:pcap=p1.pcap options:ifindex=1 -- \ + set interface p1 type=$1 ofport_request=1 options:pcap=p1.pcap options:ifindex=1101 -- \ set bridge br0 datapath-type=dummy \ other-config:datapath-id=1234 fail-mode=secure], [], [], [m4_if([$1], [dummy-pmd], [--dummy-numa="0,0,0,0,1,1,1,1"], [])])