pull request: linux-firmware: move MT8173 VPU FW to subfolder
mbox series

Message ID 20200226033646.20949-1-gtk_ruiwang@mediatek.com
State New
Headers show
Series
  • pull request: linux-firmware: move MT8173 VPU FW to subfolder
Related show

Pull-request

https://github.com/ruiwang-mtk/linux_fw_vpu.git

Message

gtk_ruiwang Feb. 26, 2020, 3:36 a.m. UTC
Hi linux-firmware maintainers,

The following changes since commit efcfa03ae6100dfe523ebf612e03c3a90fc4c794:

  linux-firmware: Update firmware file for Intel Bluetooth AX201 (2020-02-24 07:43:42 -0500)

are available in the Git repository at:

  https://github.com/ruiwang-mtk/linux_fw_vpu.git

for you to fetch changes up to e5caf7b0f56350704836ec63845d398a9faca506:

  mediatek: move MT8173 VPU FW to subfolder (2020-02-26 11:02:00 +0800)

----------------------------------------------------------------
gtk_ruiwang (1):
      mediatek: move MT8173 VPU FW to subfolder

 vpu_d.bin => mediatek/mt8173/vpu_d.bin | Bin
 vpu_p.bin => mediatek/mt8173/vpu_p.bin | Bin
 2 files changed, 0 insertions(+), 0 deletions(-)
 rename vpu_d.bin => mediatek/mt8173/vpu_d.bin (100%)
 rename vpu_p.bin => mediatek/mt8173/vpu_p.bin (100%)

Comments

Alexandre Courbot Feb. 26, 2020, 3:41 a.m. UTC | #1
On Wed, Feb 26, 2020 at 12:38 PM <gtk_ruiwang@mediatek.com> wrote:
>
> From: gtk_ruiwang <gtk_ruiwang@mediatek.com>
>
> Currently vpu_d.bin and vpu_p.bin are at the root of
> linux-firmware git tree, it's not appropriate so we move
> them to subfolder mediatek/mt8173
>
> Release Version: 1.1.4
>
> Signed-off-by: Rui Wang <gtk_ruiwang@mediatek.com>
> ---
>  vpu_d.bin => mediatek/mt8173/vpu_d.bin | Bin
>  vpu_p.bin => mediatek/mt8173/vpu_p.bin | Bin
>  2 files changed, 0 insertions(+), 0 deletions(-)
>  rename vpu_d.bin => mediatek/mt8173/vpu_d.bin (100%)
>  rename vpu_p.bin => mediatek/mt8173/vpu_p.bin (100%)

This is nice as it removes some stuff from the root, but for
compatibility with older kernels that don't know about the new path
shouldn't we at least temporarily create a symbolic link between the
old location and the new one?
gtk_ruiwang Feb. 26, 2020, 4:19 a.m. UTC | #2
Dear Alex,

Do you mean to create two symbolic link?

lrwxrwxrwx  1 gtk_ruiwang gtk_ruiwang      25 Feb 26 11:52 vpu_d.bin ->
mediatek/mt8173/vpu_d.bin
lrwxrwxrwx  1 gtk_ruiwang gtk_ruiwang      25 Feb 26 11:52 vpu_p.bin ->
mediatek/mt8173/vpu_p.bin

we create them at the linux-firmware root folder.

Thanks
Best Regards

On Wed, 2020-02-26 at 12:41 +0900, Alexandre Courbot wrote:
> On Wed, Feb 26, 2020 at 12:38 PM <gtk_ruiwang@mediatek.com> wrote:
> >
> > From: gtk_ruiwang <gtk_ruiwang@mediatek.com>
> >
> > Currently vpu_d.bin and vpu_p.bin are at the root of
> > linux-firmware git tree, it's not appropriate so we move
> > them to subfolder mediatek/mt8173
> >
> > Release Version: 1.1.4
> >
> > Signed-off-by: Rui Wang <gtk_ruiwang@mediatek.com>
> > ---
> >  vpu_d.bin => mediatek/mt8173/vpu_d.bin | Bin
> >  vpu_p.bin => mediatek/mt8173/vpu_p.bin | Bin
> >  2 files changed, 0 insertions(+), 0 deletions(-)
> >  rename vpu_d.bin => mediatek/mt8173/vpu_d.bin (100%)
> >  rename vpu_p.bin => mediatek/mt8173/vpu_p.bin (100%)
> 
> This is nice as it removes some stuff from the root, but for
> compatibility with older kernels that don't know about the new path
> shouldn't we at least temporarily create a symbolic link between the
> old location and the new one?
Alexandre Courbot Feb. 26, 2020, 4:45 a.m. UTC | #3
On Wed, Feb 26, 2020 at 1:20 PM gtk_ruiwang <gtk_ruiwang@mediatek.com> wrote:
>
> Dear Alex,
>
> Do you mean to create two symbolic link?
>
> lrwxrwxrwx  1 gtk_ruiwang gtk_ruiwang      25 Feb 26 11:52 vpu_d.bin ->
> mediatek/mt8173/vpu_d.bin
> lrwxrwxrwx  1 gtk_ruiwang gtk_ruiwang      25 Feb 26 11:52 vpu_p.bin ->
> mediatek/mt8173/vpu_p.bin

Yes, otherwise older kernels will become unable to use the firmware. I
don't know whether these are supposed to stay forever or whether we
can remove them after a while... presumably the former.

Also the WHENCE file should probably be updated to list the new files.

>
> we create them at the linux-firmware root folder.
>
> Thanks
> Best Regards
>
> On Wed, 2020-02-26 at 12:41 +0900, Alexandre Courbot wrote:
> > On Wed, Feb 26, 2020 at 12:38 PM <gtk_ruiwang@mediatek.com> wrote:
> > >
> > > From: gtk_ruiwang <gtk_ruiwang@mediatek.com>
> > >
> > > Currently vpu_d.bin and vpu_p.bin are at the root of
> > > linux-firmware git tree, it's not appropriate so we move
> > > them to subfolder mediatek/mt8173
> > >
> > > Release Version: 1.1.4
> > >
> > > Signed-off-by: Rui Wang <gtk_ruiwang@mediatek.com>
> > > ---
> > >  vpu_d.bin => mediatek/mt8173/vpu_d.bin | Bin
> > >  vpu_p.bin => mediatek/mt8173/vpu_p.bin | Bin
> > >  2 files changed, 0 insertions(+), 0 deletions(-)
> > >  rename vpu_d.bin => mediatek/mt8173/vpu_d.bin (100%)
> > >  rename vpu_p.bin => mediatek/mt8173/vpu_p.bin (100%)
> >
> > This is nice as it removes some stuff from the root, but for
> > compatibility with older kernels that don't know about the new path
> > shouldn't we at least temporarily create a symbolic link between the
> > old location and the new one?
>
gtk_ruiwang Feb. 26, 2020, 5:31 a.m. UTC | #4
Dear Alex,

we have submit a new patch to linux-firmware, and update WHENCE file.

please kindly help to review it.

Thanks
Best Regards

On Wed, 2020-02-26 at 13:45 +0900, Alexandre Courbot wrote:
> On Wed, Feb 26, 2020 at 1:20 PM gtk_ruiwang <gtk_ruiwang@mediatek.com> wrote:
> >
> > Dear Alex,
> >
> > Do you mean to create two symbolic link?
> >
> > lrwxrwxrwx  1 gtk_ruiwang gtk_ruiwang      25 Feb 26 11:52 vpu_d.bin ->
> > mediatek/mt8173/vpu_d.bin
> > lrwxrwxrwx  1 gtk_ruiwang gtk_ruiwang      25 Feb 26 11:52 vpu_p.bin ->
> > mediatek/mt8173/vpu_p.bin
> 
> Yes, otherwise older kernels will become unable to use the firmware. I
> don't know whether these are supposed to stay forever or whether we
> can remove them after a while... presumably the former.
> 
> Also the WHENCE file should probably be updated to list the new files.
> 
> >
> > we create them at the linux-firmware root folder.
> >
> > Thanks
> > Best Regards
> >
> > On Wed, 2020-02-26 at 12:41 +0900, Alexandre Courbot wrote:
> > > On Wed, Feb 26, 2020 at 12:38 PM <gtk_ruiwang@mediatek.com> wrote:
> > > >
> > > > From: gtk_ruiwang <gtk_ruiwang@mediatek.com>
> > > >
> > > > Currently vpu_d.bin and vpu_p.bin are at the root of
> > > > linux-firmware git tree, it's not appropriate so we move
> > > > them to subfolder mediatek/mt8173
> > > >
> > > > Release Version: 1.1.4
> > > >
> > > > Signed-off-by: Rui Wang <gtk_ruiwang@mediatek.com>
> > > > ---
> > > >  vpu_d.bin => mediatek/mt8173/vpu_d.bin | Bin
> > > >  vpu_p.bin => mediatek/mt8173/vpu_p.bin | Bin
> > > >  2 files changed, 0 insertions(+), 0 deletions(-)
> > > >  rename vpu_d.bin => mediatek/mt8173/vpu_d.bin (100%)
> > > >  rename vpu_p.bin => mediatek/mt8173/vpu_p.bin (100%)
> > >
> > > This is nice as it removes some stuff from the root, but for
> > > compatibility with older kernels that don't know about the new path
> > > shouldn't we at least temporarily create a symbolic link between the
> > > old location and the new one?
> >