Message ID | 20200224205533.23798-11-philmd@redhat.com |
---|---|
State | New |
Headers | show |
Series | hw: Sanitize various MemoryRegion calls | expand |
On Mon, Feb 24, 2020 at 09:55:11PM +0100, Philippe Mathieu-Daudé wrote: > This commit was produced with the Coccinelle script > scripts/coccinelle/memory-region-housekeeping.cocci. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Acked-by: David Gibson <david@gibson.dropbear.id.au> > --- > hw/pci-host/prep.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/hw/pci-host/prep.c b/hw/pci-host/prep.c > index 1aff72bec6..1a02e9a670 100644 > --- a/hw/pci-host/prep.c > +++ b/hw/pci-host/prep.c > @@ -325,9 +325,8 @@ static void raven_realize(PCIDevice *d, Error **errp) > d->config[0x0D] = 0x10; // latency_timer > d->config[0x34] = 0x00; // capabilities_pointer > > - memory_region_init_ram_nomigrate(&s->bios, OBJECT(s), "bios", BIOS_SIZE, > - &error_fatal); > - memory_region_set_readonly(&s->bios, true); > + memory_region_init_rom_nomigrate(&s->bios, OBJECT(s), "bios", BIOS_SIZE, > + &error_fatal); > memory_region_add_subregion(get_system_memory(), (uint32_t)(-BIOS_SIZE), > &s->bios); > if (s->bios_name) {
diff --git a/hw/pci-host/prep.c b/hw/pci-host/prep.c index 1aff72bec6..1a02e9a670 100644 --- a/hw/pci-host/prep.c +++ b/hw/pci-host/prep.c @@ -325,9 +325,8 @@ static void raven_realize(PCIDevice *d, Error **errp) d->config[0x0D] = 0x10; // latency_timer d->config[0x34] = 0x00; // capabilities_pointer - memory_region_init_ram_nomigrate(&s->bios, OBJECT(s), "bios", BIOS_SIZE, - &error_fatal); - memory_region_set_readonly(&s->bios, true); + memory_region_init_rom_nomigrate(&s->bios, OBJECT(s), "bios", BIOS_SIZE, + &error_fatal); memory_region_add_subregion(get_system_memory(), (uint32_t)(-BIOS_SIZE), &s->bios); if (s->bios_name) {
This commit was produced with the Coccinelle script scripts/coccinelle/memory-region-housekeeping.cocci. Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- hw/pci-host/prep.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)