tests: Enable SUITEB192 in test example config
diff mbox series

Message ID 20200224211846.2937-1-alexander@wetzel-home.de
State Deferred
Headers show
Series
  • tests: Enable SUITEB192 in test example config
Related show

Commit Message

Alexander Wetzel Feb. 24, 2020, 9:18 p.m. UTC
Enable CONFIG_SUITEB192 in the hwsim config examples.
---

Not sure if there is a reason CONFIG_SUITEB192 is missing in the
examples... It has tests which are skipped when using the examples as
instructed.

 tests/hwsim/example-hostapd.config        | 1 +
 tests/hwsim/example-wpa_supplicant.config | 1 +
 2 files changed, 2 insertions(+)

Comments

Jouni Malinen Feb. 24, 2020, 9:59 p.m. UTC | #1
On Mon, Feb 24, 2020 at 10:18:46PM +0100, Alexander Wetzel wrote:
> Enable CONFIG_SUITEB192 in the hwsim config examples.
> ---
> 
> Not sure if there is a reason CONFIG_SUITEB192 is missing in the
> examples... It has tests which are skipped when using the examples as
> instructed.

>  tests/hwsim/example-hostapd.config        | 1 +
>  tests/hwsim/example-wpa_supplicant.config | 1 +

I have not wanted to enable this so far in those files since there used
to be significant portion of still used distributions that included too
old OpenSSL version to work with that. I guess we are getting closer to
the point of most people having moved to a something more recent, so it
might make sense to do this eventually especially now that the upstream
OpenSSL project has EOL'ed the older versions.

In general, tests/hwsim/example-*.config files are pretty conservative
on what to include by default. In practice, I'm using custom .config
files to pull in everything for my own tests and then enable things in
the default files once the particular functionality is expected to work
without issues on most used development systems (based on both likely
kernel version and user space components).

Patch
diff mbox series

diff --git a/tests/hwsim/example-hostapd.config b/tests/hwsim/example-hostapd.config
index 942134a51..33b3b54cb 100644
--- a/tests/hwsim/example-hostapd.config
+++ b/tests/hwsim/example-hostapd.config
@@ -81,6 +81,7 @@  CFLAGS += -DCONFIG_RADIUS_TEST
 CONFIG_MODULE_TESTS=y
 
 CONFIG_SUITEB=y
+CONFIG_SUITEB192=y
 
 # AddressSanitizer (ASan) can be enabled by uncommenting the following lines.
 # This can be used as a more efficient memory error detector than valgrind
diff --git a/tests/hwsim/example-wpa_supplicant.config b/tests/hwsim/example-wpa_supplicant.config
index d494caf86..3ffcdbd13 100644
--- a/tests/hwsim/example-wpa_supplicant.config
+++ b/tests/hwsim/example-wpa_supplicant.config
@@ -127,6 +127,7 @@  CONFIG_TESTING_OPTIONS=y
 CONFIG_MODULE_TESTS=y
 
 CONFIG_SUITEB=y
+CONFIG_SUITEB192=y
 
 # AddressSanitizer (ASan) can be enabled by uncommenting the following lines.
 # This can be used as a more efficient memory error detector than valgrind