package/swig: create a symlink for swig3.0
diff mbox series

Message ID 20200224101252.29177-1-yegorslists@googlemail.com
State Accepted
Headers show
Series
  • package/swig: create a symlink for swig3.0
Related show

Commit Message

Yegor Yefremov Feb. 24, 2020, 10:12 a.m. UTC
From: Yegor Yefremov <yegorslists@googlemail.com>

For now swig package creates a symlink to the latest swig version
i.e. swig4.0. If the host already has both CMake 3.10 and earlier
swig version then the earlier version (swig2.0 or swig3.0) will
be detected. This happens because CMake 3.10 doesn't know about
swig4.0 and thus searches for swig3.0 first and finds it on the
host.

With the new symlink CMake will find buildroot's swig binary.

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
 package/swig/swig.mk | 1 +
 1 file changed, 1 insertion(+)

Comments

Peter Korsgaard Feb. 27, 2020, 9:12 p.m. UTC | #1
>>>>> "yegorslists" == yegorslists  <yegorslists@googlemail.com> writes:

 > From: Yegor Yefremov <yegorslists@googlemail.com>
 > For now swig package creates a symlink to the latest swig version
 > i.e. swig4.0. If the host already has both CMake 3.10 and earlier
 > swig version then the earlier version (swig2.0 or swig3.0) will
 > be detected. This happens because CMake 3.10 doesn't know about
 > swig4.0 and thus searches for swig3.0 first and finds it on the
 > host.

 > With the new symlink CMake will find buildroot's swig binary.

 > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>

Reworded / extended the commit message a bit and committed, thanks.
Peter Korsgaard March 14, 2020, 4:48 p.m. UTC | #2
>>>>> "yegorslists" == yegorslists  <yegorslists@googlemail.com> writes:

 > From: Yegor Yefremov <yegorslists@googlemail.com>
 > For now swig package creates a symlink to the latest swig version
 > i.e. swig4.0. If the host already has both CMake 3.10 and earlier
 > swig version then the earlier version (swig2.0 or swig3.0) will
 > be detected. This happens because CMake 3.10 doesn't know about
 > swig4.0 and thus searches for swig3.0 first and finds it on the
 > host.

 > With the new symlink CMake will find buildroot's swig binary.

 > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>

Committed to 2019.11.x (2019.02.x uses swig 3.0.12), thanks.

Patch
diff mbox series

diff --git a/package/swig/swig.mk b/package/swig/swig.mk
index 3dba3425cf..5881a0e423 100644
--- a/package/swig/swig.mk
+++ b/package/swig/swig.mk
@@ -27,6 +27,7 @@  SWIG_LICENSE_FILES = LICENSE LICENSE-GPL LICENSE-UNIVERSITIES
 
 define HOST_SWIG_INSTALL_SYMLINK
 	ln -fs swig $(HOST_DIR)/bin/swig$(SWIG_VERSION_MAJOR)
+	ln -fs swig $(HOST_DIR)/bin/swig3.0
 endef
 
 HOST_SWIG_POST_INSTALL_HOOKS += HOST_SWIG_INSTALL_SYMLINK