| Message ID | 1320743385-31451-1-git-send-email-gabeblack@chromium.org |
|---|---|
| State | Accepted |
| Commit | 07e12784966c1d61b07861e6971fb8750a2ecc0c |
| Headers | show |
+fdt maintainer On Tuesday 08 November 2011 04:09:44 Gabe Black wrote: > The function fdt_getprop_u32_default doesn't modify the fdt, so it can use > a const void * for its fdt argument. > > Signed-off-by: Gabe Black <gabeblack@chromium.org> > --- > common/fdt_support.c | 4 ++-- > include/fdt_support.h | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/common/fdt_support.c b/common/fdt_support.c > index bdda64d..bd3a014 100644 > --- a/common/fdt_support.c > +++ b/common/fdt_support.c > @@ -49,8 +49,8 @@ DECLARE_GLOBAL_DATA_PTR; > * Convenience function to find a node and return it's property or a > * default value if it doesn't exist. > */ > -u32 fdt_getprop_u32_default(void *fdt, const char *path, const char *prop, > - const u32 dflt) > +u32 fdt_getprop_u32_default(const void *fdt, const char *path, > + const char *prop, const u32 dflt) > { > const u32 *val; > int off; > diff --git a/include/fdt_support.h b/include/fdt_support.h > index c7b4605..cef3c65 100644 > --- a/include/fdt_support.h > +++ b/include/fdt_support.h > @@ -28,8 +28,8 @@ > > #include <fdt.h> > > -u32 fdt_getprop_u32_default(void *fdt, const char *path, const char *prop, > - const u32 dflt); > +u32 fdt_getprop_u32_default(const void *fdt, const char *path, > + const char *prop, const u32 dflt); > int fdt_chosen(void *fdt, int force); > int fdt_initrd(void *fdt, ulong initrd_start, ulong initrd_end, int > force); void do_fixup_by_path(void *fdt, const char *path, const char > *prop,
Bump. On Tue, Nov 8, 2011 at 5:47 AM, Mike Frysinger <vapier@gentoo.org> wrote: > +fdt maintainer > > On Tuesday 08 November 2011 04:09:44 Gabe Black wrote: > > The function fdt_getprop_u32_default doesn't modify the fdt, so it can > use > > a const void * for its fdt argument. > > > > Signed-off-by: Gabe Black <gabeblack@chromium.org> > > --- > > common/fdt_support.c | 4 ++-- > > include/fdt_support.h | 4 ++-- > > 2 files changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/common/fdt_support.c b/common/fdt_support.c > > index bdda64d..bd3a014 100644 > > --- a/common/fdt_support.c > > +++ b/common/fdt_support.c > > @@ -49,8 +49,8 @@ DECLARE_GLOBAL_DATA_PTR; > > * Convenience function to find a node and return it's property or a > > * default value if it doesn't exist. > > */ > > -u32 fdt_getprop_u32_default(void *fdt, const char *path, const char > *prop, > > - const u32 dflt) > > +u32 fdt_getprop_u32_default(const void *fdt, const char *path, > > + const char *prop, const u32 dflt) > > { > > const u32 *val; > > int off; > > diff --git a/include/fdt_support.h b/include/fdt_support.h > > index c7b4605..cef3c65 100644 > > --- a/include/fdt_support.h > > +++ b/include/fdt_support.h > > @@ -28,8 +28,8 @@ > > > > #include <fdt.h> > > > > -u32 fdt_getprop_u32_default(void *fdt, const char *path, const char > *prop, > > - const u32 dflt); > > +u32 fdt_getprop_u32_default(const void *fdt, const char *path, > > + const char *prop, const u32 dflt); > > int fdt_chosen(void *fdt, int force); > > int fdt_initrd(void *fdt, ulong initrd_start, ulong initrd_end, int > > force); void do_fixup_by_path(void *fdt, const char *path, const char > > *prop, >
On 11/08/2011 04:09 AM, Gabe Black wrote: > The function fdt_getprop_u32_default doesn't modify the fdt, so it can use a > const void * for its fdt argument. > > Signed-off-by: Gabe Black<gabeblack@chromium.org> Applied and requested a bugfix pull. Thanks, gvb
diff --git a/common/fdt_support.c b/common/fdt_support.c index bdda64d..bd3a014 100644 --- a/common/fdt_support.c +++ b/common/fdt_support.c @@ -49,8 +49,8 @@ DECLARE_GLOBAL_DATA_PTR; * Convenience function to find a node and return it's property or a * default value if it doesn't exist. */ -u32 fdt_getprop_u32_default(void *fdt, const char *path, const char *prop, - const u32 dflt) +u32 fdt_getprop_u32_default(const void *fdt, const char *path, + const char *prop, const u32 dflt) { const u32 *val; int off; diff --git a/include/fdt_support.h b/include/fdt_support.h index c7b4605..cef3c65 100644 --- a/include/fdt_support.h +++ b/include/fdt_support.h @@ -28,8 +28,8 @@ #include <fdt.h> -u32 fdt_getprop_u32_default(void *fdt, const char *path, const char *prop, - const u32 dflt); +u32 fdt_getprop_u32_default(const void *fdt, const char *path, + const char *prop, const u32 dflt); int fdt_chosen(void *fdt, int force); int fdt_initrd(void *fdt, ulong initrd_start, ulong initrd_end, int force); void do_fixup_by_path(void *fdt, const char *path, const char *prop,
The function fdt_getprop_u32_default doesn't modify the fdt, so it can use a const void * for its fdt argument. Signed-off-by: Gabe Black <gabeblack@chromium.org> --- common/fdt_support.c | 4 ++-- include/fdt_support.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)