| Message ID | 20200223192942.18420-9-qais.yousef@arm.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | Convert cpu_up/down to device_online/offline | expand |
diff --git a/arch/powerpc/kexec/core_64.c b/arch/powerpc/kexec/core_64.c index 04a7cba58eff..b4184092172a 100644 --- a/arch/powerpc/kexec/core_64.c +++ b/arch/powerpc/kexec/core_64.c @@ -212,7 +212,7 @@ static void wake_offline_cpus(void) if (!cpu_online(cpu)) { printk(KERN_INFO "kexec: Waking offline cpu %d.\n", cpu); - WARN_ON(cpu_up(cpu)); + WARN_ON(add_cpu(cpu)); } } }
The core device API performs extra housekeeping bits that are missing from directly calling cpu_up/down. See commit a6717c01ddc2 ("powerpc/rtas: use device model APIs and serialization during LPM") for an example description of what might go wrong. This also prepares to make cpu_up/down a private interface for anything but the cpu subsystem. Acked-by: Michael Ellerman <mpe@ellerman.id.au> Signed-off-by: Qais Yousef <qais.yousef@arm.com> CC: Benjamin Herrenschmidt <benh@kernel.crashing.org> CC: Paul Mackerras <paulus@samba.org> CC: Michael Ellerman <mpe@ellerman.id.au> CC: Enrico Weigelt <info@metux.net> CC: Ram Pai <linuxram@us.ibm.com> CC: Nicholas Piggin <npiggin@gmail.com> CC: Thiago Jung Bauermann <bauerman@linux.ibm.com> CC: Christophe Leroy <christophe.leroy@c-s.fr> CC: Thomas Gleixner <tglx@linutronix.de> CC: linuxppc-dev@lists.ozlabs.org CC: linux-kernel@vger.kernel.org --- Michael, this now uses add_cpu() which you should be CCed on. I wasn't sure if I can keep your Ack or remove it in this case. Please let me know if you need more clarification. arch/powerpc/kexec/core_64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)