| Message ID | 20200222085030.1760640-1-stefanha@redhat.com |
|---|---|
| State | New |
| Headers | show |
Patchew URL: https://patchew.org/QEMU/20200222085030.1760640-1-stefanha@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL 00/31] Block patches Message-id: 20200222085030.1760640-1-stefanha@redhat.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20200222085030.1760640-1-stefanha@redhat.com -> patchew/20200222085030.1760640-1-stefanha@redhat.com Switched to a new branch 'test' dc382b1 fuzz: add documentation to docs/devel/ 003bbd0 fuzz: add virtio-scsi fuzz target e8802f9 fuzz: add virtio-net fuzz target 69e13ad fuzz: add i440fx fuzz targets 4083dcb fuzz: add configure flag --enable-fuzzing c3d2240 fuzz: add target/fuzz makefile rules 7c4d2fb fuzz: add support for qos-assisted fuzz targets 8518c8d fuzz: support for fork-based fuzzing. 6a286ed main: keep rcu_atfork callback enabled for qtest ed941c7 exec: keep ram block across fork when using qtest e24313f fuzz: add fuzzer skeleton 408df07 libqos: move useful qos-test funcs to qos_external d7daac7 libqos: split qos-test and libqos makefile vars 4bceb01 libqos: rename i2c_send and i2c_recv 4ea92f2 qtest: add in-process incoming command handler 0adfc33 libqtest: make bufwrite rely on the TransportOps 780da9f libqtest: add a layer of abstraction to send/recv bcc084b qtest: add qtest_server_send abstraction 266c2c5 fuzz: add FUZZ_TARGET module type 66b6939 module: check module wasn't already initialized 009494e softmmu: split off vl.c:main() into main.c 28796ad softmmu: move vl.c to softmmu/ 6b8a3f7 aio-posix: make AioHandler dispatch O(1) with epoll b839357 aio-posix: make AioHandler deletion O(1) 5c9397d qemu/queue.h: add QLIST_SAFE_REMOVE() 8cd11b4 aio-posix: don't pass ns timeout to epoll_wait() 4252dd3 aio-posix: fix use after leaving scope in aio_poll() e850ad8 util/async: make bh_aio_poll() O(1) 3ae8e2d rcu_queue: add QSLIST functions b593eb3 aio-posix: avoid reacquiring rcu_read_lock() when polling 6fbbd86 virtio: increase virtqueue size for virtio-scsi and virtio-blk === OUTPUT BEGIN === 1/31 Checking commit 6fbbd869010e (virtio: increase virtqueue size for virtio-scsi and virtio-blk) 2/31 Checking commit b593eb3a32e9 (aio-posix: avoid reacquiring rcu_read_lock() when polling) 3/31 Checking commit 3ae8e2d89202 (rcu_queue: add QSLIST functions) WARNING: Block comments use a leading /* on a separate line #29: FILE: include/qemu/queue.h:217: +} while (/*CONSTCOND*/0) WARNING: Block comments use a leading /* on a separate line #64: FILE: include/qemu/rcu_queue.h:278: +} while (/*CONSTCOND*/0) WARNING: Block comments use a leading /* on a separate line #69: FILE: include/qemu/rcu_queue.h:283: +} while (/*CONSTCOND*/0) WARNING: Block comments use a leading /* on a separate line #73: FILE: include/qemu/rcu_queue.h:287: +} while (/*CONSTCOND*/0) WARNING: Block comments use a leading /* on a separate line #86: FILE: include/qemu/rcu_queue.h:300: +} while (/*CONSTCOND*/0) ERROR: code indent should never use tabs #144: FILE: tests/test-rcu-list.c:155: +^I QSLIST_REMOVE_RCU(&Q_list_head, el, list_element, f)$ WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #156: new file mode 100644 total: 1 errors, 6 warnings, 119 lines checked Patch 3/31 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/31 Checking commit e850ad83574b (util/async: make bh_aio_poll() O(1)) 5/31 Checking commit 4252dd376d4c (aio-posix: fix use after leaving scope in aio_poll()) 6/31 Checking commit 8cd11b46c0f8 (aio-posix: don't pass ns timeout to epoll_wait()) 7/31 Checking commit 5c9397dad943 (qemu/queue.h: add QLIST_SAFE_REMOVE()) WARNING: Block comments use a leading /* on a separate line #70: FILE: include/qemu/queue.h:159: +} while (/*CONSTCOND*/0) total: 0 errors, 1 warnings, 41 lines checked Patch 7/31 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/31 Checking commit b83935774545 (aio-posix: make AioHandler deletion O(1)) 9/31 Checking commit 6b8a3f79ba86 (aio-posix: make AioHandler dispatch O(1) with epoll) 10/31 Checking commit 28796ad5d822 (softmmu: move vl.c to softmmu/) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #83: new file mode 100644 total: 0 errors, 1 warnings, 42 lines checked Patch 10/31 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/31 Checking commit 009494eddb10 (softmmu: split off vl.c:main() into main.c) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #71: new file mode 100644 WARNING: architecture specific defines should be avoided #105: FILE: softmmu/main.c:30: +#if defined(__APPLE__) || defined(main) total: 0 errors, 2 warnings, 164 lines checked Patch 11/31 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/31 Checking commit 66b69398ca5c (module: check module wasn't already initialized) 13/31 Checking commit 266c2c51ef94 (fuzz: add FUZZ_TARGET module type) 14/31 Checking commit bcc084b75586 (qtest: add qtest_server_send abstraction) WARNING: line over 80 characters #77: FILE: qtest.c:797: +void qtest_server_set_send_handler(void (*send)(void*, const char*), void *opaque) total: 0 errors, 1 warnings, 50 lines checked Patch 14/31 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/31 Checking commit 780da9f5c54b (libqtest: add a layer of abstraction to send/recv) 16/31 Checking commit 0adfc33900fe (libqtest: make bufwrite rely on the TransportOps) 17/31 Checking commit 4ea92f2da690 (qtest: add in-process incoming command handler) 18/31 Checking commit 4bceb011189a (libqos: rename i2c_send and i2c_recv) 19/31 Checking commit d7daac746814 (libqos: split qos-test and libqos makefile vars) 20/31 Checking commit 408df0768420 (libqos: move useful qos-test funcs to qos_external) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #32: new file mode 100644 total: 0 errors, 1 warnings, 357 lines checked Patch 20/31 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 21/31 Checking commit e24313ff11c7 (fuzz: add fuzzer skeleton) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 294 lines checked Patch 21/31 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 22/31 Checking commit ed941c7f4d98 (exec: keep ram block across fork when using qtest) 23/31 Checking commit 6a286ed521a5 (main: keep rcu_atfork callback enabled for qtest) 24/31 Checking commit 8518c8d513af (fuzz: support for fork-based fuzzing.) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #43: new file mode 100644 total: 0 errors, 1 warnings, 125 lines checked Patch 24/31 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 25/31 Checking commit 7c4d2fbb0984 (fuzz: add support for qos-assisted fuzz targets) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #30: new file mode 100644 WARNING: line over 80 characters #157: FILE: tests/qtest/fuzz/qos_fuzz.c:123: + /* etype set to QEDGE_CONSUMED_BY so that machine can add to the command line */ total: 0 errors, 2 warnings, 277 lines checked Patch 25/31 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 26/31 Checking commit c3d2240eaf7b (fuzz: add target/fuzz makefile rules) 27/31 Checking commit 4083dcb64bc1 (fuzz: add configure flag --enable-fuzzing) 28/31 Checking commit 69e13ad02539 (fuzz: add i440fx fuzz targets) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 total: 0 errors, 1 warnings, 202 lines checked Patch 28/31 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 29/31 Checking commit e8802f951a1c (fuzz: add virtio-net fuzz target) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #30: new file mode 100644 total: 0 errors, 1 warnings, 205 lines checked Patch 29/31 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 30/31 Checking commit 003bbd0f4e44 (fuzz: add virtio-scsi fuzz target) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #30: new file mode 100644 total: 0 errors, 1 warnings, 220 lines checked Patch 30/31 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/31 Checking commit dc382b154f25 (fuzz: add documentation to docs/devel/) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #15: new file mode 100644 total: 0 errors, 1 warnings, 116 lines checked Patch 31/31 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200222085030.1760640-1-stefanha@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On Sat, Feb 22, 2020 at 01:13:32AM -0800, no-reply@patchew.org wrote: > This series seems to have some coding style problems. See output below for > more information: The checkpatch warnings are benign: * The include/qemu/queue.h coding style warnings are because this is code imported to QEMU from elsewhere (BSD?). * The 80 character line warnings can be fixed by Alex in a follow-up patch. * MAINTAINERS changes have been made, but the check is known to report false positives (especially if a wildcard M: line is added and then new files are introduced later in the series). Stefan
On Sat, 22 Feb 2020 at 08:50, Stefan Hajnoczi <stefanha@redhat.com> wrote: > > The following changes since commit 9ac5df20f51fabcba0d902025df4bd7ea987c158: > > Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20200221-1' into staging (2020-02-21 16:18:38 +0000) > > are available in the Git repository at: > > https://github.com/stefanha/qemu.git tags/block-pull-request > > for you to fetch changes up to e5c59355ae9f724777c61c859292ec9db2c8c2ab: > > fuzz: add documentation to docs/devel/ (2020-02-22 08:26:48 +0000) > > ---------------------------------------------------------------- > Pull request > > This pull request contains a virtio-blk/scsi performance optimization, event > loop scalability improvements, and a qtest-based device fuzzing framework. I > am including the fuzzing patches because I have reviewed them and Thomas Huth > is currently away on leave. Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/5.0 for any user-visible changes. -- PMM