diff mbox series

[ovs-dev] docs: Update conntrack established state description

Message ID 1582325438-31675-1-git-send-email-yihung.wei@gmail.com
State Accepted
Commit f4f7498a9e17fd25eedcb95a127b2b1c63cda962
Headers show
Series [ovs-dev] docs: Update conntrack established state description | expand

Commit Message

Yi-Hung Wei Feb. 21, 2020, 10:50 p.m. UTC
Patch a867c010ee91 ("conntrack: Fix conntrack new state") fixes
the userspace conntrack behavior.  This patch updates the
corresponding conntrack state description.

Fixes: a867c010ee91 ("conntrack: Fix conntrack new state")
Reported-by: Roni Bar Yanai <roniba@mellanox.com>
Signed-off-by: Yi-Hung Wei <yihung.wei@gmail.com>
---
Please backports to branch 2.13.

---
 lib/meta-flow.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Roni Bar Yanai Feb. 24, 2020, 2:47 p.m. UTC | #1
>-----Original Message-----
>From: Yi-Hung Wei <yihung.wei@gmail.com>
>Sent: Saturday, February 22, 2020 12:51 AM
>To: dev@openvswitch.org; Roni Bar Yanai <roniba@mellanox.com>
>Cc: Yi-Hung Wei <yihung.wei@gmail.com>
>Subject: [PATCH] docs: Update conntrack established state description
>
>Patch a867c010ee91 ("conntrack: Fix conntrack new state") fixes the userspace
>conntrack behavior.  This patch updates the corresponding conntrack state
>description.
>
>Fixes: a867c010ee91 ("conntrack: Fix conntrack new state")
>Reported-by: Roni Bar Yanai <roniba@mellanox.com>
>Signed-off-by: Yi-Hung Wei <yihung.wei@gmail.com>
>---
>Please backports to branch 2.13.
>
>---
> lib/meta-flow.xml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/lib/meta-flow.xml b/lib/meta-flow.xml index
>90b405c73750..2f9c5ee16342 100644
>--- a/lib/meta-flow.xml
>+++ b/lib/meta-flow.xml
>@@ -2566,8 +2566,8 @@ actions=clone(load:0->NXM_OF_IN_PORT[],output:123)
>
>         <dt><code>est</code> (0x02)</dt>
>         <dd>
>-          Part of an existing connection.  Set to 1 if this is a committed
>-          connection.
>+          Part of an existing connection.  Set to 1 if packets of a committed
>+          connection have been seen by conntrack from both directions.
>         </dd>
>
>         <dt><code>rel</code> (0x04)</dt>
>--
>2.7.4
Looks good to me.
Acked-by: Roni Bar Yanai <roniba@mellanox.com>
William Tu Feb. 25, 2020, 10:38 p.m. UTC | #2
On Mon, Feb 24, 2020 at 02:47:54PM +0000, Roni Bar Yanai wrote:
> 
> 
> >-----Original Message-----
> >From: Yi-Hung Wei <yihung.wei@gmail.com>
> >Sent: Saturday, February 22, 2020 12:51 AM
> >To: dev@openvswitch.org; Roni Bar Yanai <roniba@mellanox.com>
> >Cc: Yi-Hung Wei <yihung.wei@gmail.com>
> >Subject: [PATCH] docs: Update conntrack established state description
> >
> >Patch a867c010ee91 ("conntrack: Fix conntrack new state") fixes the userspace
> >conntrack behavior.  This patch updates the corresponding conntrack state
> >description.
> >
> >Fixes: a867c010ee91 ("conntrack: Fix conntrack new state")
> >Reported-by: Roni Bar Yanai <roniba@mellanox.com>
> >Signed-off-by: Yi-Hung Wei <yihung.wei@gmail.com>
> >---
> >Please backports to branch 2.13.
> >
> >---
> > lib/meta-flow.xml | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> >diff --git a/lib/meta-flow.xml b/lib/meta-flow.xml index
> >90b405c73750..2f9c5ee16342 100644
> >--- a/lib/meta-flow.xml
> >+++ b/lib/meta-flow.xml
> >@@ -2566,8 +2566,8 @@ actions=clone(load:0->NXM_OF_IN_PORT[],output:123)
> >
> >         <dt><code>est</code> (0x02)</dt>
> >         <dd>
> >-          Part of an existing connection.  Set to 1 if this is a committed
> >-          connection.
> >+          Part of an existing connection.  Set to 1 if packets of a committed
> >+          connection have been seen by conntrack from both directions.
> >         </dd>
> >
> >         <dt><code>rel</code> (0x04)</dt>
> >--
> >2.7.4
> Looks good to me.
> Acked-by: Roni Bar Yanai <roniba@mellanox.com>
> 
Applied, thanks
William
diff mbox series

Patch

diff --git a/lib/meta-flow.xml b/lib/meta-flow.xml
index 90b405c73750..2f9c5ee16342 100644
--- a/lib/meta-flow.xml
+++ b/lib/meta-flow.xml
@@ -2566,8 +2566,8 @@  actions=clone(load:0->NXM_OF_IN_PORT[],output:123)
 
         <dt><code>est</code> (0x02)</dt>
         <dd>
-          Part of an existing connection.  Set to 1 if this is a committed
-          connection.
+          Part of an existing connection.  Set to 1 if packets of a committed
+          connection have been seen by conntrack from both directions.
         </dd>
 
         <dt><code>rel</code> (0x04)</dt>