From patchwork Fri Feb 21 13:25:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 1242137 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=BhZCArZE; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48PCCy5lSLz9sRl for ; Sat, 22 Feb 2020 00:36:30 +1100 (AEDT) Received: from localhost ([::1]:57882 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j58Tk-0000VT-Fd for incoming@patchwork.ozlabs.org; Fri, 21 Feb 2020 08:36:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33024) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j58Jk-00032F-4S for qemu-devel@nongnu.org; Fri, 21 Feb 2020 08:26:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j58Jj-0007RH-5i for qemu-devel@nongnu.org; Fri, 21 Feb 2020 08:26:08 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:35685 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j58Jj-0007Oa-0x for qemu-devel@nongnu.org; Fri, 21 Feb 2020 08:26:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582291559; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=paBsMW5zAXDjF5puyoeLRSe8b4xNuuGDm59bJb4U3bc=; b=BhZCArZELnxL5NNxFJykcCsDTgONQZW+nHj79P/LNy4vqxcgDQmYyM8eshdJWpz3x4CeQu xnsYobzHj90eD9q42aGvNQ94Dr+EjlWPFBFGT6NUvxyvPKopgIy1EYBvx6WMf5jIdDai3r Z++CXNtaQwU1Jxg+YRRtLKBuIMPcFHs= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-402-h-SMVGyhNY2VKFwkOT-6jg-1; Fri, 21 Feb 2020 08:25:55 -0500 X-MC-Unique: h-SMVGyhNY2VKFwkOT-6jg-1 Received: by mail-wr1-f70.google.com with SMTP id t6so1025459wru.3 for ; Fri, 21 Feb 2020 05:25:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6JNTk73NjeTv3OroNAfG3ztm3tllZwoLmRJFD7uZjK0=; b=r42kOHdwy7uHgp20YeLoB4tk16GbGNCF8Xaqp5gr8fuMJnZLb2WFKCYznOlNGkTg9O PSMDlEfAT6YwNCqlLc8ZmNWwKG/RSMVCTAz0b0DZvMuX1IQrvl3CqW5sVl1T5rHjKcYw pWTedDGSoj0xzOldSJvY4r5CjOwURpewTcFyeBV1cYYaXZlakgNgeLZmvhr0WwqYRpgv leXeD8rk/swUf9s20FdmTMH9O5z3kUpkokzqGJs4qLaguZCzC0PMA0XvX30mrUHQqByT Iu08/7tzP8B1k1m6mhPcP31p9gwQVgAH9buYHby6IFHGIbEFNMTLWdSBd48OuiXoyMGy uaag== X-Gm-Message-State: APjAAAUb/9rDq5a0ssfoIhI94Ist1xekZ1NSN7izWYNav9+977Q9D8Ri ds8PckWgjR/lmUrArs29UYM+PnBPFaG5hdFKmLgjEsTn8370RwmtlfKMTADLYT94+MdzDh2bZ2A 5021zhJBfBpwOc/o= X-Received: by 2002:a1c:1d13:: with SMTP id d19mr4054148wmd.163.1582291553724; Fri, 21 Feb 2020 05:25:53 -0800 (PST) X-Google-Smtp-Source: APXvYqzPjY8oFbGxLJLxgcK4v5NODWlpzzhdcwfRsmRXufRcVp1f1WdUGi5RdTT5vnCn6cmusuzFaA== X-Received: by 2002:a1c:1d13:: with SMTP id d19mr4054114wmd.163.1582291553379; Fri, 21 Feb 2020 05:25:53 -0800 (PST) Received: from x1w.redhat.com (78.red-88-21-202.staticip.rima-tde.net. [88.21.202.78]) by smtp.gmail.com with ESMTPSA id t13sm3947679wrw.19.2020.02.21.05.25.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Feb 2020 05:25:52 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 1/3] hw/dma/sparc32_dma: Make espdma_memory_[read/write] static Date: Fri, 21 Feb 2020 14:25:48 +0100 Message-Id: <20200221132550.22156-2-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200221132550.22156-1-philmd@redhat.com> References: <20200221132550.22156-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , Jason Wang , Mark Cave-Ayland , Laurent Vivier , Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?b?w6k=?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" No code use the espdma_memory_[read/write] functions outside of hw/dma/sparc32_dma.c, make them static. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell --- include/hw/sparc/sparc32_dma.h | 2 -- hw/dma/sparc32_dma.c | 4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/include/hw/sparc/sparc32_dma.h b/include/hw/sparc/sparc32_dma.h index ab42c5421b..b3811b617d 100644 --- a/include/hw/sparc/sparc32_dma.h +++ b/include/hw/sparc/sparc32_dma.h @@ -61,7 +61,5 @@ void ledma_memory_read(void *opaque, hwaddr addr, uint8_t *buf, int len, int do_bswap); void ledma_memory_write(void *opaque, hwaddr addr, uint8_t *buf, int len, int do_bswap); -void espdma_memory_read(void *opaque, uint8_t *buf, int len); -void espdma_memory_write(void *opaque, uint8_t *buf, int len); #endif diff --git a/hw/dma/sparc32_dma.c b/hw/dma/sparc32_dma.c index 3e4da0c47f..c9e313938c 100644 --- a/hw/dma/sparc32_dma.c +++ b/hw/dma/sparc32_dma.c @@ -142,7 +142,7 @@ static void dma_set_irq(void *opaque, int irq, int level) } } -void espdma_memory_read(void *opaque, uint8_t *buf, int len) +static void espdma_memory_read(void *opaque, uint8_t *buf, int len) { DMADeviceState *s = opaque; IOMMUState *is = (IOMMUState *)s->iommu; @@ -152,7 +152,7 @@ void espdma_memory_read(void *opaque, uint8_t *buf, int len) s->dmaregs[1] += len; } -void espdma_memory_write(void *opaque, uint8_t *buf, int len) +static void espdma_memory_write(void *opaque, uint8_t *buf, int len) { DMADeviceState *s = opaque; IOMMUState *is = (IOMMUState *)s->iommu;