diff mbox series

[1/1] Dockerfile: add imagemagick

Message ID 20200221051444.3375-1-xypron.glpk@gmx.de
State Accepted, archived
Delegated to: Tom Rini
Headers show
Series [1/1] Dockerfile: add imagemagick | expand

Commit Message

Heinrich Schuchardt Feb. 21, 2020, 5:14 a.m. UTC
In reStructured text documentation we sometimes find formatting problems.
So we should add 'make htmldocs' to our Gitlab Ci steps and let all
warning result in a build failure.

For building the htmldocs target without warnings we need the ImageMagick
package.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 Dockerfile | 1 +
 1 file changed, 1 insertion(+)

--
2.25.0

Comments

Bin Meng Feb. 21, 2020, 1:51 p.m. UTC | #1
On Fri, Feb 21, 2020 at 1:15 PM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> In reStructured text documentation we sometimes find formatting problems.
> So we should add 'make htmldocs' to our Gitlab Ci steps and let all
> warning result in a build failure.
>
> For building the htmldocs target without warnings we need the ImageMagick
> package.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  Dockerfile | 1 +
>  1 file changed, 1 insertion(+)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Tom Rini Feb. 21, 2020, 2:50 p.m. UTC | #2
On Fri, Feb 21, 2020 at 06:14:44AM +0100, Heinrich Schuchardt wrote:

> In reStructured text documentation we sometimes find formatting problems.
> So we should add 'make htmldocs' to our Gitlab Ci steps and let all
> warning result in a build failure.
> 
> For building the htmldocs target without warnings we need the ImageMagick
> package.
> 
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

Applied to gitlab-ci-runner/master, thanks!
diff mbox series

Patch

diff --git a/Dockerfile b/Dockerfile
index 1f8f7a4..32d43f7 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -53,6 +53,7 @@  RUN apt-get update && apt-get install -y \
 	grub-efi-amd64-bin \
 	grub-efi-ia32-bin \
 	iasl \
+	imagemagick \
 	iputils-ping \
 	libisl15 \
 	liblz4-tool \