Massive breakage with your libgcc patches

Bernd Schmidt <bernds@codesourcery.com> writes:

> On 11/03/11 20:20, Rainer Orth wrote:
>> 
>> 	* config/c6x/t-elf (LIB2ADDEH): Set.
>> 	* config/c6x/t-c6x-elf: Remove.
>
> It builds now, but parts of libgcc are missing. There's no sign of
> muldf3, for examples.

I found the problem: before, LIB2ADD was passed in from gcc/config via
libgcc.mvars, and added to in t-softfp.  Now the order of the t-*
fragments has been kept the same, with the assignment to LIB2ADD in
c6x/t-elf overriding what has been constructed by t-softfp before.

The following patch did the trick for me, could you give it a try?

Thanks.
        Rainer


2011-11-07  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	* config/c6x/t-elf (LIB2ADD): Add instead of assigning.

On 11/07/2011 07:15 PM, Rainer Orth wrote:
> Bernd Schmidt<bernds@codesourcery.com>  writes:
> 
>> On 11/03/11 20:20, Rainer Orth wrote:
>>>
>>> 	* config/c6x/t-elf (LIB2ADDEH): Set.
>>> 	* config/c6x/t-c6x-elf: Remove.
>>
>> It builds now, but parts of libgcc are missing. There's no sign of
>> muldf3, for examples.
> 
> I found the problem: before, LIB2ADD was passed in from gcc/config via
> libgcc.mvars, and added to in t-softfp.  Now the order of the t-*
> fragments has been kept the same, with the assignment to LIB2ADD in
> c6x/t-elf overriding what has been constructed by t-softfp before.
> 
> The following patch did the trick for me, could you give it a try?

Looks ok, but these look like they could also be broken.

./config/i386/t-darwin64:LIB2ADD = $(srcdir)/config/darwin-64.c
./config/i386/t-darwin:LIB2ADD = $(srcdir)/config/darwin-64.c
./config/i386/t-gthr-win32:LIB2ADD = $(srcdir)/config/i386/gthr-win32.c
./config/spu/t-elf:LIB2ADD = _floatdisf _floatundisf _floattisf _floatunstisf
./config/rx/t-rx:LIB2ADD = $(srcdir)/config/rx/rx-abi-functions.c
./config/mep/t-mep:LIB2ADD = \
./config/m68k/t-floatlib:LIB2ADD = $(srcdir)/config/m68k/fpgnulib.c xfgnulib.c
./config/s390/32/t-floattodi:LIB2ADD = $(addprefix $(srcdir)/config/s390/32/, $(floattodi-src))
./config/h8300/t-h8300:LIB2ADD = \
./config/cris/t-cris:LIB2ADD = _udivsi3.c _divsi3.c _umodsi3.c _modsi3.c
./config/ia64/t-hpux:LIB2ADD = $(srcdir)/config/ia64/quadlib.c $(srcdir)/floatunsitf.c
./config/picochip/t-picochip:LIB2ADD = \
./config/sh/t-linux:LIB2ADD = $(srcdir)/config/sh/linux-atomic.S
./config/sh/t-netbsd:LIB2ADD =
./config/c6x/t-elf:LIB2ADD = $(srcdir)/config/c6x/gef.c \
./config/rs6000/t-darwin64:LIB2ADD = $(srcdir)/config/rs6000/darwin-tramp.S \
./config/rs6000/t-darwin:LIB2ADD = $(srcdir)/config/rs6000/darwin-tramp.S \
./config/rs6000/t-lynx:LIB2ADD = $(srcdir)/config/rs6000/tramp.S
./config/rs6000/t-netbsd:LIB2ADD = $(srcdir)/config/rs6000/tramp.S
./config/pa/t-hpux:LIB2ADD = $(srcdir)/config/pa/lib2funcs.S $(srcdir)/config/pa/quadlib.c
./config/pa/t-pa64:LIB2ADD = $(srcdir)/config/pa/quadlib.c
./config/pa/t-linux:LIB2ADD = $(srcdir)/config/pa/fptr.c
./config/iq2000/t-iq2000:LIB2ADD = $(srcdir)/udivmod.c \

Paolo

On 11/07/11 19:15, Rainer Orth wrote:
> 
> 	* config/c6x/t-elf (LIB2ADD): Add instead of assigning.

It does seem happier that way, please install. Please also check the
list of files Paolo generated.


Bernd

Bernd Schmidt <bernds@codesourcery.com> writes:

> On 11/07/11 19:15, Rainer Orth wrote:
>> 
>> 	* config/c6x/t-elf (LIB2ADD): Add instead of assigning.
>
> It does seem happier that way, please install. Please also check the
> list of files Paolo generated.

Done.  Checking this in other cases has been the plan all along.

	Rainer