diff mbox

[next] staging-slicoss: Kill directly reference of netdev->priv

Message ID 493946EB.7000308@cn.fujitsu.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Wang Chen Dec. 5, 2008, 3:21 p.m. UTC
Simply replace netdev->priv with netdev_priv().

Compile test only.

Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
---
 drivers/staging/slicoss/slicoss.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

Comments

David Miller Dec. 7, 2008, 7:59 a.m. UTC | #1
From: Wang Chen <wangchen@cn.fujitsu.com>
Date: Fri, 05 Dec 2008 23:21:15 +0800

> Simply replace netdev->priv with netdev_priv().
> 
> Compile test only.
> 
> Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>

Also applied, thanks Wang.

Wang, how much more of this stuff do you estimate we still
have to fix up before we can really kill off ->priv?

Just curious...
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Wang Chen Dec. 8, 2008, 12:32 a.m. UTC | #2
David Miller said the following on 2008-12-7 15:59:
> From: Wang Chen <wangchen@cn.fujitsu.com>
> Date: Fri, 05 Dec 2008 23:21:15 +0800
> 
>> Simply replace netdev->priv with netdev_priv().
>>
>> Compile test only.
>>
>> Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
> 
> Also applied, thanks Wang.
> 
> Wang, how much more of this stuff do you estimate we still
> have to fix up before we can really kill off ->priv?
> 
> Just curious...
> 

Only one left, as I grepped last week.
I will finish it this week.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
index 8fa9490..0039036 100644
--- a/drivers/staging/slicoss/slicoss.c
+++ b/drivers/staging/slicoss/slicoss.c
@@ -765,8 +765,7 @@  static int slic_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
 #ifdef SLIC_USER_REQUEST_DUMP_ENABLED
 	case SIOCSLICDUMPCARD:
 		{
-			struct adapter *adapter = (struct adapter *)
-							dev->priv;
+			struct adapter *adapter = netdev_priv(dev);
 			struct sliccard *card;
 
 			ASSERT(adapter);
@@ -1685,7 +1684,7 @@  static void slic_timer_ping(ulong dev)
 	struct sliccard *card;
 
 	ASSERT(dev);
-	adapter = (struct adapter *)((struct net_device *) dev)->priv;
+	adapter = netdev_priv((struct net_device *)dev);
 	ASSERT(adapter);
 	card = adapter->card;
 	ASSERT(card);
@@ -3136,7 +3135,7 @@  static void slic_timer_get_stats(ulong dev)
 	struct slic_shmem *pshmem;
 
 	ASSERT(dev);
-	adapter = (struct adapter *)((struct net_device *)dev)->priv;
+	adapter = netdev_priv((struct net_device *)dev);
 	ASSERT(adapter);
 	card = adapter->card;
 	ASSERT(card);