| Message ID | 20200220095854.4804-16-manivannan.sadhasivam@linaro.org |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | None | expand |
On Thu 20 Feb 01:58 PST 2020, Manivannan Sadhasivam wrote: > IPC Router protocol is also used by external modems for exchanging the QMI > messages. Hence, it doesn't always depend on Qualcomm platforms. As a side > effect of removing the ARCH_QCOM dependency, it is going to miss the > COMPILE_TEST build coverage. The COMPILE_TEST was there so that the code could be compile tested on other platforms, but without the ARCH_QCOM dependency this will always be the case. So I would suggest that you drop the last sentence. (Or write "With this we no longer need to depend on COMPILE_TEST, so remove that too.") Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Regards, Bjorn > > Cc: "David S. Miller" <davem@davemloft.net> > Cc: netdev@vger.kernel.org > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- > net/qrtr/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/net/qrtr/Kconfig b/net/qrtr/Kconfig > index 8eb876471564..f362ca316015 100644 > --- a/net/qrtr/Kconfig > +++ b/net/qrtr/Kconfig > @@ -4,7 +4,6 @@ > > config QRTR > tristate "Qualcomm IPC Router support" > - depends on ARCH_QCOM || COMPILE_TEST > ---help--- > Say Y if you intend to use Qualcomm IPC router protocol. The > protocol is used to communicate with services provided by other > -- > 2.17.1 >
diff --git a/net/qrtr/Kconfig b/net/qrtr/Kconfig index 8eb876471564..f362ca316015 100644 --- a/net/qrtr/Kconfig +++ b/net/qrtr/Kconfig @@ -4,7 +4,6 @@ config QRTR tristate "Qualcomm IPC Router support" - depends on ARCH_QCOM || COMPILE_TEST ---help--- Say Y if you intend to use Qualcomm IPC router protocol. The protocol is used to communicate with services provided by other
IPC Router protocol is also used by external modems for exchanging the QMI messages. Hence, it doesn't always depend on Qualcomm platforms. As a side effect of removing the ARCH_QCOM dependency, it is going to miss the COMPILE_TEST build coverage. Cc: "David S. Miller" <davem@davemloft.net> Cc: netdev@vger.kernel.org Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> --- net/qrtr/Kconfig | 1 - 1 file changed, 1 deletion(-)