diff mbox series

[v1,4/4] ARM: dts: imx8qxp-colibri: dm-pre-proper for pd_dma nodes

Message ID 20200219130452.8895-4-igor.opaniuk@gmail.com
State Superseded
Delegated to: Stefano Babic
Headers show
Series [v1,1/4] ARM: dts: imx8qm-apalis: replace dm-spl with dm-pre-proper | expand

Commit Message

Igor Opaniuk Feb. 19, 2020, 1:04 p.m. UTC 
From: Igor Opaniuk <igor.opaniuk@toradex.com>

pd_dma_* nodes should be accessible during pre-relocation stage of
U-Boot proper for properly handling power domains.

This fixes the issue with permanent failing of invocation of
power_domain_get_by_index() in the common code of DM power domain
uclass (drivers/power/domain/power-domain-uclass.c).

Fixes: f0cc4eae9a ("core: device: use dev_power_domain_on")
Signed-off-by: Igor Opaniuk <igor.opaniuk@toradex.com>
---

 arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)

Comments

Oleksandr Suvorov Feb. 19, 2020, 1:38 p.m. UTC | #1 
On Wed, Feb 19, 2020 at 3:05 PM Igor Opaniuk <igor.opaniuk@gmail.com> wrote:
>
> From: Igor Opaniuk <igor.opaniuk@toradex.com>
>
> pd_dma_* nodes should be accessible during pre-relocation stage of
> U-Boot proper for properly handling power domains.
>
> This fixes the issue with permanent failing of invocation of
> power_domain_get_by_index() in the common code of DM power domain
> uclass (drivers/power/domain/power-domain-uclass.c).
>
> Fixes: f0cc4eae9a ("core: device: use dev_power_domain_on")
> Signed-off-by: Igor Opaniuk <igor.opaniuk@toradex.com>

Reviewed-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>

> ---
>
>  arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi b/arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi
> index 87de9b5653..322429a98a 100644
> --- a/arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi
> +++ b/arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi
> @@ -56,6 +56,18 @@
>         u-boot,dm-pre-proper;
>  };
>
> +&pd_dma {
> +       u-boot,dm-pre-proper;
> +};
> +
> +&pd_dma_lpuart0 {
> +       u-boot,dm-pre-proper;
> +};
> +
> +&pd_dma_lpuart3 {
> +       u-boot,dm-pre-proper;
> +};
> +
>  &pd_conn {
>         u-boot,dm-pre-proper;
>  };
> --
> 2.17.1
>
Igor Opaniuk March 11, 2020, 1:37 p.m. UTC | #2 
Hi Stefano,

On Wed, Feb 19, 2020 at 3:38 PM Oleksandr Suvorov
<oleksandr.suvorov@toradex.com> wrote:
>
> On Wed, Feb 19, 2020 at 3:05 PM Igor Opaniuk <igor.opaniuk@gmail.com> wrote:
> >
> > From: Igor Opaniuk <igor.opaniuk@toradex.com>
> >
> > pd_dma_* nodes should be accessible during pre-relocation stage of
> > U-Boot proper for properly handling power domains.
> >
> > This fixes the issue with permanent failing of invocation of
> > power_domain_get_by_index() in the common code of DM power domain
> > uclass (drivers/power/domain/power-domain-uclass.c).
> >
> > Fixes: f0cc4eae9a ("core: device: use dev_power_domain_on")
> > Signed-off-by: Igor Opaniuk <igor.opaniuk@toradex.com>
>
> Reviewed-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
>
> > ---
> >
> >  arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> >
> > diff --git a/arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi b/arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi
> > index 87de9b5653..322429a98a 100644
> > --- a/arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi
> > +++ b/arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi
> > @@ -56,6 +56,18 @@
> >         u-boot,dm-pre-proper;
> >  };
> >
> > +&pd_dma {
> > +       u-boot,dm-pre-proper;
> > +};
> > +
> > +&pd_dma_lpuart0 {
> > +       u-boot,dm-pre-proper;
> > +};
> > +
> > +&pd_dma_lpuart3 {
> > +       u-boot,dm-pre-proper;
> > +};
> > +
> >  &pd_conn {
> >         u-boot,dm-pre-proper;
> >  };
> > --
> > 2.17.1
> >
>
>
> --
> Best regards
> Oleksandr Suvorov
>
> Toradex AG
> Altsagenstrasse 5 | 6048 Horw/Luzern | Switzerland | T: +41 41 500
> 4800 (main line)

Could you please pull this patch-series for v2020.04, as it fixes
broken U-Boot on both Colibri iMX8QXP/Apalis iMX8QM?

Thanks!
diff mbox series

Patch

diff --git a/arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi b/arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi
index 87de9b5653..322429a98a 100644
--- a/arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi
+++ b/arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi
@@ -56,6 +56,18 @@ 
 	u-boot,dm-pre-proper;
 };
 
+&pd_dma {
+	u-boot,dm-pre-proper;
+};
+
+&pd_dma_lpuart0 {
+	u-boot,dm-pre-proper;
+};
+
+&pd_dma_lpuart3 {
+	u-boot,dm-pre-proper;
+};
+
 &pd_conn {
 	u-boot,dm-pre-proper;
 };