| Message ID | 20200218083836.6369-6-patrick.delaunay@st.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Marek Vasut |
| Headers | show |
| Series | [v2,1/8] phy: generic: add error trace to detect PHY issue in uclass | expand |
On 2/18/20 9:38 AM, Patrick Delaunay wrote: > As the error message is now displayed by generic phy functions, > the pr_err can be change to pr_debug. > > Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com> > --- > > Changes in v2: None > > drivers/usb/dwc3/core.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > index c5066529b7..6304036c00 100644 > --- a/drivers/usb/dwc3/core.c > +++ b/drivers/usb/dwc3/core.c > @@ -867,8 +867,8 @@ int dwc3_setup_phy(struct udevice *dev, struct phy **array, int *num_phys) > for (i = 0; i < count; i++) { > ret = generic_phy_init(&usb_phys[i]); > if (ret) { > - pr_err("Can't init USB PHY%d for %s\n", > - i, dev->name); > + pr_debug("Can't init USB PHY%d for %s\n", > + i, dev->name); dev_dbg() , since you have a dev pointer.
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index c5066529b7..6304036c00 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -867,8 +867,8 @@ int dwc3_setup_phy(struct udevice *dev, struct phy **array, int *num_phys) for (i = 0; i < count; i++) { ret = generic_phy_init(&usb_phys[i]); if (ret) { - pr_err("Can't init USB PHY%d for %s\n", - i, dev->name); + pr_debug("Can't init USB PHY%d for %s\n", + i, dev->name); goto phys_init_err; } } @@ -876,8 +876,8 @@ int dwc3_setup_phy(struct udevice *dev, struct phy **array, int *num_phys) for (i = 0; i < count; i++) { ret = generic_phy_power_on(&usb_phys[i]); if (ret) { - pr_err("Can't power USB PHY%d for %s\n", - i, dev->name); + pr_debug("Can't power USB PHY%d for %s\n", + i, dev->name); goto phys_poweron_err; } } @@ -913,8 +913,8 @@ int dwc3_shutdown_phy(struct udevice *dev, struct phy *usb_phys, int num_phys) ret = generic_phy_power_off(&usb_phys[i]); ret |= generic_phy_exit(&usb_phys[i]); if (ret) { - pr_err("Can't shutdown USB PHY%d for %s\n", - i, dev->name); + pr_debug("Can't shutdown USB PHY%d for %s\n", + i, dev->name); } }
As the error message is now displayed by generic phy functions, the pr_err can be change to pr_debug. Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com> --- Changes in v2: None drivers/usb/dwc3/core.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)