From patchwork Sun Nov  6 21:05:05 2011
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Aldy Hernandez <aldyh@redhat.com>
X-Patchwork-Id: 123967
Return-Path: 
 <gcc-patches-return-306936-incoming=patchwork.ozlabs.org@gcc.gnu.org>
X-Original-To: incoming@patchwork.ozlabs.org
Delivered-To: patchwork-incoming@bilbo.ozlabs.org
Received: from sourceware.org (server1.sourceware.org [209.132.180.131])
	by ozlabs.org (Postfix) with SMTP id 842551007D3
	for <incoming@patchwork.ozlabs.org>;
	Mon,  7 Nov 2011 08:05:29 +1100 (EST)
Received: (qmail 6155 invoked by alias); 6 Nov 2011 21:05:27 -0000
Received: (qmail 6144 invoked by uid 22791); 6 Nov 2011 21:05:26 -0000
X-SWARE-Spam-Status: No, hits=-7.1 required=5.0	tests=AWL, BAYES_00,
	RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by
	sourceware.org (qpsmtpd/0.43rc1) with ESMTP;
	Sun, 06 Nov 2011 21:05:07 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by
	mx1.redhat.com (8.14.4/8.14.4) with ESMTP id
	pA6L57TB015548	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA
	bits=256 verify=OK); Sun, 6 Nov 2011 16:05:07 -0500
Received: from austin.quesejoda.com (vpn-11-235.rdu.redhat.com
	[10.11.11.235])	by int-mx01.intmail.prod.int.phx2.redhat.com
	(8.13.8/8.13.8) with ESMTP id pA6L55nk023034;
	Sun, 6 Nov 2011 16:05:06 -0500
Message-ID: <4EB6F681.9050000@redhat.com>
Date: Sun, 06 Nov 2011 13:05:05 -0800
From: Aldy Hernandez <aldyh@redhat.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US;
	rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc14
	Lightning/1.0b3pre Thunderbird/3.1.10
MIME-Version: 1.0
To: Diego Novillo <dnovillo@google.com>
CC: gcc-patches <gcc-patches@gcc.gnu.org>,
	Richard Guenther <richard.guenther@gmail.com>
Subject: Re: PR lto/50964: [trans-mem] fail gracefully when -flto and
	-fgnu-tm
References: <4EB6E81A.1040409@redhat.com>
	<CAD_=9DTVyOjCy=NAa+q5_6FKzF1Fa0uHTQPt1uNUyt=Wkbeo8w@mail.gmail.com>
In-Reply-To: 
 <CAD_=9DTVyOjCy=NAa+q5_6FKzF1Fa0uHTQPt1uNUyt=Wkbeo8w@mail.gmail.com>
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Unsubscribe: 
 <mailto:gcc-patches-unsubscribe-incoming=patchwork.ozlabs.org@gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Delivered-To: mailing list gcc-patches@gcc.gnu.org

> "LTO support is currently not supported with transactional memory"
>
> 'support' mentioned one too many times.  Maybe 'LTO is currently not
> supported with transactional memory'?
>
>
> Diego.

How is this?
* opts.c (finish_options): Error out when using -flto and
	-fgnu-tm.

Index: opts.c
===================================================================
--- opts.c	(revision 181028)
+++ opts.c	(working copy)
@@ -784,6 +784,8 @@ finish_options (struct gcc_options *opts
 #endif
       if (!opts->x_flag_fat_lto_objects && !HAVE_LTO_PLUGIN)
         error_at (loc, "-fno-fat-lto-objects are supported only with linker plugin.");
+      if (opts->x_flag_tm)
+	error_at (loc, "LTO is currently not supported with transactional memory");
 }
   if ((opts->x_flag_lto_partition_balanced != 0) + (opts->x_flag_lto_partition_1to1 != 0)
        + (opts->x_flag_lto_partition_none != 0) >= 1)