imx8qxp_mek: Fix the console command line string
diff mbox series

Message ID 20200217181701.25642-1-festevam@gmail.com
State Accepted
Commit 10a8cc01b32114c6412691206f6402ed3fc50c9f
Delegated to: Stefano Babic
Headers show
Series
  • imx8qxp_mek: Fix the console command line string
Related show

Commit Message

Fabio Estevam Feb. 17, 2020, 6:17 p.m. UTC
Currently the expansion of the console variable leads to
the following kernel command line:

console=ttyLP0,${baudrate} earlycon root=/dev/mmcblk1p2 rootwait rw

, which causes the console to not show characters after the LPUART driver
is probed as the 'baudrate' variable is not properly translated.

Fix it by splitting the console variable in two parts: one for the
ttyLP0 part and the other one for the baudrate, which matches the way
it is done on other i.MX targets.

Tested by successfully booting a mainline kernel on a i.MX8QXP MEK
board.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
Anatolij's patch is needed for booting:
https://lists.denx.de/pipermail/u-boot/2020-February/400417.html

 include/configs/imx8qxp_mek.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Fabio Estevam March 2, 2020, 5:24 p.m. UTC | #1
Hi Stefano,

On Mon, Feb 17, 2020 at 3:17 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> Currently the expansion of the console variable leads to
> the following kernel command line:
>
> console=ttyLP0,${baudrate} earlycon root=/dev/mmcblk1p2 rootwait rw
>
> , which causes the console to not show characters after the LPUART driver
> is probed as the 'baudrate' variable is not properly translated.
>
> Fix it by splitting the console variable in two parts: one for the
> ttyLP0 part and the other one for the baudrate, which matches the way
> it is done on other i.MX targets.
>
> Tested by successfully booting a mainline kernel on a i.MX8QXP MEK
> board.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> Anatolij's patch is needed for booting:
> https://lists.denx.de/pipermail/u-boot/2020-February/400417.html

Could you please apply this one and Anatolij's patch for the upcoming
2020.04 release?

Also, we have some pending i.MX6 patches converting drivers to DM that
would be nice to be applied to 2020.04 as well.

We would like to have all i.MX6 NXP development boards converted to DM
on 2020.04.

Thanks
Stefano Babic March 2, 2020, 5:57 p.m. UTC | #2
Hi Fabio,

On 02/03/20 18:24, Fabio Estevam wrote:
> Hi Stefano,
> 
> On Mon, Feb 17, 2020 at 3:17 PM Fabio Estevam <festevam@gmail.com> wrote:
>>
>> Currently the expansion of the console variable leads to
>> the following kernel command line:
>>
>> console=ttyLP0,${baudrate} earlycon root=/dev/mmcblk1p2 rootwait rw
>>
>> , which causes the console to not show characters after the LPUART driver
>> is probed as the 'baudrate' variable is not properly translated.
>>
>> Fix it by splitting the console variable in two parts: one for the
>> ttyLP0 part and the other one for the baudrate, which matches the way
>> it is done on other i.MX targets.
>>
>> Tested by successfully booting a mainline kernel on a i.MX8QXP MEK
>> board.
>>
>> Signed-off-by: Fabio Estevam <festevam@gmail.com>
>> ---
>> Anatolij's patch is needed for booting:
>> https://lists.denx.de/pipermail/u-boot/2020-February/400417.html
> 
> Could you please apply this one and Anatolij's patch for the upcoming
> 2020.04 release?
> 
> Also, we have some pending i.MX6 patches converting drivers to DM that
> would be nice to be applied to 2020.04 as well.
> 
> We would like to have all i.MX6 NXP development boards converted to DM
> on 2020.04.
> 

Yes, I will take care of it.

Stefano
Stefano Babic March 10, 2020, 3:32 p.m. UTC | #3
> Currently the expansion of the console variable leads to
> the following kernel command line:
> console=ttyLP0,${baudrate} earlycon root=/dev/mmcblk1p2 rootwait rw
> , which causes the console to not show characters after the LPUART driver
> is probed as the 'baudrate' variable is not properly translated.
> Fix it by splitting the console variable in two parts: one for the
> ttyLP0 part and the other one for the baudrate, which matches the way
> it is done on other i.MX targets.
> Tested by successfully booting a mainline kernel on a i.MX8QXP MEK
> board.
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Patch
diff mbox series

diff --git a/include/configs/imx8qxp_mek.h b/include/configs/imx8qxp_mek.h
index 81ac4b52f3..0aaca3325b 100644
--- a/include/configs/imx8qxp_mek.h
+++ b/include/configs/imx8qxp_mek.h
@@ -65,7 +65,7 @@ 
 	"script=boot.scr\0" \
 	"image=Image\0" \
 	"panel=NULL\0" \
-	"console=ttyLP0,${baudrate} earlycon\0" \
+	"console=ttyLP0\0" \
 	"fdt_addr=0x83000000\0"			\
 	"fdt_high=0xffffffffffffffff\0"		\
 	"boot_fdt=try\0" \
@@ -76,7 +76,7 @@ 
 	"mmcpart=" __stringify(CONFIG_SYS_MMC_IMG_LOAD_PART) "\0" \
 	"mmcroot=" CONFIG_MMCROOT " rootwait rw\0" \
 	"mmcautodetect=yes\0" \
-	"mmcargs=setenv bootargs console=${console} root=${mmcroot}\0 " \
+	"mmcargs=setenv bootargs console=${console},${baudrate} root=${mmcroot}\0 " \
 	"loadbootscript=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \
 	"bootscript=echo Running bootscript from mmc ...; " \
 		"source\0" \
@@ -104,7 +104,7 @@ 
 				"echo wait for boot; " \
 			"fi;" \
 		"fi;\0" \
-	"netargs=setenv bootargs console=${console} " \
+	"netargs=setenv bootargs console=${console},${baudrate} " \
 		"root=/dev/nfs " \
 		"ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp\0" \
 	"netboot=echo Booting from net ...; " \