From patchwork Sun Nov 6 15:28:21 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Torvald Riegel X-Patchwork-Id: 123943 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 98C7A1007D2 for ; Mon, 7 Nov 2011 04:41:54 +1100 (EST) Received: (qmail 15764 invoked by alias); 6 Nov 2011 17:41:52 -0000 Received: (qmail 15751 invoked by uid 22791); 6 Nov 2011 17:41:51 -0000 X-SWARE-Spam-Status: No, hits=-3.9 required=5.0 tests=AWL,BAYES_00,SPF_FAIL X-Spam-Check-By: sourceware.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (140.186.70.92) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 06 Nov 2011 17:41:35 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RN4eJ-00009N-MU for gcc-patches@gcc.gnu.org; Sun, 06 Nov 2011 10:28:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:19437) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RN4eJ-00009C-FP for gcc-patches@gcc.gnu.org; Sun, 06 Nov 2011 10:28:43 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pA6FSOum029913 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 6 Nov 2011 10:28:24 -0500 Received: from [10.36.4.73] (vpn1-4-73.ams2.redhat.com [10.36.4.73]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id pA6FSM1u032300; Sun, 6 Nov 2011 10:28:23 -0500 Subject: Re: [patch] 17/n: trans-mem: compiler trans-mem main engine From: Torvald Riegel To: "Joseph S. Myers" Cc: Aldy Hernandez , gcc-patches In-Reply-To: <1320443299.5756.1066.camel@triegel.csb> References: <4EB2E6FC.5070901@redhat.com> <1320443299.5756.1066.camel@triegel.csb> Date: Sun, 06 Nov 2011 16:28:21 +0100 Message-ID: <1320593301.18023.299.camel@triegel.csb> Mime-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 209.132.183.28 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Fri, 2011-11-04 at 22:48 +0100, Torvald Riegel wrote: > On Thu, 2011-11-03 at 20:38 +0000, Joseph S. Myers wrote: > > Make sure that you do need each #include present in this and any other new > > file. Since 2008 a lot of includes of tm.h and toplev.h have been removed > > and diagnostic-core.h introduced as an alternative to diagnostic.h for > > many users. If tm.h is needed, it's good to have a comment on the > > #include explaining why (which target macros are used, for example), since > > we'd like to avoid unnecessary tm.h includes. > > See attached patch. OK for branch? I should have updated the build dependencies too, which this patch does. OK for branch? commit f71658c4f454f8327365891e878d5810102f04da Author: Torvald Riegel Date: Sun Nov 6 15:25:16 2011 +0100 Fix dependencies for trans-mem.o. * Makefile.in: Fix dependencies for trans-mem.o. diff --git a/gcc/Makefile.in b/gcc/Makefile.in index 027ea42..625ccbc 100644 --- a/gcc/Makefile.in +++ b/gcc/Makefile.in @@ -2310,10 +2310,10 @@ gtype-desc.o: gtype-desc.c $(CONFIG_H) $(SYSTEM_H) coretypes.h $(TM_H) \ $(CFGLOOP_H) $(TARGET_H) $(IPA_PROP_H) $(LTO_STREAMER_H) \ target-globals.h -trans-mem.o : trans-mem.c $(CONFIG_H) $(SYSTEM_H) coretypes.h $(TM_H) \ - $(TREE_H) $(GIMPLE_H) $(TREE_FLOW_H) tree-pass.h except.h \ - $(DIAGNOSTIC_H) $(TOPLEV_H) $(FLAGS_H) $(DEMANGLE_H) $(TRANS_MEM_H) \ - $(TREE_DUMP_H) $(PARAMS_H) $(TARGET_DEF_H) \ +trans-mem.o : trans-mem.c $(CONFIG_H) $(SYSTEM_H) coretypes.h \ + $(TREE_H) $(GIMPLE_H) $(TREE_FLOW_H) $(TREE_PASS_H) $(TREE_INLINE_H) \ + $(DIAGNOSTIC_CORE_H) $(DEMANGLE_H) output.h $(TRANS_MEM_H) \ + $(PARAMS_H) $(TARGET_H) langhooks.h \ tree-pretty-print.h gimple-pretty-print.h ggc-common.o: ggc-common.c $(CONFIG_H) $(SYSTEM_H) coretypes.h \