From patchwork Sun Nov 6 15:28:21 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: 17/n: trans-mem: compiler trans-mem main engine Date: Sun, 06 Nov 2011 05:28:21 -0000 From: Torvald Riegel X-Patchwork-Id: 123943 Message-Id: <1320593301.18023.299.camel@triegel.csb> To: "Joseph S. Myers" Cc: Aldy Hernandez , gcc-patches On Fri, 2011-11-04 at 22:48 +0100, Torvald Riegel wrote: > On Thu, 2011-11-03 at 20:38 +0000, Joseph S. Myers wrote: > > Make sure that you do need each #include present in this and any other new > > file. Since 2008 a lot of includes of tm.h and toplev.h have been removed > > and diagnostic-core.h introduced as an alternative to diagnostic.h for > > many users. If tm.h is needed, it's good to have a comment on the > > #include explaining why (which target macros are used, for example), since > > we'd like to avoid unnecessary tm.h includes. > > See attached patch. OK for branch? I should have updated the build dependencies too, which this patch does. OK for branch? commit f71658c4f454f8327365891e878d5810102f04da Author: Torvald Riegel Date: Sun Nov 6 15:25:16 2011 +0100 Fix dependencies for trans-mem.o. * Makefile.in: Fix dependencies for trans-mem.o. diff --git a/gcc/Makefile.in b/gcc/Makefile.in index 027ea42..625ccbc 100644 --- a/gcc/Makefile.in +++ b/gcc/Makefile.in @@ -2310,10 +2310,10 @@ gtype-desc.o: gtype-desc.c $(CONFIG_H) $(SYSTEM_H) coretypes.h $(TM_H) \ $(CFGLOOP_H) $(TARGET_H) $(IPA_PROP_H) $(LTO_STREAMER_H) \ target-globals.h -trans-mem.o : trans-mem.c $(CONFIG_H) $(SYSTEM_H) coretypes.h $(TM_H) \ - $(TREE_H) $(GIMPLE_H) $(TREE_FLOW_H) tree-pass.h except.h \ - $(DIAGNOSTIC_H) $(TOPLEV_H) $(FLAGS_H) $(DEMANGLE_H) $(TRANS_MEM_H) \ - $(TREE_DUMP_H) $(PARAMS_H) $(TARGET_DEF_H) \ +trans-mem.o : trans-mem.c $(CONFIG_H) $(SYSTEM_H) coretypes.h \ + $(TREE_H) $(GIMPLE_H) $(TREE_FLOW_H) $(TREE_PASS_H) $(TREE_INLINE_H) \ + $(DIAGNOSTIC_CORE_H) $(DEMANGLE_H) output.h $(TRANS_MEM_H) \ + $(PARAMS_H) $(TARGET_H) langhooks.h \ tree-pretty-print.h gimple-pretty-print.h ggc-common.o: ggc-common.c $(CONFIG_H) $(SYSTEM_H) coretypes.h \