17/n: trans-mem: compiler trans-mem main engine

Submitter	Torvald Riegel
Date	Nov. 6, 2011, 3:28 p.m.
Message ID	<1320593301.18023.299.camel@triegel.csb>
Download	mbox \| patch
Permalink	/patch/123943/
State	New
Headers	show Return-Path: <gcc-patches-return-306900-incoming=patchwork.ozlabs.org@gcc.gnu.org> Subject: Re: [patch] 17/n: trans-mem: compiler trans-mem main engine From: Torvald Riegel <triegel@redhat.com> To: "Joseph S. Myers" <joseph@codesourcery.com> Cc: Aldy Hernandez <aldyh@redhat.com>, gcc-patches <gcc-patches@gcc.gnu.org> In-Reply-To: <1320443299.5756.1066.camel@triegel.csb> References: <4EB2E6FC.5070901@redhat.com> <Pine.LNX.4.64.1111032036360.31547@digraph.polyomino.org.uk> <1320443299.5756.1066.camel@triegel.csb> Content-Type: multipart/mixed; boundary="=-dAhe97G6Bk81bbPy/6fy" Date: Sun, 06 Nov 2011 16:28:21 +0100 Message-ID: <1320593301.18023.299.camel@triegel.csb> Mime-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk Sender: gcc-patches-owner@gcc.gnu.org

Comments

Torvald Riegel - Nov. 6, 2011, 3:28 p.m.

On Fri, 2011-11-04 at 22:48 +0100, Torvald Riegel wrote:
> On Thu, 2011-11-03 at 20:38 +0000, Joseph S. Myers wrote:
> > Make sure that you do need each #include present in this and any other new 
> > file.  Since 2008 a lot of includes of tm.h and toplev.h have been removed 
> > and diagnostic-core.h introduced as an alternative to diagnostic.h for 
> > many users.  If tm.h is needed, it's good to have a comment on the 
> > #include explaining why (which target macros are used, for example), since 
> > we'd like to avoid unnecessary tm.h includes.
> 
> See attached patch. OK for branch?

I should have updated the build dependencies too, which this patch does.
OK for branch?
commit f71658c4f454f8327365891e878d5810102f04da
Author: Torvald Riegel <triegel@redhat.com>
Date:   Sun Nov 6 15:25:16 2011 +0100

    Fix dependencies for trans-mem.o.
    
    	* Makefile.in: Fix dependencies for trans-mem.o.

Patch

diff --git a/gcc/Makefile.in b/gcc/Makefile.in
index 027ea42..625ccbc 100644
--- a/gcc/Makefile.in
+++ b/gcc/Makefile.in
@@ -2310,10 +2310,10 @@  gtype-desc.o: gtype-desc.c $(CONFIG_H) $(SYSTEM_H) coretypes.h $(TM_H) \
 	$(CFGLOOP_H) $(TARGET_H) $(IPA_PROP_H) $(LTO_STREAMER_H) \
 	target-globals.h
 
-trans-mem.o : trans-mem.c $(CONFIG_H) $(SYSTEM_H) coretypes.h $(TM_H) \
-	$(TREE_H) $(GIMPLE_H) $(TREE_FLOW_H) tree-pass.h except.h \
-	$(DIAGNOSTIC_H) $(TOPLEV_H) $(FLAGS_H) $(DEMANGLE_H) $(TRANS_MEM_H) \
-	$(TREE_DUMP_H) $(PARAMS_H) $(TARGET_DEF_H) \
+trans-mem.o : trans-mem.c $(CONFIG_H) $(SYSTEM_H) coretypes.h \
+	$(TREE_H) $(GIMPLE_H) $(TREE_FLOW_H) $(TREE_PASS_H) $(TREE_INLINE_H) \
+	$(DIAGNOSTIC_CORE_H) $(DEMANGLE_H) output.h $(TRANS_MEM_H) \
+	$(PARAMS_H) $(TARGET_H) langhooks.h \
 	tree-pretty-print.h gimple-pretty-print.h
 
 ggc-common.o: ggc-common.c $(CONFIG_H) $(SYSTEM_H) coretypes.h		\

Patchwork 17/n: trans-mem: compiler trans-mem main engine

Comments

Patch