| Message ID | 1320586010-21931-4-git-send-email-julia@diku.dk |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
On Sun, Nov 6, 2011 at 3:26 PM, Julia Lawall <julia@diku.dk> wrote: > From: Julia Lawall <julia@diku.dk> > > Use kstrtoul, etc instead of the now deprecated strict_strtoul, etc. > > A semantic patch rule for the kstrtoul case is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > expression a,b; > {int,long} *c; > @@ > > -strict_strtoul > +kstrtoul > (a,b,c) > // </smpl> > > Signed-off-by: Julia Lawall <julia@diku.dk> > > --- > net/mac80211/debugfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -u -p a/net/mac80211/debugfs.c b/net/mac80211/debugfs.c > --- a/net/mac80211/debugfs.c > +++ b/net/mac80211/debugfs.c > @@ -190,7 +190,7 @@ static ssize_t uapsd_max_sp_len_write(st > return -EFAULT; > buf[len] = '\0'; > > - ret = strict_strtoul(buf, 0, &val); > + ret = kstrtoul(buf, 0, &val); > > if (ret) > return -EINVAL; > maybe while cleaning it up change copy_from_user + strict_stroul/kstroul -> kstroul_from_user? Eliad. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 7 Nov 2011, Eliad Peller wrote: > On Sun, Nov 6, 2011 at 3:26 PM, Julia Lawall <julia@diku.dk> wrote: >> From: Julia Lawall <julia@diku.dk> >> >> Use kstrtoul, etc instead of the now deprecated strict_strtoul, etc. >> >> A semantic patch rule for the kstrtoul case is as follows: >> (http://coccinelle.lip6.fr/) >> >> // <smpl> >> @@ >> expression a,b; >> {int,long} *c; >> @@ >> >> -strict_strtoul >> +kstrtoul >> (a,b,c) >> // </smpl> >> >> Signed-off-by: Julia Lawall <julia@diku.dk> >> >> --- >> net/mac80211/debugfs.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff -u -p a/net/mac80211/debugfs.c b/net/mac80211/debugfs.c >> --- a/net/mac80211/debugfs.c >> +++ b/net/mac80211/debugfs.c >> @@ -190,7 +190,7 @@ static ssize_t uapsd_max_sp_len_write(st >> return -EFAULT; >> buf[len] = '\0'; >> >> - ret = strict_strtoul(buf, 0, &val); >> + ret = kstrtoul(buf, 0, &val); >> >> if (ret) >> return -EINVAL; >> > > maybe while cleaning it up change copy_from_user + > strict_stroul/kstroul -> kstroul_from_user? Thanks for the suggestion. I will look into it. julia
diff -u -p a/net/mac80211/debugfs.c b/net/mac80211/debugfs.c --- a/net/mac80211/debugfs.c +++ b/net/mac80211/debugfs.c @@ -190,7 +190,7 @@ static ssize_t uapsd_max_sp_len_write(st return -EFAULT; buf[len] = '\0'; - ret = strict_strtoul(buf, 0, &val); + ret = kstrtoul(buf, 0, &val); if (ret) return -EINVAL;