Patchwork [U-Boot,07/22] common/cmd_flash.c: Fix GCC 4.6 build warnings

login
register
mail settings
Submitter Wolfgang Denk
Date Nov. 5, 2011, 3:13 p.m.
Message ID <1320505999-9770-8-git-send-email-wd@denx.de>
Download mbox | patch
Permalink /patch/123861/
State Accepted
Commit 4f5710f740adf8af827427ecd7d3df8619849a6b
Headers show

Comments

Wolfgang Denk - Nov. 5, 2011, 3:13 p.m.
Fix:
cmd_flash.c:355:32: warning: 'info' may be used uninitialized in this
function [-Wuninitialized]
cmd_flash.c:354:10: warning: 'sect_first' may be used uninitialized in
this function [-Wuninitialized]
cmd_flash.c:354:10: warning: 'sect_last' may be used uninitialized in
this function [-Wuninitialized]
cmd_flash.c: In function 'do_protect':
cmd_flash.c:540:9: warning: 'info' may be used uninitialized in this
function [-Wuninitialized]
cmd_flash.c:538:9: warning: 'sect_first' may be used uninitialized in
this function [-Wuninitialized]
cmd_flash.c:538:9: warning: 'sect_last' may be used uninitialized in
this function [-Wuninitialized]

Signed-off-by: Wolfgang Denk <wd@denx.de>
---
 common/cmd_flash.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
Wolfgang Denk - Nov. 7, 2011, 9:47 p.m.
Dear Wolfgang Denk,

In message <1320505999-9770-8-git-send-email-wd@denx.de> you wrote:
> Fix:
> cmd_flash.c:355:32: warning: 'info' may be used uninitialized in this
> function [-Wuninitialized]
> cmd_flash.c:354:10: warning: 'sect_first' may be used uninitialized in
> this function [-Wuninitialized]
> cmd_flash.c:354:10: warning: 'sect_last' may be used uninitialized in
> this function [-Wuninitialized]
> cmd_flash.c: In function 'do_protect':
> cmd_flash.c:540:9: warning: 'info' may be used uninitialized in this
> function [-Wuninitialized]
> cmd_flash.c:538:9: warning: 'sect_first' may be used uninitialized in
> this function [-Wuninitialized]
> cmd_flash.c:538:9: warning: 'sect_last' may be used uninitialized in
> this function [-Wuninitialized]
> 
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> ---
>  common/cmd_flash.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Patch

diff --git a/common/cmd_flash.c b/common/cmd_flash.c
index 6765347..c6ea25a 100644
--- a/common/cmd_flash.c
+++ b/common/cmd_flash.c
@@ -324,9 +324,9 @@  int do_flinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 int do_flerase (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 {
 #ifndef CONFIG_SYS_NO_FLASH
-	flash_info_t *info;
+	flash_info_t *info = NULL;
 	ulong bank, addr_first, addr_last;
-	int n, sect_first, sect_last;
+	int n, sect_first = 0, sect_last = 0;
 #if defined(CONFIG_CMD_MTDPARTS)
 	struct mtd_device *dev;
 	struct part_info *part;
@@ -457,9 +457,9 @@  int do_protect (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 {
 	int rcode = 0;
 #ifndef CONFIG_SYS_NO_FLASH
-	flash_info_t *info;
+	flash_info_t *info = NULL;
 	ulong bank;
-	int i, n, sect_first, sect_last;
+	int i, n, sect_first = 0, sect_last = 0;
 #if defined(CONFIG_CMD_MTDPARTS)
 	struct mtd_device *dev;
 	struct part_info *part;