| Message ID | 20200215191543.3235-2-f4bug@amsat.org |
|---|---|
| State | New |
| Headers | show |
| Series | [01/12] hw/arm/raspi: Remove ignore_memory_transaction_failures on the raspi2 | expand |
On 2/15/20 11:15 AM, Philippe Mathieu-Daudé wrote: > Commit 1c3db49d39 added the raspi3, which uses the same peripherals > than the raspi2 (but with different ARM cores). The raspi3 was > introduced without the ignore_memory_transaction_failures flag. > Almost 2 years later, the machine is usable running U-Boot and > Linux. > In commit 00cbd5bd74 we mapped a lot of unimplemented devices, > commit d442d95f added thermal block and commit 0e5bbd7406 the > system timer. > As we are happy with the raspi3, let's remove this flag on the > raspi2. > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > hw/arm/raspi.c | 3 --- > 1 file changed, 3 deletions(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/hw/arm/raspi.c b/hw/arm/raspi.c index 90ad9b8115..221356933e 100644 --- a/hw/arm/raspi.c +++ b/hw/arm/raspi.c @@ -324,9 +324,6 @@ static void raspi_machine_class_init(ObjectClass *oc, void *data) mc->no_cdrom = 1; mc->default_cpus = mc->min_cpus = mc->max_cpus = cores_count(board_rev); mc->default_ram_size = board_ram_size(board_rev); - if (board_version(board_rev) == 2) { - mc->ignore_memory_transaction_failures = true; - } }; static const TypeInfo raspi_machine_types[] = {
Commit 1c3db49d39 added the raspi3, which uses the same peripherals than the raspi2 (but with different ARM cores). The raspi3 was introduced without the ignore_memory_transaction_failures flag. Almost 2 years later, the machine is usable running U-Boot and Linux. In commit 00cbd5bd74 we mapped a lot of unimplemented devices, commit d442d95f added thermal block and commit 0e5bbd7406 the system timer. As we are happy with the raspi3, let's remove this flag on the raspi2. Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- hw/arm/raspi.c | 3 --- 1 file changed, 3 deletions(-)