| Message ID | 20200213214656.9801-2-dafna.hirschfeld@collabora.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v3,1/2] dt-bindings: i2c: cros-ec-tunnel: convert i2c-cros-ec-tunnel.txt to yaml | expand |
Hi, On Thu, Feb 13, 2020 at 10:46:56PM +0100, Dafna Hirschfeld wrote: > add unit address to the nodes bq24735, smart-battery > > This fixes the warning: > 'bq24735', 'smart-battery' do not match any of the > regexes: '^.*@[0-9a-f]+$', 'pinctrl-[0-9]+' > > Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> > --- While fixing the node names, it makes sense to also use device class instead of name as mentioned in Documentation/devicetree/bindings/writing-bindings.txt > arch/arm64/boot/dts/nvidia/tegra132-norrin.dts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts b/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts > index a0385a386a3f..a19171f6f0f7 100644 > --- a/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts > +++ b/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts > @@ -767,7 +767,7 @@ > > google,remote-bus = <0>; > > - charger: bq24735 { > + charger: bq24735@9 { charger: charger@9 { > compatible = "ti,bq24735"; > reg = <0x9>; > interrupt-parent = <&gpio>; > @@ -778,7 +778,7 @@ > GPIO_ACTIVE_HIGH>; > }; > > - battery: smart-battery { > + battery: smart-battery@b { battery: battery@b { > compatible = "sbs,sbs-battery"; > reg = <0xb>; > battery-name = "battery"; -- Sebastian
diff --git a/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts b/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts index a0385a386a3f..a19171f6f0f7 100644 --- a/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts +++ b/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts @@ -767,7 +767,7 @@ google,remote-bus = <0>; - charger: bq24735 { + charger: bq24735@9 { compatible = "ti,bq24735"; reg = <0x9>; interrupt-parent = <&gpio>; @@ -778,7 +778,7 @@ GPIO_ACTIVE_HIGH>; }; - battery: smart-battery { + battery: smart-battery@b { compatible = "sbs,sbs-battery"; reg = <0xb>; battery-name = "battery";
add unit address to the nodes bq24735, smart-battery This fixes the warning: 'bq24735', 'smart-battery' do not match any of the regexes: '^.*@[0-9a-f]+$', 'pinctrl-[0-9]+' Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> --- arch/arm64/boot/dts/nvidia/tegra132-norrin.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)